From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] igb_uio: convert license headers to SPDX tags
Date: Mon, 18 Dec 2017 15:08:06 -0800 [thread overview]
Message-ID: <8acb43f9-0399-aacb-2898-b4ec06d546ca@intel.com> (raw)
In-Reply-To: <20171218141317.502efa2f@xeon-e3>
On 12/18/2017 2:13 PM, Stephen Hemminger wrote:
> On Mon, 18 Dec 2017 21:06:58 +0000
> Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
>> diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
>> index a3a98c173..d0e4fd966 100644
>> --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
>> +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
>> @@ -1,25 +1,6 @@
>> /*-
>> - * GPL LICENSE SUMMARY
>> - *
>> - * Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
>> - *
>> - * This program is free software; you can redistribute it and/or modify
>> - * it under the terms of version 2 of the GNU General Public License as
>> - * published by the Free Software Foundation.
>> - *
>> - * This program is distributed in the hope that it will be useful, but
>> - * WITHOUT ANY WARRANTY; without even the implied warranty of
>> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
>> - * General Public License for more details.
>> - *
>> - * You should have received a copy of the GNU General Public License
>> - * along with this program; if not, write to the Free Software
>> - * Foundation, Inc., 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.
>> - * The full GNU General Public License is included in this distribution
>> - * in the file called LICENSE.GPL.
>> - *
>> - * Contact Information:
>> - * Intel Corporation
>> + * SPDX-License-Identifier: GPL-2.0
>> + * Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
>> */
>>
>> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>
> SPDX looks better, and since this is a kernel file it should follow
> the Linux kernel standard.
>
> // SPDX-License-Identifier: GPL-2.0
> /*
> * Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
> */
OK, I will update.
Is there any benefit of following Linux kernel standard not only for kernel
modules but for all DPDK files?
>
> You might also want to do the update of year as well.
>
next prev parent reply other threads:[~2017-12-18 23:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-18 21:06 Ferruh Yigit
2017-12-18 22:13 ` Stephen Hemminger
2017-12-18 23:08 ` Ferruh Yigit [this message]
2017-12-18 23:38 ` Stephen Hemminger
2017-12-19 0:03 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2017-12-19 0:10 ` Stephen Hemminger
2017-12-19 0:17 ` Ferruh Yigit
2018-01-11 18:06 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8acb43f9-0399-aacb-2898-b4ec06d546ca@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).