DPDK patches and discussions
 help / color / mirror / Atom feed
From: Denis Pryazhennikov <Denis.Pryazhennikov@arknetworks.am>
To: Ferruh Yigit <ferruh.yigit@amd.com>, dev@dpdk.org
Cc: Ivan Malov <ivan.malov@arknetworks.am>,
	Viacheslav Galaktionov <viacheslav.galaktionov@arknetworks.am>,
	Thomas Monjalon <thomas@monjalon.net>,
	Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: Re: [RFC PATCH 3/3] ethdev: rename parameter in API to get FEC
Date: Thu, 4 May 2023 11:13:30 +0400	[thread overview]
Message-ID: <8b00ea5e-cb12-0f21-61a4-26961dc86ff8@arknetworks.am> (raw)
In-Reply-To: <f9c1219a-a1e4-c027-6da4-291edfe5b303@amd.com>

I think my patch isn't correct.
I would say that
- fec_capa is a set of bits produced by 'RTE_ETH_FEC_MODE_TO_CAPA()';
- fec_mode is an element of 'enum rte_eth_fec_mode'.

Based on this definition, replacing 'fec_capa' with 'fec_mode' should 
involve changing the parameter type.
Probably I shouldn't change the name, but I should add a more detailed 
comment.

 > Independent from being single FEC mode or not, I think both 
'rte_eth_fec_get()' & 'rte_eth_fec_set()' should get 'fec_mode' as 
param, what do you think?

Andrew Rybchenko asked to replace 'mode' with 'fec_capa' for 
'rte_eth_fec_set()' in
https://inbox.dpdk.org/dev/aa745bd1-a564-fa8c-c77b-2d99c97690aa@solarflare.com/
I don't think we need to change it for rte_eth_fec_set().

On 5/2/23 7:02 PM, Ferruh Yigit wrote:
> On 4/28/2023 11:27 AM, Denis Pryazhennikov wrote:
>> Only one valid FEC mode can be get by rte_eth_fec_get().
>> The previous name implied that more than one FEC mode
>> can be obtained.
> +1 and patch looks good.
>
> But isn't this valid for 'rte_eth_fec_set()', it gets 'fec_mode'. FEC
> capability has its own type "struct rte_eth_fec_capa".
>
> Independent from being single FEC mode or not, I think both
> 'rte_eth_fec_get()' & 'rte_eth_fec_set()' should get 'fec_mode' as
> param, what do you think?
>
>> Documentation was updated accordingly.
>>
>> Signed-off-by: Denis Pryazhennikov <denis.pryazhennikov@arknetworks.am>
>> Acked-by: Ivan Malov <ivan.malov@arknetworks.am>
>> Acked-by: Viacheslav Galaktionov <viacheslav.galaktionov@arknetworks.am>
> <...>
>

  reply	other threads:[~2023-05-04  7:13 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-28 10:27 [RFC PATCH 0/3] improve FEC API usage Denis Pryazhennikov
2023-04-28 10:27 ` [RFC PATCH 1/3] ethdev: update documentation for API to set FEC Denis Pryazhennikov
2023-05-02 14:57   ` Ferruh Yigit
2023-04-28 10:27 ` [RFC PATCH 2/3] ethdev: check that at least one FEC mode is specified Denis Pryazhennikov
2023-05-02 14:57   ` Ferruh Yigit
2023-04-28 10:27 ` [RFC PATCH 3/3] ethdev: rename parameter in API to get FEC Denis Pryazhennikov
2023-05-02 15:02   ` Ferruh Yigit
2023-05-04  7:13     ` Denis Pryazhennikov [this message]
2023-05-04  7:47       ` Ferruh Yigit
2023-05-08 11:47 ` [RFC PATCH v2 0/3] improve FEC API usage Denis Pryazhennikov
2023-05-08 11:47   ` [RFC PATCH v2 1/3] ethdev: update documentation for API to set FEC Denis Pryazhennikov
2023-05-08 11:47   ` [RFC PATCH v2 2/3] ethdev: check that at least one FEC mode is specified Denis Pryazhennikov
2023-05-08 11:47   ` [RFC PATCH v2 3/3] ethdev: update documentation for API to get FEC Denis Pryazhennikov
2023-05-12 11:57   ` [RFC PATCH v2 0/3] improve FEC API usage Ferruh Yigit
2023-06-07 18:41     ` Ferruh Yigit
2023-06-19 12:36     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8b00ea5e-cb12-0f21-61a4-26961dc86ff8@arknetworks.am \
    --to=denis.pryazhennikov@arknetworks.am \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    --cc=ivan.malov@arknetworks.am \
    --cc=thomas@monjalon.net \
    --cc=viacheslav.galaktionov@arknetworks.am \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).