From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Dai, Wei" <wei.dai@intel.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"Mcnamara, John" <john.mcnamara@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] examples/helloworld: add output of core id and socket id
Date: Wed, 17 May 2017 15:29:58 +0100 [thread overview]
Message-ID: <8b1149cf-17df-39ef-04c5-92d5bc542ce8@intel.com> (raw)
In-Reply-To: <49759EB36A64CF4892C1AFEC9231E8D650A7FA1E@PGSMSX106.gar.corp.intel.com>
On 5/17/2017 3:29 PM, Dai, Wei wrote:
>> -----Original Message-----
>> From: Yigit, Ferruh
>> Sent: Wednesday, May 17, 2017 10:16 PM
>> To: Dai, Wei <wei.dai@intel.com>; Richardson, Bruce
>> <bruce.richardson@intel.com>; Mcnamara, John <john.mcnamara@intel.com>
>> Cc: dev@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH] examples/helloworld: add output of core id and
>> socket id
>>
>> On 5/17/2017 2:49 PM, Wei Dai wrote:
>>> Adding output of core id and socket id of each lcore/pthread can help
>>> to understand their relationship.
>>> And this can also help to examine the usage of the EAL lcore settings
>>> like -c, -l and --lcore .
>>>
>>> Signed-off-by: Wei Dai <wei.dai@intel.com>
>>> ---
>>> examples/helloworld/main.c | 4 +++-
>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/examples/helloworld/main.c b/examples/helloworld/main.c
>>> index 8b7a2de..fdd8818 100644
>>> --- a/examples/helloworld/main.c
>>> +++ b/examples/helloworld/main.c
>>> @@ -50,7 +50,9 @@ lcore_hello(__attribute__((unused)) void *arg) {
>>> unsigned lcore_id;
>>> lcore_id = rte_lcore_id();
>>> - printf("hello from core %u\n", lcore_id);
>>> + printf("hello from core %2u at core_id = %2u on socket_id = %2u\n",
>>
>> It is hard to understand difference from "core" and "core_id", what do you
>> think using "lcore" and "core" respectively in the message?
> Yes, it is still a bit confused.
> I should change it to printf("hello from lcore_id = %2u at core_id = %2u on socket_id = %2u\n",
+1
>
>>
>>> + lcore_id, lcore_config[lcore_id].core_id,
>>> + lcore_config[lcore_id].socket_id);
>>> return 0;
>>> }
>>>
>>>
>
prev parent reply other threads:[~2017-05-17 14:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 13:49 Wei Dai
2017-05-17 14:16 ` Ferruh Yigit
2017-05-17 14:29 ` Dai, Wei
2017-05-17 14:29 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b1149cf-17df-39ef-04c5-92d5bc542ce8@intel.com \
--to=ferruh.yigit@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=wei.dai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).