From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Radu Nicolau <radu.nicolau@intel.com>, dev@dpdk.org
Cc: declan.doherty@intel.com
Subject: Re: [dpdk-dev] [PATCH v2] net/bonding: fix update link status on slave add
Date: Thu, 31 May 2018 17:32:56 +0100 [thread overview]
Message-ID: <8b1e1186-4a84-c10d-2056-7b8ed1310106@intel.com> (raw)
In-Reply-To: <0cbf7312-4d54-3240-82a8-239c34fc8005@intel.com>
On 5/31/2018 5:13 PM, Radu Nicolau wrote:
>
>
> On 5/31/2018 4:36 PM, Ferruh Yigit wrote:
>> On 5/31/2018 4:34 PM, Ferruh Yigit wrote:
>>> On 5/31/2018 3:34 PM, Radu Nicolau wrote:
>>>
>>> I can see you just prefix "fix" to the title without updating it :)
>>>
>>> What about following one:
>>> "net/bonding: fix slave add for mode 4" ?
> Great, I'll use it for v3 :)
>
>>>
>>>> Add a call to rte_eth_link_get_nowait on every slave to update
>>>> the internal link status struct. Otherwise slave add will fail
>>>> for mode 4 if the ports are all stopped but only one of them checked.
>>> What is the link related expectation from slaves in mode 4?
> To be identical across all ports
>>>
>>> What does "if the ports are all stopped but only one of them checked" mean, why
>>> checking only one of them?
> This is the behavior of testpmd, stop getting the link status after the
> first down port; but this should not affect bonding, so there is no need
> to update testpmd.
I see, when this link updating happens in this bonding issue context? When
bonding device created?
Should we update testpmd behavior too?
>
>>>
>>>> Fixes: b77d21cc2364 ("ethdev: add link status get/set helper functions")
>>>> Bugzilla entry: https://dpdk.org/tracker/show_bug.cgi?id=52
>> Bugzilla ID: 52
>>
>> btw, can you please send new version as reply to previous version?
> Sure.
>
>>
>>>> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
>>>> ---
>>>> v2: add fix and Bugzilla references
>>>>
>>>> drivers/net/bonding/rte_eth_bond_api.c | 2 ++
>>>> 1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/drivers/net/bonding/rte_eth_bond_api.c b/drivers/net/bonding/rte_eth_bond_api.c
>>>> index d558df8..cad08b9 100644
>>>> --- a/drivers/net/bonding/rte_eth_bond_api.c
>>>> +++ b/drivers/net/bonding/rte_eth_bond_api.c
>>>> @@ -296,6 +296,8 @@ __eth_bond_slave_add_lock_free(uint16_t bonded_port_id, uint16_t slave_port_id)
>>>> return -1;
>>>> }
>>>>
>>>> + rte_eth_link_get_nowait(slave_port_id, &link_props);
>>>> +
>>> The error seems in link_properties_valid(), does it make sense to get link info
>>> inside that function before link checks?
> Not really, as one might expect that link_properties_valid will only
> test the struct rte_eth_link *slave_link argument, not update it.
Fair enough, I just thought to be sure the tested link is up to date, but that
function seems only called by __eth_bond_slave_add_lock_free() which you are
updating, so this is ok.
>
>>>
>>>> slave_add(internals, slave_eth_dev);
>>>>
>>>> /* We need to store slaves reta_size to be able to synchronize RETA for all
>>>>
>
next prev parent reply other threads:[~2018-05-31 16:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-31 14:34 Radu Nicolau
2018-05-31 15:34 ` Ferruh Yigit
2018-05-31 15:36 ` Ferruh Yigit
2018-05-31 16:13 ` Radu Nicolau
2018-05-31 16:32 ` Ferruh Yigit [this message]
2018-06-01 10:18 ` Radu Nicolau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b1e1186-4a84-c10d-2056-7b8ed1310106@intel.com \
--to=ferruh.yigit@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=radu.nicolau@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).