From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
Thomas Monjalon <thomas@monjalon.net>
Cc: <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v4 2/3] ethdev: convert static logtype usage to dynamic
Date: Tue, 19 Jun 2018 16:11:49 +0300 [thread overview]
Message-ID: <8b6ead9a-a329-dadc-d523-ab89ff8269ca@solarflare.com> (raw)
In-Reply-To: <20180619010457.61490-2-ferruh.yigit@intel.com>
On 06/19/2018 04:04 AM, Ferruh Yigit wrote:
> Replace RTE_PMD_DEBUG_TRACE with RTE_ETHDEV_LOG.
>
> RTE_PMD_DEBUG_TRACE is using hardcoded PMD logtype and ERR log level,
> controlled by compile time flags.
> RTE_ETHDEV_LOG is using dynamic ethdev_logtype.
>
> Also a few minor cleanups, like
> - use %u for unsigned values like port_id which is uint16_t
> - use PRIx64 for owner_id
> - Join some log lines
> - Unify to not have a "." at the end of the log
> - Unify log start with uppercase
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
The patch is too long due to many minor cleanups in one
changeset, but I think it is still OK to go.
Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>
next prev parent reply other threads:[~2018-06-19 13:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-01 17:28 [dpdk-dev] [PATCH 1/2] ethdev: move log macro to header Ferruh Yigit
2018-05-01 17:28 ` [dpdk-dev] [PATCH 2/2] ethdev: convert static logtype usage to dynamic Ferruh Yigit
2018-05-01 18:56 ` [dpdk-dev] [PATCH 1/2] ethdev: move log macro to header Thomas Monjalon
2018-05-02 9:40 ` Ferruh Yigit
2018-05-02 14:45 ` Stephen Hemminger
2018-05-09 14:24 ` [dpdk-dev] [PATCH v2 " Ferruh Yigit
2018-05-09 14:24 ` [dpdk-dev] [PATCH v2 2/2] ethdev: convert static logtype usage to dynamic Ferruh Yigit
2018-05-14 15:56 ` [dpdk-dev] [PATCH v3 1/2] ethdev: move log macro to header Ferruh Yigit
2018-05-14 15:56 ` [dpdk-dev] [PATCH v3 2/2] ethdev: convert static logtype usage to dynamic Ferruh Yigit
2018-06-19 1:04 ` [dpdk-dev] [PATCH v4 1/3] ethdev: move log macro to header Ferruh Yigit
2018-06-19 1:04 ` [dpdk-dev] [PATCH v4 2/3] ethdev: convert static logtype usage to dynamic Ferruh Yigit
2018-06-19 13:11 ` Andrew Rybchenko [this message]
2018-06-19 1:04 ` [dpdk-dev] [PATCH v4 3/3] eal: don't enable static log macro for ethdev Ferruh Yigit
2018-06-19 13:02 ` [dpdk-dev] [PATCH v4 1/3] ethdev: move log macro to header Andrew Rybchenko
2018-06-26 11:41 ` Shahaf Shuler
2018-06-26 12:25 ` Thomas Monjalon
2018-06-26 15:52 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b6ead9a-a329-dadc-d523-ab89ff8269ca@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).