From: fengchengwen <fengchengwen@huawei.com>
To: Radha Mohan <mohun106@gmail.com>, Kevin Laatz <kevin.laatz@intel.com>
Cc: dpdk-dev <dev@dpdk.org>,
David Marchand <david.marchand@redhat.com>, <mdr@ashroe.eu>,
<conor.walsh@intel.com>, <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/3] dmadev: hide devices array
Date: Tue, 26 Oct 2021 14:20:03 +0800 [thread overview]
Message-ID: <8c667121-1da5-07b2-efef-e556dd4a971e@huawei.com> (raw)
In-Reply-To: <CAC8NTUUXd91UhE0hwCYQM_Z4oa7ZAYWmRVQa6pFCd-xdH6hBPw@mail.gmail.com>
On 2021/10/26 14:04, Radha Mohan wrote:
> On Thu, Oct 21, 2021 at 7:04 AM Kevin Laatz <kevin.laatz@intel.com> wrote:
>>
>> On 21/10/2021 13:59, Chengwen Feng wrote:
>>> From: David Marchand <david.marchand@redhat.com>
>>>
>>> No need to expose rte_dma_devices out of the dmadev library.
>>> Existing helpers should be enough, and inlines make use of
>>> rte_dma_fp_objs.
>
> I asked this earlier and was asked to use rte_dma_devices[] array by Kevin.
> Now that it has been made static is there a different way to get the
> fp_obj->private_data from a PMD .remove function ?
> I need the private data for DMA queue state cleanup.
PMD .remove function just call rte_dma_pmd_release() and it's will
invoke PMD .dev_close ops:
rte_dma_pmd_release()
--> rte_dma_close()
--> PMD .dev_close ops
PMD could implemente cleanup in dev_close ops.
If the PMD want support multi-process, just make sure only the primary
could do really cleanup in the dev_close ops.
>
>>>
>>> Signed-off-by: David Marchand <david.marchand@redhat.com>
>>> Reviewed-by: Chengwen Feng <fengchengwen@huawei.com>
>>> Tested-by: Conor Walsh <conor.walsh@intel.com>
>>> ---
>>> app/test/test_dmadev.c | 5 +++--
>>> lib/dmadev/rte_dmadev.c | 2 +-
>>> lib/dmadev/rte_dmadev_pmd.h | 2 --
>>> lib/dmadev/version.map | 1 -
>>> 4 files changed, 4 insertions(+), 6 deletions(-)
>>>
>>
>> Acked-by: Kevin Laatz <kevin.laatz@intel.com>
>
> .
>
prev parent reply other threads:[~2021-10-26 6:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 6:59 [dpdk-dev] [PATCH 1/2] " David Marchand
2021-10-20 6:59 ` [dpdk-dev] [PATCH 2/2] dmadev: remove symbol versioning for inline helpers David Marchand
2021-10-20 9:40 ` Bruce Richardson
2021-10-20 9:47 ` [dpdk-dev] [PATCH 1/2] dmadev: hide devices array fengchengwen
2021-10-20 9:55 ` David Marchand
2021-10-20 10:01 ` Walsh, Conor
2021-10-21 12:59 ` [dpdk-dev] [PATCH v2 1/3] " Chengwen Feng
2021-10-21 12:59 ` [dpdk-dev] [PATCH v2 2/3] app/test: add check for DMA info get API Chengwen Feng
2021-10-21 13:43 ` David Marchand
2021-10-21 14:03 ` Kevin Laatz
2021-10-21 14:26 ` Walsh, Conor
2021-10-21 12:59 ` [dpdk-dev] [PATCH v2 3/3] dmadev: fix compile error in debug mode Chengwen Feng
2021-10-21 13:42 ` David Marchand
2021-10-21 14:04 ` Kevin Laatz
2021-10-21 14:26 ` Walsh, Conor
2021-10-21 20:20 ` David Marchand
2021-10-21 14:03 ` [dpdk-dev] [PATCH v2 1/3] dmadev: hide devices array Kevin Laatz
2021-10-26 6:04 ` Radha Mohan
2021-10-26 6:20 ` fengchengwen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c667121-1da5-07b2-efef-e556dd4a971e@huawei.com \
--to=fengchengwen@huawei.com \
--cc=bruce.richardson@intel.com \
--cc=conor.walsh@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=kevin.laatz@intel.com \
--cc=mdr@ashroe.eu \
--cc=mohun106@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).