From: Ferruh Yigit <ferruh.yigit@intel.com>
To: nickcooper-zhangtonghao <nic@opencloud.tech>,
dev@dpdk.org, Yong Wang <yongwang@vmware.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/5] eal: Set numa node value for system which not support NUMA.
Date: Thu, 5 Jan 2017 14:23:57 +0000 [thread overview]
Message-ID: <8cb35df0-cdd6-143c-4f78-379a89f44616@intel.com> (raw)
In-Reply-To: <1483617709-7088-1-git-send-email-nic@opencloud.tech>
On 1/5/2017 12:01 PM, nickcooper-zhangtonghao wrote:
> The NUMA node information for PCI devices provided through
> sysfs is invalid for AMD Opteron(TM) Processor 62xx and 63xx
> on Red Hat Enterprise Linux 6, and VMs on some hypervisors.
>
> Signed-off-by: nickcooper-zhangtonghao <nic@opencloud.tech>
Hi nickcooper-zhangtonghao,
The patches in the patchset are individual patches, right? Is there any
dependency between them?
And CC'ed vmxnet3 driver maintainer: Yong Wang <yongwang@vmware.com>
Thanks,
ferruh
> ---
> lib/librte_eal/linuxapp/eal/eal_pci.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c b/lib/librte_eal/linuxapp/eal/eal_pci.c
> index 4350134..5dfdbe9 100644
> --- a/lib/librte_eal/linuxapp/eal/eal_pci.c
> +++ b/lib/librte_eal/linuxapp/eal/eal_pci.c
> @@ -317,7 +317,13 @@
> free(dev);
> return -1;
> }
> - dev->device.numa_node = tmp;
> + /* The NUMA node information for PCI devices provided through
> + * sysfs is invalid for AMD Opteron(TM) Processor 62xx and 63xx
> + * on Red Hat Enterprise Linux 6, and VMs on some hypervisors.
> + * In the upstream linux kernel, the numa_node is an integer,
> + * which data type is int, not unsigned long.
> + */
> + dev->device.numa_node = (int)tmp > 0 ? (int)tmp : 0;
> }
>
> /* parse resources */
>
next prev parent reply other threads:[~2017-01-05 14:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-05 12:01 nickcooper-zhangtonghao
2017-01-05 12:01 ` [dpdk-dev] [PATCH v2 2/5] vmxnet3: Avoid memory leak in vmxnet3_dev_rx_queue_setup nickcooper-zhangtonghao
2017-01-05 12:01 ` [dpdk-dev] [PATCH v2 3/5] vmxnet3: Avoid segfault caused by vmxnet3_dev_rx_queue_setup nickcooper-zhangtonghao
2017-01-05 12:01 ` [dpdk-dev] [PATCH v2 4/5] vmxnet3: Avoid memory leak in vmxnet3_dev_tx_queue_setup nickcooper-zhangtonghao
2017-01-05 12:01 ` [dpdk-dev] [PATCH v2 5/5] vmxnet3: Avoid segfault caused by vmxnet3_dev_tx_queue_setup nickcooper-zhangtonghao
2017-01-05 14:23 ` Ferruh Yigit [this message]
2017-01-06 0:01 ` [dpdk-dev] [PATCH v2 1/5] eal: Set numa node value for system which not support NUMA Yong Wang
2017-01-09 2:06 ` nickcooper-zhangtonghao
2017-01-09 2:20 ` nickcooper-zhangtonghao
2017-01-05 16:17 ` Stephen Hemminger
2017-01-05 16:26 ` Stephen Hemminger
2017-01-09 2:14 ` nickcooper-zhangtonghao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cb35df0-cdd6-143c-4f78-379a89f44616@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=nic@opencloud.tech \
--cc=yongwang@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).