From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Xing, Beilei" <beilei.xing@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Zhang, Helin" <helin.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Zhao1, Wei" <wei.zhao1@intel.com>
Subject: Re: [dpdk-dev] [PATCH v5 07/17] net/i40e: add flow validate function
Date: Thu, 5 Jan 2017 11:16:24 +0000 [thread overview]
Message-ID: <8d74dd50-2eba-37b6-996d-3d97dd043f2d@intel.com> (raw)
In-Reply-To: <94479800C636CB44BD422CB454846E013158E038@SHSMSX101.ccr.corp.intel.com>
On 1/5/2017 6:08 AM, Xing, Beilei wrote:
> Hi Ferruh,
>
>> -----Original Message-----
>> From: Yigit, Ferruh
>> Sent: Thursday, January 5, 2017 2:57 AM
>> To: Xing, Beilei <beilei.xing@intel.com>; Wu, Jingjing
>> <jingjing.wu@intel.com>; Zhang, Helin <helin.zhang@intel.com>
>> Cc: dev@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH v5 07/17] net/i40e: add flow validate
>> function
>>
>> On 1/4/2017 3:22 AM, Beilei Xing wrote:
>>> This patch adds i40e_flow_validation function to check if a flow is
>>> valid according to the flow pattern.
>>> i40e_parse_ethertype_filter is added first, it also gets the ethertype
>>> info.
>>> i40e_flow.c is added to handle all generic filter events.
>>>
>>> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
>>> ---
>>
>> <...>
>>
>>> diff --git a/drivers/net/i40e/i40e_ethdev.c
>>> b/drivers/net/i40e/i40e_ethdev.c index 153322a..edfd52b 100644
>>> --- a/drivers/net/i40e/i40e_ethdev.c
>>> +++ b/drivers/net/i40e/i40e_ethdev.c
>>> @@ -8426,6 +8426,8 @@ i40e_ethertype_filter_handle(struct rte_eth_dev
>> *dev,
>>> return ret;
>>> }
>>>
>>> +const struct rte_flow_ops i40e_flow_ops;
>>
>> Is this intentional (instead of using extern) ?
>> Because i40e_flow.c has a global variable definition with same name, it looks
>> like this is not causing a build error, but I think confusing.
>>
>
> Actually it's the global variable definition in i40e_flow.c. I thought gcc would add extern automatically during compiling, as I checked the address of the variable is the same in different files.
> To avoid confusion, I will add extern in next version.
>
>> <...>
>>
>>> +static int i40e_parse_ethertype_act(struct rte_eth_dev *dev,
>>> + const struct rte_flow_action *actions,
>>> + struct rte_flow_error *error,
>>> + struct rte_eth_ethertype_filter *filter);
>>
>> In API naming, I would prefer full "action" instead of shorten "act", but it is
>> your call.
>
> I will change the API name in next version. Thanks.
>
>>
>> <...>
>>
>>> +
>>> +union i40e_filter_t cons_filter;
>>
>> Why this cons_filter is required. I can see this is saving some state related
>> rule during validate function.
>> If the plan is to use this during rule creation, is user has to call validate before
>> each create?
>
> You are right, cons_filter will get filter info during validation, and it's for flow_create function.
> User needn't to call the flow_validate function, as validate function will be called in i40e_flow_create.
Ok then.
>
>>
>> <...>
>>
>>> +
>>> +static int
>>> +i40e_parse_ethertype_filter(struct rte_eth_dev *dev,
>>> + const struct rte_flow_attr *attr,
>>> + const struct rte_flow_item pattern[],
>>> + const struct rte_flow_action actions[],
>>> + struct rte_flow_error *error,
>>> + union i40e_filter_t *filter)
>>> +{
>>> + struct rte_eth_ethertype_filter *ethertype_filter =
>>> + &filter->ethertype_filter;
>>> + int ret;
>>> +
>>> + ret = i40e_parse_ethertype_pattern(dev, pattern, error,
>>> + ethertype_filter);
>>> + if (ret)
>>> + return ret;
>>> +
>>> + ret = i40e_parse_ethertype_act(dev, actions, error,
>>> + ethertype_filter);
>>> + if (ret)
>>> + return ret;
>>> +
>>> + ret = i40e_parse_attr(attr, error);
>>
>> It is your call, but I would suggest using a specific namespace for all rte_flow
>> related functions, something like "i40e_flow_".
>> In this context it is clear what this function is, but in whole driver code, the
>> function name is too generic to understand what it does.
>
> Make sense. I'll update the function names.
>
>>
>>> + if (ret)
>>> + return ret;
>>> +
>>> + return ret;
>>> +}
>>> +
>>
>> <...>
>>
>>> +
>>> +static int
>>> +i40e_parse_ethertype_pattern(__rte_unused struct rte_eth_dev *dev,
>>> + const struct rte_flow_item *pattern,
>>> + struct rte_flow_error *error,
>>> + struct rte_eth_ethertype_filter *filter)
>>
>> I think it is good idea to comment what pattern is recognized in to function
>> comment, instead of reading code every time to figure out.
>
> In fact, the array of i40e_supported_patterns has listed all supported patterns for each filter type.
> i40e_supported_patterns is also defined in this patch.
i40e_supported_patterns only shows item->type values, I think it is good
to documents expected/valid mask (.dst, .src, .type) and last values for
this type.
>
>>
>>> +{
>>> + const struct rte_flow_item *item = pattern;
>>> + const struct rte_flow_item_eth *eth_spec;
>>> + const struct rte_flow_item_eth *eth_mask;
>>> + enum rte_flow_item_type item_type;
>>> +
>>> + for (; item->type != RTE_FLOW_ITEM_TYPE_END; item++) {
>>> + if (item->last) {
>>> + rte_flow_error_set(error, EINVAL,
>>> + RTE_FLOW_ERROR_TYPE_ITEM,
>>> + item,
>>> + "Not support range");
>>> + return -rte_errno;
>>> + }
>>> + item_type = item->type;
>>> + switch (item_type) {
>>> + case RTE_FLOW_ITEM_TYPE_ETH:
>>> + eth_spec = (const struct rte_flow_item_eth *)item-
>>> spec;
>>> + eth_mask = (const struct rte_flow_item_eth *)item-
>>> mask;
>>> + /* Get the MAC info. */
>>> + if (!eth_spec || !eth_mask) {
>>
>> Why an eth_mask is required?
> Yes, since eth_type mask in eth_mask should be UINT16_MAX.
>
>> Can't driver support drop/queue packets from specific src to specific dst with
>> specific eth_type?
> No, we support specific dst with specific eth_type, or only specific eth_type. Perfect match.
Thanks for clarification.
>
>>
>>> + rte_flow_error_set(error, EINVAL,
>>> +
>> RTE_FLOW_ERROR_TYPE_ITEM,
>>> + item,
>>> + "NULL ETH spec/mask");
>>> + return -rte_errno;
>>> + }
>>> +
>>> + /* Mask bits of source MAC address must be full of 0.
>>> + * Mask bits of destination MAC address must be full
>>> + * of 1 or full of 0.
>>> + */
>>> + if (!is_zero_ether_addr(ð_mask->src) ||
>>> + (!is_zero_ether_addr(ð_mask->dst) &&
>>> + !is_broadcast_ether_addr(ð_mask->dst))) {
>>> + rte_flow_error_set(error, EINVAL,
>>> +
>> RTE_FLOW_ERROR_TYPE_ITEM,
>>> + item,
>>> + "Invalid MAC_addr mask");
>>> + return -rte_errno;
>>> + }
>>> +
>>> + if ((eth_mask->type & UINT16_MAX) !=
>> UINT16_MAX) {
>>> + rte_flow_error_set(error, EINVAL,
>>> +
>> RTE_FLOW_ERROR_TYPE_ITEM,
>>> + item,
>>> + "Invalid ethertype mask");
>>
>> Why returning error here?
>> Can't we say drop packets to specific MAC address, independent from the
>> ether_type?
>
> No. as I said above, we support specific dst with specific eth_type, or only specific eth_type for ethertype_filter.
>
>>
>>> + return -rte_errno;
>>> + }
>>> +
>>> + /* If mask bits of destination MAC address
>>> + * are full of 1, set RTE_ETHTYPE_FLAGS_MAC.
>>> + */
>>> + if (is_broadcast_ether_addr(ð_mask->dst)) {
>>> + filter->mac_addr = eth_spec->dst;
>>> + filter->flags |= RTE_ETHTYPE_FLAGS_MAC;
>>> + } else {
>>> + filter->flags &= ~RTE_ETHTYPE_FLAGS_MAC;
>>> + }
>>> + filter->ether_type = rte_be_to_cpu_16(eth_spec-
>>> type);
>>> +
>>> + if (filter->ether_type == ETHER_TYPE_IPv4 ||
>>> + filter->ether_type == ETHER_TYPE_IPv6) {
>>> + rte_flow_error_set(error, EINVAL,
>>> +
>> RTE_FLOW_ERROR_TYPE_ITEM,
>>> + item,
>>> + "Unsupported ether_type
>> in"
>>> + " control packet filter.");
>>
>> Can't we create a drop rule based on dst MAC address if eth_type is ip ?
>
> No, we don't support drop MAC_addr + eth_type_IP for ethertype filter.
>
>>
>>> + return -rte_errno;
>>> + }
>>> + if (filter->ether_type == ETHER_TYPE_VLAN)
>>> + PMD_DRV_LOG(WARNING, "filter vlan
>> ether_type in"
>>> + " first tag is not supported.");
>>
>> Who is the target of this message?
>> To the caller, this API is responding as this is supported.
>> The end user, the user of the application, can see this message, how this
>> message will help to end user?
>
> Actually I add this warning according to the original processing in i40e_dev_eythertype_filter_set.
> After checing datasheet, "The ethertype programmed by this command should not be one of the L2 tags ethertype (VLAN, E-tag, S-tag, etc.) and should not be IP or IPv6" is descripted.
> But if QinQ is disabled, and inner vlan is ETHER_TYPE_VLAN, the filter works. So the message is "vlan ether_type in outer tag is not supported".
> I want to simplify it in next version, don't support the situation above, and return error if (filter->ether_type == ETHER_TYPE_VLAN), because HW only recognizes ETH when QinQ is diabled. What do you think?
I think it is better.
And this can be fine tuned in the future to check QinQ and return
accordingly.
>
>>
>>> +
>>> + break;
>>> + default:
>>> + break;
>>> + }
>>> + }
>>> +
>>> + return 0;
>>> +}
>>> +
>>> +static int
>>> +i40e_parse_ethertype_act(struct rte_eth_dev *dev,
>>> + const struct rte_flow_action *actions,
>>> + struct rte_flow_error *error,
>>> + struct rte_eth_ethertype_filter *filter)
>>
>> I think it would be good to comment this functions to say only DROP and
>> QUEUE actions are supported.
>
> Yes, will update in next version.
>
>>
>> <...>
>>
>>> +
>>> +static int
>>> +i40e_flow_validate(struct rte_eth_dev *dev,
>>> + const struct rte_flow_attr *attr,
>>> + const struct rte_flow_item pattern[],
>>> + const struct rte_flow_action actions[],
>>> + struct rte_flow_error *error)
>>> +{
>>> + struct rte_flow_item *items; /* internal pattern w/o VOID items */
>>> + parse_filter_t parse_filter;
>>> + uint32_t item_num = 0; /* non-void item number of pattern*/
>>> + uint32_t i = 0;
>>> + int ret;
>>> +
>>> + if (!pattern) {
>>> + rte_flow_error_set(error, EINVAL,
>> RTE_FLOW_ERROR_TYPE_ITEM_NUM,
>>> + NULL, "NULL pattern.");
>>> + return -rte_errno;
>>> + }
>>> +
>>> + if (!actions) {
>>> + rte_flow_error_set(error, EINVAL,
>>> + RTE_FLOW_ERROR_TYPE_ACTION_NUM,
>>> + NULL, "NULL action.");
>>> + return -rte_errno;
>>> + }
>>
>> It may be good to validate attr too, if it is NULL or not. It is accessed without
>> check in later stages of the call stack.
>
> Yes. Thanks for reminder.
>
> Best Regards,
> Beilei
>
>>
>> <...>
>>
>
next prev parent reply other threads:[~2017-01-05 11:16 UTC|newest]
Thread overview: 175+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 11:53 [dpdk-dev] [PATCH 00/24] net/i40e: Consistent filter API Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 01/24] net/i40e: store ethertype filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 02/24] net/i40e: store tunnel filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 03/24] net/i40e: store flow director filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 04/24] net/i40e: store RSS hash info Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 05/24] net/i40e: restore ethertype filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 06/24] net/i40e: restore macvlan filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 07/24] net/i40e: restore tunnel filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 08/24] net/i40e: restore flow director filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 09/24] net/i40e: restore RSS hash info Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 10/24] ethdev: parse ethertype filter Beilei Xing
2016-12-20 18:12 ` Ferruh Yigit
2016-12-21 3:54 ` Xing, Beilei
2016-12-23 8:43 ` Adrien Mazarguil
2016-12-27 6:36 ` Xing, Beilei
2016-12-02 11:53 ` [dpdk-dev] [PATCH 11/24] net/i40e: add flow validate function Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 12/24] net/i40e: parse macvlan filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 13/24] net/i40e: parse VXLAN filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 14/24] net/i40e: parse NVGRE filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 15/24] net/i40e: parse flow director filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 16/24] net/i40e: add flow create function Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 17/24] net/i40e: destroy ethertype filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 18/24] net/i40e: destroy macvlan filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 19/24] net/i40e: destroy tunnel filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 20/24] net/i40e: destroy flow directory filter Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 21/24] net/i40e: add flow flush function Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 22/24] net/i40e: flush ethertype filters Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 23/24] net/i40e: flush macvlan filters Beilei Xing
2016-12-02 11:53 ` [dpdk-dev] [PATCH 24/24] net/i40e: flush tunnel filters Beilei Xing
2016-12-27 6:26 ` [dpdk-dev] [PATCH v2 00/17] net/i40e: Consistent filter API Beilei Xing
2016-12-27 6:26 ` [dpdk-dev] [PATCH v2 01/17] net/i40e: store ethertype filter Beilei Xing
2016-12-28 2:22 ` Wu, Jingjing
2016-12-29 4:03 ` Xing, Beilei
2016-12-29 4:36 ` Xing, Beilei
2016-12-28 3:22 ` Tiwei Bie
2016-12-27 6:26 ` [dpdk-dev] [PATCH v2 02/17] net/i40e: store tunnel filter Beilei Xing
2016-12-28 3:27 ` Tiwei Bie
2016-12-27 6:26 ` [dpdk-dev] [PATCH v2 03/17] net/i40e: store flow director filter Beilei Xing
2016-12-28 3:38 ` Tiwei Bie
2016-12-28 7:10 ` Xing, Beilei
2016-12-28 7:14 ` Tiwei Bie
2016-12-28 7:36 ` Tiwei Bie
2016-12-27 6:26 ` [dpdk-dev] [PATCH v2 04/17] net/i40e: restore ethertype filter Beilei Xing
2016-12-28 2:25 ` Wu, Jingjing
2016-12-27 6:26 ` [dpdk-dev] [PATCH v2 05/17] net/i40e: restore tunnel filter Beilei Xing
2016-12-27 6:26 ` [dpdk-dev] [PATCH v2 06/17] net/i40e: restore flow director filter Beilei Xing
2016-12-27 6:26 ` [dpdk-dev] [PATCH v2 07/17] net/i40e: add flow validate function Beilei Xing
2016-12-27 12:40 ` Adrien Mazarguil
2016-12-28 9:00 ` Xing, Beilei
2016-12-28 9:29 ` Adrien Mazarguil
2016-12-28 10:03 ` Xing, Beilei
2016-12-28 2:52 ` Wu, Jingjing
2016-12-28 7:44 ` Xing, Beilei
2016-12-28 4:08 ` Tiwei Bie
2016-12-27 6:26 ` [dpdk-dev] [PATCH v2 08/17] net/i40e: parse flow director filter Beilei Xing
2016-12-27 6:26 ` [dpdk-dev] [PATCH v2 09/17] net/i40e: parse tunnel filter Beilei Xing
2016-12-27 6:26 ` [dpdk-dev] [PATCH v2 10/17] net/i40e: add flow create function Beilei Xing
2016-12-27 6:26 ` [dpdk-dev] [PATCH v2 11/17] net/i40e: add flow destroy function Beilei Xing
2016-12-27 6:26 ` [dpdk-dev] [PATCH v2 12/17] net/i40e: destroy ethertype filter Beilei Xing
2016-12-28 3:30 ` Wu, Jingjing
2016-12-28 7:29 ` Xing, Beilei
2016-12-28 4:56 ` Tiwei Bie
2016-12-28 6:57 ` Xing, Beilei
2016-12-27 6:26 ` [dpdk-dev] [PATCH v2 13/17] net/i40e: destroy tunnel filter Beilei Xing
2016-12-27 6:26 ` [dpdk-dev] [PATCH v2 14/17] net/i40e: destroy flow directory filter Beilei Xing
2016-12-27 6:26 ` [dpdk-dev] [PATCH v2 15/17] net/i40e: add flow flush function Beilei Xing
2016-12-27 12:40 ` Adrien Mazarguil
2016-12-28 8:02 ` Xing, Beilei
2016-12-28 5:35 ` Tiwei Bie
2016-12-28 6:48 ` Xing, Beilei
2016-12-28 7:00 ` Tiwei Bie
2016-12-28 7:20 ` Xing, Beilei
2016-12-27 6:26 ` [dpdk-dev] [PATCH v2 16/17] net/i40e: flush ethertype filters Beilei Xing
2016-12-27 6:26 ` [dpdk-dev] [PATCH v2 17/17] net/i40e: flush tunnel filters Beilei Xing
2016-12-29 16:04 ` [dpdk-dev] [PATCH v3 00/17] net/i40e: consistent filter API Beilei Xing
2016-12-29 16:04 ` [dpdk-dev] [PATCH v3 01/17] net/i40e: store ethertype filter Beilei Xing
2016-12-29 16:04 ` [dpdk-dev] [PATCH v3 02/17] net/i40e: store tunnel filter Beilei Xing
2016-12-29 16:04 ` [dpdk-dev] [PATCH v3 03/17] net/i40e: store flow director filter Beilei Xing
2016-12-29 16:04 ` [dpdk-dev] [PATCH v3 04/17] net/i40e: restore ethertype filter Beilei Xing
2016-12-29 16:04 ` [dpdk-dev] [PATCH v3 05/17] net/i40e: restore tunnel filter Beilei Xing
2016-12-29 16:04 ` [dpdk-dev] [PATCH v3 06/17] net/i40e: restore flow director filter Beilei Xing
2016-12-29 16:04 ` [dpdk-dev] [PATCH v3 07/17] net/i40e: add flow validate function Beilei Xing
2016-12-29 16:04 ` [dpdk-dev] [PATCH v3 08/17] net/i40e: parse flow director filter Beilei Xing
2016-12-29 16:04 ` [dpdk-dev] [PATCH v3 09/17] net/i40e: parse tunnel filter Beilei Xing
2016-12-29 16:04 ` [dpdk-dev] [PATCH v3 10/17] net/i40e: add flow create function Beilei Xing
2016-12-29 16:04 ` [dpdk-dev] [PATCH v3 11/17] net/i40e: add flow destroy function Beilei Xing
2016-12-29 16:04 ` [dpdk-dev] [PATCH v3 12/17] net/i40e: destroy ethertype filter Beilei Xing
2016-12-29 16:04 ` [dpdk-dev] [PATCH v3 13/17] net/i40e: destroy tunnel filter Beilei Xing
2016-12-29 16:04 ` [dpdk-dev] [PATCH v3 14/17] net/i40e: destroy flow directory filter Beilei Xing
2016-12-29 16:04 ` [dpdk-dev] [PATCH v3 15/17] net/i40e: add flow flush function Beilei Xing
2016-12-29 16:04 ` [dpdk-dev] [PATCH v3 16/17] net/i40e: flush ethertype filters Beilei Xing
2016-12-29 16:04 ` [dpdk-dev] [PATCH v3 17/17] net/i40e: flush tunnel filters Beilei Xing
2016-12-30 3:25 ` [dpdk-dev] [PATCH v4 00/17] net/i40e: consistent filter API Beilei Xing
2016-12-30 3:25 ` [dpdk-dev] [PATCH v4 01/17] net/i40e: store ethertype filter Beilei Xing
2016-12-30 3:25 ` [dpdk-dev] [PATCH v4 02/17] net/i40e: store tunnel filter Beilei Xing
2016-12-30 3:25 ` [dpdk-dev] [PATCH v4 03/17] net/i40e: store flow director filter Beilei Xing
2016-12-30 3:25 ` [dpdk-dev] [PATCH v4 04/17] net/i40e: restore ethertype filter Beilei Xing
2016-12-30 3:25 ` [dpdk-dev] [PATCH v4 05/17] net/i40e: restore tunnel filter Beilei Xing
2016-12-30 3:25 ` [dpdk-dev] [PATCH v4 06/17] net/i40e: restore flow director filter Beilei Xing
2016-12-30 3:25 ` [dpdk-dev] [PATCH v4 07/17] net/i40e: add flow validate function Beilei Xing
2016-12-30 3:25 ` [dpdk-dev] [PATCH v4 08/17] net/i40e: parse flow director filter Beilei Xing
2016-12-30 3:25 ` [dpdk-dev] [PATCH v4 09/17] net/i40e: parse tunnel filter Beilei Xing
2016-12-30 3:25 ` [dpdk-dev] [PATCH v4 10/17] net/i40e: add flow create function Beilei Xing
2016-12-30 3:25 ` [dpdk-dev] [PATCH v4 11/17] net/i40e: add flow destroy function Beilei Xing
2016-12-30 3:25 ` [dpdk-dev] [PATCH v4 12/17] net/i40e: destroy ethertype filter Beilei Xing
2016-12-30 3:25 ` [dpdk-dev] [PATCH v4 13/17] net/i40e: destroy tunnel filter Beilei Xing
2016-12-30 3:25 ` [dpdk-dev] [PATCH v4 14/17] net/i40e: destroy flow directory filter Beilei Xing
2016-12-30 3:25 ` [dpdk-dev] [PATCH v4 15/17] net/i40e: add flow flush function Beilei Xing
2016-12-30 3:25 ` [dpdk-dev] [PATCH v4 16/17] net/i40e: flush ethertype filters Beilei Xing
2016-12-30 3:25 ` [dpdk-dev] [PATCH v4 17/17] net/i40e: flush tunnel filters Beilei Xing
2017-01-03 3:25 ` Guo, Jia
2017-01-03 4:49 ` Xing, Beilei
2017-01-04 3:22 ` [dpdk-dev] [PATCH v5 00/17] net/i40e: consistent filter API Beilei Xing
2017-01-04 3:22 ` [dpdk-dev] [PATCH v5 01/17] net/i40e: store ethertype filter Beilei Xing
2017-01-04 3:22 ` [dpdk-dev] [PATCH v5 02/17] net/i40e: store tunnel filter Beilei Xing
2017-01-04 3:22 ` [dpdk-dev] [PATCH v5 03/17] net/i40e: store flow director filter Beilei Xing
2017-01-04 3:22 ` [dpdk-dev] [PATCH v5 04/17] net/i40e: restore ethertype filter Beilei Xing
2017-01-04 3:22 ` [dpdk-dev] [PATCH v5 05/17] net/i40e: restore tunnel filter Beilei Xing
2017-01-04 3:22 ` [dpdk-dev] [PATCH v5 06/17] net/i40e: restore flow director filter Beilei Xing
2017-01-04 3:22 ` [dpdk-dev] [PATCH v5 07/17] net/i40e: add flow validate function Beilei Xing
2017-01-04 18:57 ` Ferruh Yigit
2017-01-05 6:08 ` Xing, Beilei
2017-01-05 11:16 ` Ferruh Yigit [this message]
2017-01-05 11:52 ` Xing, Beilei
2017-01-04 3:22 ` [dpdk-dev] [PATCH v5 08/17] net/i40e: parse flow director filter Beilei Xing
2017-01-04 3:22 ` [dpdk-dev] [PATCH v5 09/17] net/i40e: parse tunnel filter Beilei Xing
2017-01-04 3:23 ` [dpdk-dev] [PATCH v5 10/17] net/i40e: add flow create function Beilei Xing
2017-01-04 3:23 ` [dpdk-dev] [PATCH v5 11/17] net/i40e: add flow destroy function Beilei Xing
2017-01-04 3:23 ` [dpdk-dev] [PATCH v5 12/17] net/i40e: destroy ethertype filter Beilei Xing
2017-01-04 3:23 ` [dpdk-dev] [PATCH v5 13/17] net/i40e: destroy tunnel filter Beilei Xing
2017-01-04 3:23 ` [dpdk-dev] [PATCH v5 14/17] net/i40e: destroy flow directory filter Beilei Xing
2017-01-04 3:23 ` [dpdk-dev] [PATCH v5 15/17] net/i40e: add flow flush function Beilei Xing
2017-01-04 3:23 ` [dpdk-dev] [PATCH v5 16/17] net/i40e: flush ethertype filters Beilei Xing
2017-01-04 3:23 ` [dpdk-dev] [PATCH v5 17/17] net/i40e: flush tunnel filters Beilei Xing
2017-01-04 6:40 ` [dpdk-dev] [PATCH v5 00/17] net/i40e: consistent filter API Wu, Jingjing
2017-01-05 15:45 ` [dpdk-dev] [PATCH v6 " Beilei Xing
2017-01-05 15:45 ` [dpdk-dev] [PATCH v6 01/17] net/i40e: store ethertype filter Beilei Xing
2017-01-05 17:46 ` Ferruh Yigit
2017-01-05 15:45 ` [dpdk-dev] [PATCH v6 02/17] net/i40e: store tunnel filter Beilei Xing
2017-01-05 15:45 ` [dpdk-dev] [PATCH v6 03/17] net/i40e: store flow director filter Beilei Xing
2017-01-05 15:45 ` [dpdk-dev] [PATCH v6 04/17] net/i40e: restore ethertype filter Beilei Xing
2017-01-05 15:45 ` [dpdk-dev] [PATCH v6 05/17] net/i40e: restore tunnel filter Beilei Xing
2017-01-05 15:45 ` [dpdk-dev] [PATCH v6 06/17] net/i40e: restore flow director filter Beilei Xing
2017-01-05 15:46 ` [dpdk-dev] [PATCH v6 07/17] net/i40e: add flow validate function Beilei Xing
2017-01-05 15:46 ` [dpdk-dev] [PATCH v6 08/17] net/i40e: parse flow director filter Beilei Xing
2017-01-05 15:46 ` [dpdk-dev] [PATCH v6 09/17] net/i40e: parse tunnel filter Beilei Xing
2017-01-05 15:46 ` [dpdk-dev] [PATCH v6 10/17] net/i40e: add flow create function Beilei Xing
2017-01-05 17:47 ` Ferruh Yigit
2017-01-05 15:46 ` [dpdk-dev] [PATCH v6 11/17] net/i40e: add flow destroy function Beilei Xing
2017-01-05 15:46 ` [dpdk-dev] [PATCH v6 12/17] net/i40e: destroy ethertype filter Beilei Xing
2017-01-05 15:46 ` [dpdk-dev] [PATCH v6 13/17] net/i40e: destroy tunnel filter Beilei Xing
2017-01-05 15:46 ` [dpdk-dev] [PATCH v6 14/17] net/i40e: destroy flow directory filter Beilei Xing
2017-01-05 15:46 ` [dpdk-dev] [PATCH v6 15/17] net/i40e: add flow flush function Beilei Xing
2017-01-05 15:46 ` [dpdk-dev] [PATCH v6 16/17] net/i40e: flush ethertype filters Beilei Xing
2017-01-05 15:46 ` [dpdk-dev] [PATCH v6 17/17] net/i40e: flush tunnel filters Beilei Xing
2017-01-05 17:46 ` [dpdk-dev] [PATCH v6 00/17] net/i40e: consistent filter API Ferruh Yigit
2017-01-06 5:27 ` [dpdk-dev] [PATCH v7 " Beilei Xing
2017-01-06 5:27 ` [dpdk-dev] [PATCH v7 01/17] net/i40e: store ethertype filter Beilei Xing
2017-01-06 5:27 ` [dpdk-dev] [PATCH v7 02/17] net/i40e: store tunnel filter Beilei Xing
2017-01-06 5:27 ` [dpdk-dev] [PATCH v7 03/17] net/i40e: store flow director filter Beilei Xing
2017-01-06 5:27 ` [dpdk-dev] [PATCH v7 04/17] net/i40e: restore ethertype filter Beilei Xing
2017-01-06 5:27 ` [dpdk-dev] [PATCH v7 05/17] net/i40e: restore tunnel filter Beilei Xing
2017-01-06 5:27 ` [dpdk-dev] [PATCH v7 06/17] net/i40e: restore flow director filter Beilei Xing
2017-01-06 5:27 ` [dpdk-dev] [PATCH v7 07/17] net/i40e: add flow validate function Beilei Xing
2017-01-06 5:27 ` [dpdk-dev] [PATCH v7 08/17] net/i40e: parse flow director filter Beilei Xing
2017-01-06 5:27 ` [dpdk-dev] [PATCH v7 09/17] net/i40e: parse tunnel filter Beilei Xing
2017-01-06 5:27 ` [dpdk-dev] [PATCH v7 10/17] net/i40e: add flow create function Beilei Xing
2017-01-06 5:27 ` [dpdk-dev] [PATCH v7 11/17] net/i40e: add flow destroy function Beilei Xing
2017-01-06 5:27 ` [dpdk-dev] [PATCH v7 12/17] net/i40e: destroy ethertype filter Beilei Xing
2017-01-06 5:27 ` [dpdk-dev] [PATCH v7 13/17] net/i40e: destroy tunnel filter Beilei Xing
2017-01-06 5:27 ` [dpdk-dev] [PATCH v7 14/17] net/i40e: destroy flow directory filter Beilei Xing
2017-01-06 5:27 ` [dpdk-dev] [PATCH v7 15/17] net/i40e: add flow flush function Beilei Xing
2017-01-06 5:27 ` [dpdk-dev] [PATCH v7 16/17] net/i40e: flush ethertype filters Beilei Xing
2017-01-06 5:27 ` [dpdk-dev] [PATCH v7 17/17] net/i40e: flush tunnel filters Beilei Xing
2017-01-06 11:54 ` [dpdk-dev] [PATCH v7 00/17] net/i40e: consistent filter API Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d74dd50-2eba-37b6-996d-3d97dd043f2d@intel.com \
--to=ferruh.yigit@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=jingjing.wu@intel.com \
--cc=wei.zhao1@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).