From: santosh <santosh.shukla@caviumnetworks.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>,
Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Cc: thomas@monjalon.net, anatoly.burakov@intel.com,
lironh@marvell.com, bruce.richardson@intel.com,
fiona.trahe@intel.com, shreyansh.jain@nxp.com,
hemant.agrawal@nxp.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4 2/2] octeontx: move mbox to common folder
Date: Wed, 4 Apr 2018 10:36:09 +0530 [thread overview]
Message-ID: <8daff581-a03f-0659-2bbb-ef999caaca46@caviumnetworks.com> (raw)
In-Reply-To: <20180404032919.GB8574@jerin>
On Wednesday 04 April 2018 08:59 AM, Jerin Jacob wrote:
> -----Original Message-----
>> Date: Mon, 2 Apr 2018 14:40:00 +0530
>> From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
>> To: jerin.jacob@caviumnetworks.com, santosh.shukla@caviumnetworks.com,
>> thomas@monjalon.net, anatoly.burakov@intel.com, lironh@marvell.com,
>> bruce.richardson@intel.com, fiona.trahe@intel.com, shreyansh.jain@nxp.com,
>> hemant.agrawal@nxp.com
>> Cc: dev@dpdk.org, Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
>> Subject: [dpdk-dev] [PATCH v4 2/2] octeontx: move mbox to common folder
>> X-Mailer: git-send-email 2.16.3
>>
>> Move commonly used functions across mempool, event and net devices to a
>> common folder in drivers.
>>
>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
>> ---
snip
>> vfid == 0 ?
>>
>> + ram_mbox_base = octeontx_ssovf_bar(OCTEONTX_SSO_HWS, 0, 4);
also ram_mbox_base may throw build warning in case vfid>0..right?
>> + if (octeontx_mbox_set_ram_mbox_base(ram_mbox_base)) {
>> + mbox_log_err("Invalid Failed to set ram mbox base");
>> + return -EINVAL;
>> + }
>> + }
>> +
>> rte_wmb();
>> mbox_log_dbg("Domain=%d hws=%d total_ssowvfs=%d", res->domain,
>> res->vfid, sdev.total_ssowvfs);
>> @@ -213,6 +221,7 @@ ssovf_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)
>> uint16_t vfid;
>> uint8_t *idreg;
>> struct ssovf_res *res;
>> + uint8_t *reg;
>>
>> RTE_SET_USED(pci_drv);
>>
>> @@ -246,6 +255,15 @@ ssovf_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)
>> res->domain = val & 0xffff;
>>
>> sdev.total_ssovfs++;
>> + if (!vfid) {
> vfid == 0 ?
>
>> + reg = octeontx_ssovf_bar(OCTEONTX_SSO_GROUP, 0, 0);
ditto for reg.
>> + reg += SSO_VHGRP_PF_MBOX(1);
>> + if (octeontx_mbox_set_reg(reg)) {
>> + mbox_log_err("Invalid Failed to set mbox_reg");
>> + return -EINVAL;
>> + }
>> + }
>> +
>> rte_wmb();
>> mbox_log_dbg("Domain=%d group=%d total_ssovfs=%d", res->domain,
>> res->vfid, sdev.total_ssovfs);
> With above changes:
>
> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
>
Acked-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
Thanks.
next prev parent reply other threads:[~2018-04-04 5:06 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-19 9:27 [dpdk-dev] [PATCH 1/2] drivers: add " Pavan Nikhilesh
2018-03-19 9:27 ` [dpdk-dev] [PATCH 2/2] octeontx: move mbox to " Pavan Nikhilesh
2018-03-19 10:35 ` [dpdk-dev] [PATCH 1/2] drivers: add " Shreyansh Jain
2018-03-20 14:38 ` Pavan Nikhilesh
2018-03-20 14:40 ` [dpdk-dev] [PATCH v2 " Pavan Nikhilesh
2018-03-20 14:40 ` [dpdk-dev] [PATCH v2 2/2] octeontx: move mbox to " Pavan Nikhilesh
2018-03-20 15:01 ` Hemant Agrawal
2018-03-20 16:00 ` Pavan Nikhilesh
2018-03-20 15:45 ` [dpdk-dev] [PATCH v2 1/2] drivers: add " Thomas Monjalon
2018-03-20 16:06 ` Pavan Nikhilesh
2018-03-20 17:01 ` Bruce Richardson
2018-03-20 17:27 ` Thomas Monjalon
2018-03-20 19:25 ` Trahe, Fiona
2018-03-26 7:53 ` [dpdk-dev] [PATCH v3 " Pavan Nikhilesh
2018-03-26 7:53 ` [dpdk-dev] [PATCH v3 2/2] octeontx: move mbox to " Pavan Nikhilesh
2018-03-27 16:15 ` Thomas Monjalon
2018-03-30 17:23 ` Pavan Nikhilesh
2018-03-27 16:11 ` [dpdk-dev] [PATCH v3 1/2] drivers: add " Thomas Monjalon
2018-04-02 9:09 ` [dpdk-dev] [PATCH v4 " Pavan Nikhilesh
2018-04-02 9:10 ` [dpdk-dev] [PATCH v4 2/2] octeontx: move mbox to " Pavan Nikhilesh
2018-04-04 3:29 ` Jerin Jacob
2018-04-04 5:06 ` santosh [this message]
2018-04-04 9:23 ` Thomas Monjalon
2018-04-03 6:57 ` [dpdk-dev] [PATCH v4 1/2] drivers: add " Hemant Agrawal
2018-04-04 3:08 ` Jerin Jacob
2018-04-04 5:01 ` santosh
2018-04-04 14:30 ` [dpdk-dev] [PATCH v5 " Pavan Nikhilesh
2018-04-04 14:30 ` [dpdk-dev] [PATCH v5 2/2] octeontx: move mbox to " Pavan Nikhilesh
2018-04-04 14:37 ` Thomas Monjalon
2018-04-04 21:20 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8daff581-a03f-0659-2bbb-ef999caaca46@caviumnetworks.com \
--to=santosh.shukla@caviumnetworks.com \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=lironh@marvell.com \
--cc=pbhagavatula@caviumnetworks.com \
--cc=shreyansh.jain@nxp.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).