From: Declan Doherty <declan.doherty@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "Azarewicz, PiotrX T" <piotrx.t.azarewicz@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v1 1/1] examples/l2fwd-crypto: improve random key generator
Date: Wed, 13 Jul 2016 16:54:18 +0100 [thread overview]
Message-ID: <8e1ab920-576e-39dc-93c2-ef97b9f94a51@intel.com> (raw)
In-Reply-To: <1838303.IRcXQLJGt7@xps13>
On 07/11/2016 03:17 PM, Thomas Monjalon wrote:
> 2016-06-08 07:46, Azarewicz, PiotrX T:
>>> 2016-05-25 15:34, Piotr Azarewicz:
>>>> This patch improve generate_random_key() function by replacing rand()
>>>> function with reading from /dev/urandom.
>>>>
>>>> CID 120136 : Calling risky function (DC.WEAK_CRYPTO)
>>>> dont_call: rand should not be used for security related applications,
>>>> as linear congruential algorithms are too easy to break
>>>>
>>>> Coverity issue: 120136
>>>>
>>>> Signed-off-by: Piotr Azarewicz <piotrx.t.azarewicz@intel.com>
>>>
>>> Is it relevant for this example?
>>
>> Maybe not. But it don't break anything, and in the end make Coverity tool happy.
>>
>> Declan, please share your opinion.
>
> Declan?
>
sorry I'm missed this thread. While not strictly necessary for the
example app, I don't see a problem applying it, as coverity points out
it is a bad idea to use rand() for crypto purposes.
Declan
next prev parent reply other threads:[~2016-07-13 15:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-25 13:34 Piotr Azarewicz
2016-06-07 20:30 ` Thomas Monjalon
2016-06-08 7:46 ` Azarewicz, PiotrX T
2016-07-11 14:17 ` Thomas Monjalon
2016-07-13 15:54 ` Declan Doherty [this message]
2016-07-13 15:55 ` Declan Doherty
2016-07-15 22:09 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e1ab920-576e-39dc-93c2-ef97b9f94a51@intel.com \
--to=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=piotrx.t.azarewicz@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).