From: santosh <santosh.shukla@caviumnetworks.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, dev@dpdk.org
Cc: olivier.matz@6wind.com
Subject: Re: [dpdk-dev] [PATCH] test/mempool: improve default mempool ops selection
Date: Tue, 12 Dec 2017 20:40:43 +0530 [thread overview]
Message-ID: <8e63e5f6-36e4-5d0d-af64-b15515f4dfeb@caviumnetworks.com> (raw)
In-Reply-To: <20171117180703.4085-1-jerin.jacob@caviumnetworks.com>
On Friday 17 November 2017 11:37 PM, Jerin Jacob wrote:
> Use of rte_eal_mbuf_default_mempool_ops() API will
> allow to override pool handler through "--mbuf-pool-ops-name"
> eal command line argument.
>
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
> test/test/test_mempool.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/test/test/test_mempool.c b/test/test/test_mempool.c
> index 37ead503b..46eb5ce06 100644
> --- a/test/test/test_mempool.c
> +++ b/test/test/test_mempool.c
> @@ -565,7 +565,7 @@ test_mempool(void)
>
> /* Create a mempool based on Default handler */
> printf("Testing %s mempool handler\n",
> - RTE_MBUF_DEFAULT_MEMPOOL_OPS);
> + rte_eal_mbuf_default_mempool_ops());
> default_pool = rte_mempool_create_empty("default_pool",
> MEMPOOL_SIZE,
> MEMPOOL_ELT_SIZE,
> @@ -577,7 +577,7 @@ test_mempool(void)
> goto err;
> }
> if (rte_mempool_set_ops_byname(default_pool,
> - RTE_MBUF_DEFAULT_MEMPOOL_OPS, NULL) < 0) {
> + rte_eal_mbuf_default_mempool_ops(), NULL) < 0) {
> printf("cannot set %s handler\n",
> RTE_MBUF_DEFAULT_MEMPOOL_OPS);
Pl. replace error printf _ops with _mbuf_default_mempool_ops.
With that:
Acked-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
Thanks.
next prev parent reply other threads:[~2017-12-12 15:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-17 18:07 Jerin Jacob
2017-12-12 14:21 ` Olivier MATZ
2017-12-12 15:10 ` santosh [this message]
2018-01-09 15:57 ` [dpdk-dev] [PATCH v2] " Jerin Jacob
2018-01-16 14:25 ` Olivier Matz
2018-01-18 14:09 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e63e5f6-36e4-5d0d-af64-b15515f4dfeb@caviumnetworks.com \
--to=santosh.shukla@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).