From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Kevin Traynor <ktraynor@redhat.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] vfio: expand non-viable group error message
Date: Fri, 26 Apr 2019 17:31:27 +0100 [thread overview]
Message-ID: <8e70dd36-7981-8837-1481-9cbebcf89e90@intel.com> (raw)
In-Reply-To: <20190426162230.21158-1-ktraynor@redhat.com>
On 26-Apr-19 5:22 PM, Kevin Traynor wrote:
> "VFIO group is not viable" error message is correct
> but not very user friendly for something which can
> usually be easily rectified.
>
> Add some additional text to give more of a hint.
>
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> ---
> lib/librte_eal/linux/eal/eal_vfio.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/linux/eal/eal_vfio.c b/lib/librte_eal/linux/eal/eal_vfio.c
> index 19e70bb66..6892a2c14 100644
> --- a/lib/librte_eal/linux/eal/eal_vfio.c
> +++ b/lib/librte_eal/linux/eal/eal_vfio.c
> @@ -686,5 +686,7 @@ rte_vfio_setup_device(const char *sysfs_base, const char *dev_addr,
> return -1;
> } else if (!(group_status.flags & VFIO_GROUP_FLAGS_VIABLE)) {
> - RTE_LOG(ERR, EAL, " %s VFIO group is not viable!\n", dev_addr);
> + RTE_LOG(ERR, EAL, " %s VFIO group is not viable! "
> + "Not all devices in IOMMU group bound to VFIO or unbound\n",
> + dev_addr);
> close(vfio_group_fd);
> rte_vfio_clear_group(vfio_group_fd);
>
Come on, everyone knows /that/!
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
--
Thanks,
Anatoly
next prev parent reply other threads:[~2019-04-26 16:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-26 16:22 Kevin Traynor
2019-04-26 16:22 ` Kevin Traynor
2019-04-26 16:31 ` Burakov, Anatoly [this message]
2019-04-26 16:31 ` Burakov, Anatoly
2019-04-27 6:58 ` Rami Rosen
2019-04-27 6:58 ` Rami Rosen
2019-05-03 20:43 ` Thomas Monjalon
2019-05-03 20:43 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e70dd36-7981-8837-1481-9cbebcf89e90@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=ktraynor@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).