From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: "Xia, Chenbo" <chenbo.xia@intel.com>,
David Marchand <david.marchand@redhat.com>,
Thomas Monjalon <thomas@monjalon.net>
Cc: "stable@dpdk.org" <stable@dpdk.org>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH v3 1/4] vhost: fix vq use after free on NUMA reallocation
Date: Wed, 14 Sep 2022 09:14:46 +0200 [thread overview]
Message-ID: <8e7d0748-afa9-0ed0-443a-62b2523d7403@redhat.com> (raw)
In-Reply-To: <SN6PR11MB3504AD228FF5BC3AC6FBA8999C469@SN6PR11MB3504.namprd11.prod.outlook.com>
Hi Chenbo,
On 9/14/22 03:05, Xia, Chenbo wrote:
> Hi Maxime,
>
>> -----Original Message-----
>> From: Maxime Coquelin <maxime.coquelin@redhat.com>
>> Sent: Tuesday, September 13, 2022 11:03 PM
>> To: David Marchand <david.marchand@redhat.com>; Xia, Chenbo
>> <chenbo.xia@intel.com>; Thomas Monjalon <thomas@monjalon.net>
>> Cc: stable@dpdk.org; dev@dpdk.org
>> Subject: Re: [PATCH v3 1/4] vhost: fix vq use after free on NUMA
>> reallocation
>>
>> Hi,
>>
>> On 7/26/22 09:55, Maxime Coquelin wrote:
>>>
>>>
>>> On 7/25/22 22:32, David Marchand wrote:
>>>> translate_ring_addresses (via numa_realloc) may change a virtio device
>>>> and
>>>> virtio queue.
>>>> The virtqueue object must be refreshed before accessing the lock.
>>>>
>>>> Fixes: 04c27cb673b9 ("vhost: fix unsafe vring addresses modifications")
>>>> Cc: stable@dpdk.org
>>>>
>>>> Signed-off-by: David Marchand <david.marchand@redhat.com>
>>>> ---
>>>> lib/vhost/vhost_user.c | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c
>>>> index 4ad28bac45..91d40e32fc 100644
>>>> --- a/lib/vhost/vhost_user.c
>>>> +++ b/lib/vhost/vhost_user.c
>>>> @@ -2596,6 +2596,7 @@ vhost_user_iotlb_msg(struct virtio_net **pdev,
>>>> if (is_vring_iotlb(dev, vq, imsg)) {
>>>> rte_spinlock_lock(&vq->access_lock);
>>>> *pdev = dev = translate_ring_addresses(dev, i);
>>>> + vq = dev->virtqueue[i];
>>>> rte_spinlock_unlock(&vq->access_lock);
>>>> }
>>>> }
>>>
>>> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>>>
>>> Thanks,
>>> Maxime
>>
>> The bug this patch is fixing is being reproduced downstream.
>> It would be great it gets merged in main branch rapidly so that we can
>> perform the backport.
>>
>> Chenbo, are you planning a pull request for vhost/virtio in the next few
>> days? If not, should the main branch maintainer pick this single patch
>> directly and let the rest of the series more time for reviews?
>
> Based on the status of all patches in the list, I guess PR will not happen
> this week. So it will be good if David/Thomas can directly pick up this.
OK, sounds good to me.
Thomas/David, is that good on your side?
Thanks,
Maxime
> Thanks,
> Chenbo
>
>>
>> Thanks,
>> Maxime
>
next prev parent reply other threads:[~2022-09-14 7:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220722135320.109269-1-david.marchand@redhat.com>
[not found] ` <20220725203206.427083-1-david.marchand@redhat.com>
2022-07-25 20:32 ` David Marchand
2022-07-26 7:55 ` Maxime Coquelin
2022-09-13 15:02 ` Maxime Coquelin
2022-09-14 1:05 ` Xia, Chenbo
2022-09-14 7:14 ` Maxime Coquelin [this message]
2022-09-14 9:15 ` Thomas Monjalon
2022-09-14 9:34 ` Maxime Coquelin
2022-09-14 9:45 ` Thomas Monjalon
2022-09-14 11:48 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e7d0748-afa9-0ed0-443a-62b2523d7403@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).