From: "Gupta, Nipun" <nipun.gupta@amd.com>
To: Wenwu Ma <wenwux.ma@intel.com>, anatoly.burakov@intel.com, dev@dpdk.org
Cc: david.marchand@redhat.com, maxime.coquelin@redhat.com,
linglix.chen@intel.com, stable@dpdk.org
Subject: Re: [PATCH v5] bus/pci: fix legacy device IO port map in secondary process
Date: Fri, 27 Oct 2023 18:20:30 +0530 [thread overview]
Message-ID: <8e98db9b-190f-45eb-928b-f618cbb03bd6@amd.com> (raw)
In-Reply-To: <20231024020021.116278-1-wenwux.ma@intel.com>
On 10/24/2023 7:30 AM, Wenwu Ma wrote:
> When doing IO port mapping for legacy device in secondary process, the
> region information is missing, so, we need to refill it.
>
> Fixes: 4b741542ecde ("bus/pci: avoid depending on private kernel value")
> Cc: stable@dpdk.org
>
> Signed-off-by: Wenwu Ma <wenwux.ma@intel.com>
> ---
> v5:
> - adding checks to vfio setup
> v4:
> - adjusting commit log
> v3:
> - adjusting variable settings
> v2:
> - add release of device in pci_vfio_ioport_unmap
>
> ---
> drivers/bus/pci/linux/pci_vfio.c | 52 ++++++++++++++++++++++++++++++--
> 1 file changed, 50 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bus/pci/linux/pci_vfio.c b/drivers/bus/pci/linux/pci_vfio.c
> index 3f3201daf2..a1f7cc2421 100644
> --- a/drivers/bus/pci/linux/pci_vfio.c
> +++ b/drivers/bus/pci/linux/pci_vfio.c
> @@ -1230,6 +1230,36 @@ pci_vfio_ioport_map(struct rte_pci_device *dev, int bar,
> return -1;
> }
>
> + if (rte_eal_process_type() == RTE_PROC_SECONDARY) {
> + struct vfio_device_info device_info = { .argsz = sizeof(device_info) };
> + char pci_addr[PATH_MAX];
> + int vfio_dev_fd;
> + struct rte_pci_addr *loc = &dev->addr;
> + /* store PCI address string */
> + snprintf(pci_addr, sizeof(pci_addr), PCI_PRI_FMT,
> + loc->domain, loc->bus, loc->devid, loc->function);
> +
> + vfio_dev_fd = rte_intr_dev_fd_get(dev->intr_handle);
> + if (vfio_dev_fd < 0)
> + return -1;
> +
> + if (vfio_dev_fd == 0) {
> + if (rte_vfio_setup_device(rte_pci_get_sysfs_path(), pci_addr,
> + &vfio_dev_fd, &device_info))
> + return -1;
> +
> + /* we need save vfio_dev_fd, so it can be used during release */
> + if (rte_intr_dev_fd_set(dev->intr_handle, vfio_dev_fd))
> + return -1;
> + } else {
> + if (ioctl(vfio_dev_fd, VFIO_DEVICE_GET_INFO, &device_info))
> + return -1;
> + }
Code upto here is to get device info, IMO we should have a separate API
for this in VFIO layer which can be used from any driver, rather than
being limited here.
This can go into a new API like rte_vfio_get_device_info() in eal_vfio.c.
Thanks,
Nipun
next prev parent reply other threads:[~2023-10-27 12:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 1:58 [PATCH] " Wenwu Ma
2023-08-13 6:15 ` Gupta, Nipun
2023-08-16 1:11 ` Ma, WenwuX
2023-08-21 1:27 ` [PATCH v2] " Wenwu Ma
2023-08-21 2:53 ` Stephen Hemminger
2023-08-22 2:13 ` Ma, WenwuX
2023-08-22 2:18 ` [PATCH v3] " Wenwu Ma
2023-08-28 6:06 ` Gupta, Nipun
2023-08-29 8:00 ` Ma, WenwuX
2023-08-30 5:07 ` [PATCH v4] " Wenwu Ma
2023-09-04 15:06 ` Gupta, Nipun
2023-09-05 3:10 ` Ling, WeiX
2023-10-03 10:21 ` David Marchand
2023-10-09 3:06 ` Ma, WenwuX
2023-10-18 10:05 ` David Marchand
2023-10-18 12:38 ` Gupta, Nipun
2023-10-18 13:44 ` David Marchand
2023-10-24 2:00 ` [PATCH v5] " Wenwu Ma
2023-10-27 12:50 ` Gupta, Nipun [this message]
2023-11-14 10:24 ` [PATCH v6] bus/pci: fix legacy device IO port map Mingjin Ye
2023-11-15 11:26 ` Gupta, Nipun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e98db9b-190f-45eb-928b-f618cbb03bd6@amd.com \
--to=nipun.gupta@amd.com \
--cc=anatoly.burakov@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=linglix.chen@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=wenwux.ma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).