From: "lihuisong (C)" <lihuisong@huawei.com>
To: fengchengwen <fengchengwen@huawei.com>,
Ferruh Yigit <ferruh.yigit@amd.com>,
Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>,
Dengdui Huang <huangdengdui@huawei.com>
Cc: <dev@dpdk.org>, Song Jiale <songx.jiale@intel.com>,
Zhimin Huang <zhiminx.huang@intel.com>
Subject: Re: [PATCH] app/testpmd: fix set Tx offload command
Date: Fri, 17 Nov 2023 09:31:18 +0800 [thread overview]
Message-ID: <9016ca9e-8f26-d086-dec5-c02cf358fd93@huawei.com> (raw)
In-Reply-To: <b7db45ed-89ae-dd55-deca-a198cb88dcca@huawei.com>
Acked-by: Huisong Li <lihuisong@huawei.com>
在 2023/11/17 9:05, fengchengwen 写道:
> Reviewed-by: Chengwen Feng <fengchengwen@huawei.com>
>
> On 2023/11/17 1:21, Ferruh Yigit wrote:
>> In command to set Tx offload:
>> "port config <port_id> tx_offload <offload> on|off",
>>
>> there is a defect in "on|off" comparison, so command does opposite of
>> what is intended. Fixed comparison.
>>
>> Fixes: 6280fe565b44 ("app/testpmd: allow offload config for all ports")
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com>
>> ---
>> Cc: huangdengdui@huawei.com
>> Cc: lihuisong@huawei.com
>> Cc: Song Jiale <songx.jiale@intel.com>
>> Cc: Zhimin Huang <zhiminx.huang@intel.com>
>> ---
>> app/test-pmd/cmdline.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
>> index c040de7a7991..9369d3b4c526 100644
>> --- a/app/test-pmd/cmdline.c
>> +++ b/app/test-pmd/cmdline.c
>> @@ -11737,7 +11737,7 @@ cmd_config_per_port_tx_offload_parsed(void *parsed_result,
>> struct cmd_config_per_port_tx_offload_result *res = parsed_result;
>> bool on;
>>
>> - on = strcmp(res->on_off, "on");
>> + on = strcmp(res->on_off, "on") == 0;
>> config_port_tx_offload(res->port_id, res->offload, on);
>> }
>>
>>
> .
next prev parent reply other threads:[~2023-11-17 1:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 17:21 Ferruh Yigit
2023-11-17 1:05 ` fengchengwen
2023-11-17 1:31 ` lihuisong (C) [this message]
2023-11-17 10:19 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9016ca9e-8f26-d086-dec5-c02cf358fd93@huawei.com \
--to=lihuisong@huawei.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=ferruh.yigit@amd.com \
--cc=huangdengdui@huawei.com \
--cc=songx.jiale@intel.com \
--cc=yuying.zhang@intel.com \
--cc=zhiminx.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).