From: Thomas Monjalon <thomas@monjalon.net>
To: Ilya Matveychikov <matvejchikov@gmail.com>
Cc: dev@dpdk.org, Olivier MATZ <olivier.matz@6wind.com>
Subject: Re: [dpdk-dev] [PATCH] mbuf: fix for incomplete nb_segs types change
Date: Tue, 14 Nov 2017 23:46:45 +0100 [thread overview]
Message-ID: <9049896.KWG8HvEvih@xps> (raw)
In-Reply-To: <20171114082444.7v2dspzxno2vmbln@platinum>
14/11/2017 09:24, Olivier MATZ:
> On Tue, Nov 14, 2017 at 06:09:35AM +0100, Thomas Monjalon wrote:
> > > > >> Update types of variables to correspond to nb_segs type change from
> > > > >> uint8_t to uint16_t.
> > > > >>
> > > > >> Fixes: 97cb466d65c9 ("mbuf: use 2 bytes for port and nb segments")
> > > > >> Cc: olivier.matz@6wind.com
> > > > >>
> > > > >> Signed-off-by: Ilya V. Matveychikov <matvejchikov@gmail.com>
> > > Acked-by: Olivier Matz <olivier.matz@6wind.com>
> >
> > Is there a real benefit to get it in 17.11?
>
> Without this patch:
>
> - cloning a mbuf with more than 255 segments will create an mbuf with an
> invalid number of segments.
>
> - chaining mbufs with rte_pktmbuf_chain() will return an error if the
> resulting mbuf has more than 255 segments.
>
> > Is there a risk?
>
> It is not so critical, since manipulating mbufs with a large number of
> segments is a very specific use case.
>
> But the risk seems low, I think we can put it in 17.11.
OK, applied, thanks
prev parent reply other threads:[~2017-11-14 22:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 13:51 [dpdk-dev] [PATCH] mbuf: fix for incomplete nb_segs/port " Ilya Matveychikov
2017-11-09 23:26 ` Stephen Hemminger
2017-11-10 13:56 ` [dpdk-dev] [PATCH] mbuf: fix for incomplete nb_segs " Ilya V. Matveychikov
2017-11-13 10:10 ` Olivier MATZ
2017-11-13 10:18 ` Ilya Matveychikov
2017-11-13 10:21 ` Ilya Matveychikov
2017-11-13 10:33 ` Olivier MATZ
2017-11-14 5:09 ` Thomas Monjalon
2017-11-14 8:24 ` Olivier MATZ
2017-11-14 22:46 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9049896.KWG8HvEvih@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=matvejchikov@gmail.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).