From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@6wind.com>
Cc: dev@dpdk.org, "Yongseok Koh" <yskoh@mellanox.com>,
"Adrien Mazarguil" <adrien.mazarguil@6wind.com>,
"Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>,
"Shahaf Shuler" <shahafs@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: only register memory callback when probing a device
Date: Wed, 30 May 2018 21:07:10 +0200 [thread overview]
Message-ID: <9098846.r4ODMIHPIA@xps> (raw)
In-Reply-To: <CALwxeUs3MdZx1X0FpRpriY0U5+xXz2xDc4M4iy4eY3UpTyqYHQ@mail.gmail.com>
30/05/2018 18:04, David Marchand:
> On Wed, May 30, 2018 at 5:59 PM, Yongseok Koh <yskoh@mellanox.com> wrote:
> >> On May 30, 2018, at 7:42 AM, David Marchand <david.marchand@6wind.com> wrote:
> >>
> >> The callback should be invoked only for memory that has been registered
> >> in a device, hence, no need to track cleanup events if no device is
> >> present.
> >>
> >> Bugzilla-ID: 56
> >> Fixes: 974f1e7ef146 ("net/mlx5: add new memory region support")
> >>
> >> Signed-off-by: David Marchand <david.marchand@6wind.com>
> >> ---
> >
> > Good finding! Thank you so much for the patch.
> > Patch is good. Just to be sure, I've run traffic with testpmd and also run
> > multi-process test examples with traffic. It runs well.
> >
> > Acked-by: Yongseok Koh <yskoh@mellanox.com>
>
> Well, this is a quick fix, the mlx5_prepare_shared_data() now does
> more than initialising the shared data...
> Might be better to revisit later, but this should do the job for 18.05.
Applied, thanks
next prev parent reply other threads:[~2018-05-30 19:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-30 14:42 David Marchand
2018-05-30 15:59 ` Yongseok Koh
2018-05-30 16:04 ` David Marchand
2018-05-30 19:07 ` Thomas Monjalon [this message]
2018-05-30 16:02 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9098846.r4ODMIHPIA@xps \
--to=thomas@monjalon.net \
--cc=adrien.mazarguil@6wind.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
--cc=shahafs@mellanox.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).