From: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] Pass verbose flag to kernel module
Date: Wed, 15 Oct 2014 13:05:16 +0000 [thread overview]
Message-ID: <91383E96CE459D47BCE92EFBF5CE73B0C7E872@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <6226905.S8oySLlmRr@xps13>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Wednesday, October 15, 2014 1:05 PM
> To: De Lara Guarch, Pablo; Gonzalez Monroy, Sergio
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] Pass verbose flag to kernel module
>
> Sergio,
>
> I'd like to see a v2 patch with your explanations in commit log and with a
> Signed-off-by.
>
My mistake, I will be more careful to check proper comments and signed-off.
V2 on the way.
> > > - CROSS_COMPILE=$(CROSS)
> > > + V=$(if $(V),1,0) CROSS_COMPILE=$(CROSS)
>
> Minor nits:
> - paren is not needed for one letter variable
I don't mind doing this but a quick grep on the current code
will show more single letters with parenthesis than without.
I was just trying to be consistent with current style.
Thanks,
Sergio
> - V option should go to the end to keep things sorted by importance
>
> - CROSS_COMPILE=$(CROSS)
> + CROSS_COMPILE=$(CROSS) V=$(if $V,1,0)
>
> > Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>
> Please Pablo, do not give your ack if there is no Signed-off-by.
> It's mandatory.
>
> Thanks
> --
> Thomas
next prev parent reply other threads:[~2014-10-15 12:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-06 16:09 Sergio Gonzalez Monroy
2014-10-08 17:05 ` Thomas Monjalon
2014-10-09 9:37 ` Sergio Gonzalez Monroy
2014-10-09 12:15 ` Thomas Monjalon
2014-10-13 16:08 ` De Lara Guarch, Pablo
2014-10-15 12:04 ` Thomas Monjalon
2014-10-15 13:05 ` Gonzalez Monroy, Sergio [this message]
2014-10-15 13:08 ` [dpdk-dev] [PATCH] Set V=1 when building kernel modules Sergio Gonzalez Monroy
2014-10-15 13:43 ` Gonzalez Monroy, Sergio
2014-10-15 13:08 ` [dpdk-dev] [PATCH v2] " Sergio Gonzalez Monroy
2014-10-15 14:02 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91383E96CE459D47BCE92EFBF5CE73B0C7E872@IRSMSX108.ger.corp.intel.com \
--to=sergio.gonzalez.monroy@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).