From: "Eads, Gage" <gage.eads@intel.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>,
"Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Vangati, Narender" <narender.vangati@intel.com>,
"Rao, Nikhil" <nikhil.rao@intel.com>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
"Doherty, Declan" <declan.doherty@intel.com>,
"nidadavolu.murthy@cavium.com" <nidadavolu.murthy@cavium.com>,
"nithin.dabilpuram@cavium.com" <nithin.dabilpuram@cavium.com>,
"narayanaprasad.athreya@cavium.com"
<narayanaprasad.athreya@cavium.com>
Subject: Re: [dpdk-dev] [RFC] eventdev: add crypto adapter API header
Date: Wed, 13 Dec 2017 23:35:48 +0000 [thread overview]
Message-ID: <9184057F7FC11744A2107296B6B8EB1E2BB1B296@FMSMSX108.amr.corp.intel.com> (raw)
In-Reply-To: <20171129114153.GA16467@jerin>
Hey Jerin,
</snip>
> > +
> > + /**
> > + * @warning
> > + * @b EXPERIMENTAL: this enum may change without prior notice
> > + *
> > + * Crypto event adapter type
> > + */
> > +enum rte_event_crypto_adapter_type {
> > + RTE_EVENT_CRYPTO_ADAPTER_RX_ONLY = 1,
> > + /**< Start only Rx part of crypto adapter.
> > + * Packets dequeued from cryptodev are new to eventdev and
> > + * events will be treated as RTE_EVENT_OP_NEW */
> > + RTE_EVENT_CRYPTO_ADAPTER_RX_TX,
> > + /**< Start both Rx & Tx part of crypto adapter.
> > + * Packet's event context will be retained and
> > + * event will be treated as RTE_EVENT_OP_FORWARD */ };
>
> How about leveraging ev.op based schematics as mentioned above?
That could work, but perhaps the ev.op should be configured once up front, as I see it being a function of the application architecture. A couple possible designs, for example:
- Worker enqueues into cryptodev, adapter polls for response: the adapter port would always use OP_NEW here.
- Worker sends a crypto request event to the adapter, which gives the request to the cryptodev and polls for response: the adapter port would always use OP_FWD here. (This ties in with my implicit release patch (http://dpdk.org/ml/archives/dev/2017-December/083535.html))
- Etc.
So I think it makes sense to specify the op once at adapter configuration time, rather than repeatedly in the datapath. This allows for a cleaner separation of configuration and datapath code, and specifying it just once means fewer chances to accidentally set the wrong op value.
Thanks,
Gage
next prev parent reply other threads:[~2017-12-13 23:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 6:54 Abhinandan Gujjar
2017-11-29 11:41 ` Jerin Jacob
2017-12-13 11:03 ` Doherty, Declan
2017-12-13 11:26 ` Jerin Jacob
2017-12-13 12:28 ` Nithin Dabilpuram
2017-12-13 14:29 ` Akhil Goyal
2017-12-13 14:22 ` Akhil Goyal
2017-12-13 17:37 ` Jerin Jacob
2017-12-13 23:35 ` Eads, Gage [this message]
2017-12-14 2:49 ` Jerin Jacob
2017-12-14 18:52 ` Eads, Gage
2017-12-18 6:30 ` Jerin Jacob
2017-12-18 16:33 ` Eads, Gage
2017-12-19 8:47 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9184057F7FC11744A2107296B6B8EB1E2BB1B296@FMSMSX108.amr.corp.intel.com \
--to=gage.eads@intel.com \
--cc=abhinandan.gujjar@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=narayanaprasad.athreya@cavium.com \
--cc=narender.vangati@intel.com \
--cc=nidadavolu.murthy@cavium.com \
--cc=nikhil.rao@intel.com \
--cc=nithin.dabilpuram@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).