From: "Eads, Gage" <gage.eads@intel.com>
To: Aaron Conole <aconole@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"jerinj@marvell.com" <jerinj@marvell.com>,
"Van Haaren, Harry" <harry.van.haaren@intel.com>,
"Rao, Nikhil" <nikhil.rao@intel.com>,
"Carrillo, Erik G" <erik.g.carrillo@intel.com>,
"nhorman@tuxdriver.com" <nhorman@tuxdriver.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Subject: Re: [dpdk-dev] [PATCH] eal: promote some service core functions to stable
Date: Thu, 20 Jun 2019 18:39:27 +0000 [thread overview]
Message-ID: <9184057F7FC11744A2107296B6B8EB1E68CFF91C@FMSMSX108.amr.corp.intel.com> (raw)
In-Reply-To: <f7tv9x0ru55.fsf@dhcp-25.97.bos.redhat.com>
> Gage Eads <gage.eads@intel.com> writes:
>
> > The functions rte_service_may_be_active(),
> > rte_service_lcore_attr_get(), and rte_service_attr_reset_all() were
> > introduced nearly a year ago in DPDK 18.08. They can be considered non-
> experimental for the 19.08 release.
> >
> > rte_service_may_be_active() is used by eventdev and the sw PMD, and
> > this commit allows them to not need any experimental API.
> >
> > Signed-off-by: Gage Eads <gage.eads@intel.com>
> > ---
> > drivers/event/sw/Makefile | 1 -
> > drivers/event/sw/meson.build | 1 -
> > lib/librte_eal/common/include/rte_service.h | 15 +++------------
> > lib/librte_eal/common/rte_service.c | 6 +++---
> > lib/librte_eal/rte_eal_version.map | 6 +++---
> > lib/librte_eventdev/Makefile | 1 -
> > lib/librte_eventdev/meson.build | 1 -
> > 7 files changed, 9 insertions(+), 22 deletions(-)
> >
> > diff --git a/drivers/event/sw/Makefile b/drivers/event/sw/Makefile
> > index 81236a392..c6600e836 100644
> > --- a/drivers/event/sw/Makefile
> > +++ b/drivers/event/sw/Makefile
> > @@ -7,7 +7,6 @@ include $(RTE_SDK)/mk/rte.vars.mk LIB =
> > librte_pmd_sw_event.a
> >
> > # build flags
> > -CFLAGS += -DALLOW_EXPERIMENTAL_API
> > CFLAGS += -O3
> > CFLAGS += $(WERROR_FLAGS)
> > # for older GCC versions, allow us to initialize an event using diff
> > --git a/drivers/event/sw/meson.build b/drivers/event/sw/meson.build
> > index 30d221647..985012219 100644
> > --- a/drivers/event/sw/meson.build
> > +++ b/drivers/event/sw/meson.build
> > @@ -1,7 +1,6 @@
> > # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2017 Intel
> > Corporation
> >
> > -allow_experimental_apis = true
>
> I don't think you can remove these. There are still some experimental APIs
> (f.e. the rename for rte_cryptodev_sym_session_get_private_data
> marked that function as experimental and it will cause build breakage).
>
> Maybe I'm mis understanding it? It would be good to get verification from
> Bruce whether that API should not be marked as experimental (it was just a
> rename, so not sure...) - maybe that's a follow up for this patch?
>
> See: https://travis-ci.com/ovsrobot/dpdk/jobs/209722145 for an example
>
> The odd thing is I only see it on the clang builds - perhaps it's a missing
> definition for the clang compiler.
>
You're right, eventdev still uses that experimental API (which this patch is unrelated to). I tested this change with GCC (5.4.0) and it built without errors, which I took to mean no more experimental APIs were in use. That's concerning that GCC didn't catch it.
At any rate, I'll correct this in v2.
Thanks,
Gage
next prev parent reply other threads:[~2019-06-20 18:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 16:42 Gage Eads
2019-06-20 18:25 ` Aaron Conole
2019-06-20 18:39 ` Eads, Gage [this message]
2019-06-20 19:45 ` David Marchand
2019-06-20 20:16 ` David Marchand
2019-06-21 12:45 ` David Marchand
2019-06-21 16:27 ` Neil Horman
2019-06-21 16:47 ` David Marchand
2019-06-21 17:40 ` Neil Horman
2019-06-21 19:58 ` David Marchand
2019-06-22 16:17 ` Neil Horman
2019-06-22 17:51 ` David Marchand
2019-06-22 19:33 ` Neil Horman
2019-06-20 19:02 ` [dpdk-dev] [PATCH v2] " Gage Eads
2019-06-27 12:48 ` David Marchand
2019-06-27 16:25 ` Eads, Gage
2019-07-08 10:23 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9184057F7FC11744A2107296B6B8EB1E68CFF91C@FMSMSX108.amr.corp.intel.com \
--to=gage.eads@intel.com \
--cc=aconole@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=harry.van.haaren@intel.com \
--cc=jerinj@marvell.com \
--cc=nhorman@tuxdriver.com \
--cc=nikhil.rao@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).