From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Chen, Jing D" <jing.d.chen@intel.com>
Cc: dev@dpdk.org, "Wang, Xiao W" <xiao.w.wang@intel.com>,
"Lin, Xueqin" <xueqin.lin@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/fm10k: fix RSS hash config
Date: Fri, 22 Jul 2016 10:21:34 +0200 [thread overview]
Message-ID: <91849256.XuHjXYpFvk@xps13> (raw)
In-Reply-To: <B7F2E978279D1D49A3034B7786DACF403DC17A43@SHSMSX101.ccr.corp.intel.com>
2016-07-21 09:35, Wang, Xiao W:
> From: Chen, Jing D
> > > --- a/drivers/net/fm10k/fm10k_ethdev.c
> > > +++ b/drivers/net/fm10k/fm10k_ethdev.c
> > > @@ -2159,8 +2159,8 @@ fm10k_rss_hash_update(struct rte_eth_dev *dev,
> > >
> > > PMD_INIT_FUNC_TRACE();
> > >
> > > - if (rss_conf->rss_key_len < FM10K_RSSRK_SIZE *
> > > - FM10K_RSSRK_ENTRIES_PER_REG)
> > > + if (key && (rss_conf->rss_key_len < FM10K_RSSRK_SIZE *
> > > + FM10K_RSSRK_ENTRIES_PER_REG))
> > > return -EINVAL;
> > >
> > > if (hf == 0)
> >
> > It's also possible that app wants to update rss key and not expect to update hash
> > function.
> > Is that indicate we shouldn't return error in case hf == 0?
> >
>
> If the app just wants to update RSS key, it needs to read out the RSS config first, then
> change only the key field. This is what testpmd does for this operation.
>
> hf == 0 will disable RSS feature, I think we should return error to protect multi-queue.
Jing, do you confirm we can apply this patch, please?
next prev parent reply other threads:[~2016-07-22 8:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 8:24 Xiao Wang
2016-07-21 8:48 ` Chen, Jing D
2016-07-21 9:35 ` Wang, Xiao W
2016-07-22 8:21 ` Thomas Monjalon [this message]
2016-07-22 8:23 ` Chen, Jing D
2016-07-22 8:28 ` Thomas Monjalon
2016-07-22 9:05 ` Chen, Jing D
2016-07-22 9:53 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91849256.XuHjXYpFvk@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=jing.d.chen@intel.com \
--cc=xiao.w.wang@intel.com \
--cc=xueqin.lin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).