From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Tiwei Bie <tiwei.bie@intel.com>, yliu@fridaylinux.org, dev@dpdk.org
Cc: antonio.fischetti@intel.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH 1/5] net/virtio: fix vector Rx break caused by rxq flushing
Date: Thu, 7 Dec 2017 10:14:37 +0100 [thread overview]
Message-ID: <919b79af-f532-5126-73eb-76415f641664@redhat.com> (raw)
In-Reply-To: <20171207053059.19487-2-tiwei.bie@intel.com>
On 12/07/2017 06:30 AM, Tiwei Bie wrote:
> The vector Rx will be broken if backend has consumed all
> the descs in the avail ring before the device is started.
> Because in current implementation, vector Rx will return
> immediately without refilling the avail ring if the used
> ring is empty. So we have to refill the avail ring after
> flushing the elements in the used ring for vector Rx.
>
> Besides, vector Rx has a different ring layout assumption
> and mbuf management. So we need to handle it differently.
>
> Fixes: d8227497ec5c ("net/virtio: flush Rx queues on start")
> Cc: stable@dpdk.org
>
> Reported-by: Antonio Fischetti <antonio.fischetti@intel.com>
> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> ---
> drivers/net/virtio/virtio_ethdev.c | 2 +-
> drivers/net/virtio/virtqueue.c | 31 ++++++++++++++++++++++++-------
> drivers/net/virtio/virtqueue.h | 2 +-
> 3 files changed, 26 insertions(+), 9 deletions(-)
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
next prev parent reply other threads:[~2017-12-07 9:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171207053059.19487-1-tiwei.bie@intel.com>
2017-12-07 5:30 ` Tiwei Bie
2017-12-07 9:14 ` Maxime Coquelin [this message]
2017-12-07 9:30 ` Fischetti, Antonio
2017-12-07 18:10 ` Fischetti, Antonio
2017-12-07 16:00 ` [dpdk-stable] [dpdk-dev] " Kevin Traynor
2017-12-08 2:30 ` Tiwei Bie
2017-12-08 10:17 ` Kevin Traynor
2017-12-07 5:30 ` [dpdk-stable] [PATCH 2/5] net/virtio: fix typo in LRO support Tiwei Bie
2017-12-07 9:15 ` Maxime Coquelin
[not found] ` <20171211051332.31888-1-tiwei.bie@intel.com>
2017-12-11 5:13 ` [dpdk-stable] [PATCH v2 1/4] net/virtio: fix vector Rx break caused by rxq flushing Tiwei Bie
2017-12-11 5:13 ` [dpdk-stable] [PATCH v2 2/4] net/virtio: fix typo in LRO support Tiwei Bie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=919b79af-f532-5126-73eb-76415f641664@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=antonio.fischetti@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).