DPDK patches and discussions
 help / color / mirror / Atom feed

From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Jiawen Wu <jiawenwu@trustnetic.com>,
	Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH 1/2] net/txgbe: add vectorized functions for Rx/Tx
Date: Thu, 21 Mar 2024 16:27:26 +0000	[thread overview]
Message-ID: <91a42fb8-e0c8-4efb-9eea-f25e5cb2ec43@amd.com> (raw)
In-Reply-To: <07f901da6ed4$a3914660$eab3d320$@trustnetic.com>

On 3/5/2024 8:10 AM, Jiawen Wu wrote:

<...>

>>> +++ b/drivers/net/txgbe/txgbe_rxtx_vec_neon.c
>>> @@ -0,0 +1,604 @@
>>> +/* SPDX-License-Identifier: BSD-3-Clause
>>> + * Copyright(c) 2015-2024 Beijing WangXun Technology Co., Ltd.
>>> + * Copyright(c) 2010-2015 Intel Corporation
>>> + */
>>> +
>>> +#include <ethdev_driver.h>
>>> +#include <rte_malloc.h>
>>> +#include <rte_vect.h>
>>> +
>>> +#include "txgbe_ethdev.h"
>>> +#include "txgbe_rxtx.h"
>>> +#include "txgbe_rxtx_vec_common.h"
>>> +
>>> +#pragma GCC diagnostic ignored "-Wcast-qual"
>>> +
>>
>> Is this pragma really required?
> 
> Yes. Otherwise, there are warnings in the compilation:
> 
> [1909/2921] Compiling C object drivers/libtmp_rte_net_txgbe.a.p/net_txgbe_txgbe_rxtx_vec_neon.c.o
> ../drivers/net/txgbe/txgbe_rxtx_vec_neon.c: In function ‘txgbe_rxq_rearm’:
> ../drivers/net/txgbe/txgbe_rxtx_vec_neon.c:37:15: warning: cast discards ‘volatile’ qualifier from pointer target type [-Wcast-qual]
>      vst1q_u64((uint64_t *)&rxdp[i], zero);
>                ^
> ../drivers/net/txgbe/txgbe_rxtx_vec_neon.c:60:13: warning: cast discards ‘volatile’ qualifier from pointer target type [-Wcast-qual]
>    vst1q_u64((uint64_t *)rxdp++, dma_addr0);
>              ^
> ../drivers/net/txgbe/txgbe_rxtx_vec_neon.c:65:13: warning: cast discards ‘volatile’ qualifier from pointer target type [-Wcast-qual]
>    vst1q_u64((uint64_t *)rxdp++, dma_addr1);
> 

Hi Honnappa,

There are multiple drivers ignores "-Wcast-qual" for neon implementation.

Is there a better, more proper way to address this warning?


Thanks,
ferruh

next prev parent reply	other threads:[~2024-03-21 16:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-01  3:00 [PATCH 0/2] Wangxun support vector Rx/Tx Jiawen Wu
2024-02-01  3:00 ` [PATCH 1/2] net/txgbe: add vectorized functions for Rx/Tx Jiawen Wu
2024-02-07  3:13   ` Ferruh Yigit
2024-03-05  8:10     ` Jiawen Wu
2024-03-21 16:21       ` Ferruh Yigit
2024-04-07  8:32         ` Jiawen Wu
2024-03-21 16:27       ` Ferruh Yigit [this message]
2024-03-21 17:55         ` Tyler Retzlaff
2024-02-01  3:00 ` [PATCH 2/2] net/ngbe: " Jiawen Wu
2024-02-06  1:50 ` [PATCH 0/2] Wangxun support vector Rx/Tx Jiawen Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91a42fb8-e0c8-4efb-9eea-f25e5cb2ec43@amd.com \
    --to=ferruh.yigit@amd.com \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=dev@dpdk.org \
    --cc=jiawenwu@trustnetic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).