From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
Nirmoy Das <ndas@suse.de>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] kni: fix build on SLE12 SP3
Date: Mon, 4 Sep 2017 10:47:11 +0100 [thread overview]
Message-ID: <92fdedff-cded-1ca9-0ea7-c2e8ae7a3752@intel.com> (raw)
In-Reply-To: <20170829081252.562f9313@xeon-e3>
On 8/29/2017 4:12 PM, Stephen Hemminger wrote:
> On Tue, 29 Aug 2017 17:06:13 +0200
> Nirmoy Das <ndas@suse.de> wrote:
>
>> compilation error:
>> build/lib/librte_eal/linuxapp/kni/kni_net.c:215:5: error:
>> ‘struct net_device’ has no member named ‘trans_start’
>> dev->trans_start = jiffies;
>>
>> Signed-off-by: Nirmoy Das <ndas@suse.de>
<...>
> Sigh. KNI needs to get upstream, or we need to leave RHEL and SLES
> version magic to the distros to manage as their own patches.
>
> This kind of spaghetti of ifdef's is unmanageable, untestable, and
> just plain ugly.
I agree with above comment, meanwhile I believe we need to support this
as long as maintained in DPDK.
next prev parent reply other threads:[~2017-09-04 9:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-29 15:06 Nirmoy Das
2017-08-29 15:12 ` Stephen Hemminger
2017-09-04 9:47 ` Ferruh Yigit [this message]
2017-09-04 9:46 ` Ferruh Yigit
2017-09-05 9:55 ` Nirmoy Das
2017-10-06 21:42 ` Ferruh Yigit
2017-10-09 22:04 ` [dpdk-dev] [PATCH v3] " Ferruh Yigit
2017-10-13 22:47 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92fdedff-cded-1ca9-0ea7-c2e8ae7a3752@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=ndas@suse.de \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).