From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Wenzhuo Lu <wenzhuo.lu@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix PF/VF check of flow director
Date: Tue, 25 Oct 2016 23:08:59 +0200 [thread overview]
Message-ID: <9425531.GtZQfLiE8F@xps13> (raw)
In-Reply-To: <1476839535-1220-1-git-send-email-wenzhuo.lu@intel.com>
2016-10-19 09:12, Wenzhuo Lu:
> Parameters pf & vf are added into most of flow director
> filter CLIs.
> But mac-valn and tunnel filters don't have these parameters,
> the parameters should not be checked for mac-vlan and tunnel
> filters.
>
> Fixes: e6a68c013353 ("app/testpmd: extend commands for flow director in VF")
>
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
This bug was reported and fixed by Frederico Cadete:
http://dpdk.org/patch/15264
We have waited long to have a review saying it requires
an optional parameter in the command line.
And finally you re-post a fixed version of the same approach
without any comment to the original thread or a reference here.
Please be more careful with occasional contributors.
Applied with
Reported-by: Frederico Cadete <frederico.cadete-ext@oneaccess-net.com>
prev parent reply other threads:[~2016-10-25 21:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 2:47 [dpdk-dev] [PATCH] app/testpmd: fix pf/vf " Wenzhuo Lu
2016-10-17 20:02 ` De Lara Guarch, Pablo
2016-10-19 1:12 ` [dpdk-dev] [PATCH v2] app/testpmd: fix PF/VF " Wenzhuo Lu
2016-10-25 21:08 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9425531.GtZQfLiE8F@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).