From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Timothy Redaelli <tredaelli@redhat.com>,
Tiwei Bie <tiwei.bie@intel.com>,
Zhihong Wang <zhihong.wang@intel.com>
Cc: Fan Zhang <roy.fan.zhang@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] vhost/crypto: fix build without cryptodev (shared lib)
Date: Tue, 16 Oct 2018 19:07:46 +0200 [thread overview]
Message-ID: <9433dc9a-51e9-704f-b426-a8c04de82b17@redhat.com> (raw)
In-Reply-To: <af48d0002feff550f8a64bf00e5642a19bdfd0f3.1539708892.git.tredaelli@redhat.com>
On 10/16/2018 06:54 PM, Timothy Redaelli wrote:
> Currently it's not possible to build DPDK as shared library with
> cryptodev disabled since vhost is trying to link with rte_crypto,
> but rte_crypto and rte_hash are only needed when you build vhost_crypto
> and so only when cryptodev is enabled.
>
> This patch fix this by linking rte_vhost with rte_crypto and rte_hash only
> when cryptodev is enabled.
>
> Fixes: b4ca81298613 ("vhost/crypto: fix build without cryptodev")
> Fixes: d090c7f86a76 ("vhost/crypto: update makefile")
The above commit does not exist (check-git-log.sh reports an error).
I think this is the commit that should be mentioned:
Fixes: 939066d96563 ("vhost/crypto: add public function implementation")
Also, we need to cc stable@dpdk.org so that it gets backported to
v18.08.
Wit that fixed, please add my:
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
>
> Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
> ---
> lib/librte_vhost/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_vhost/Makefile b/lib/librte_vhost/Makefile
> index 531cf4832..5dd318987 100644
> --- a/lib/librte_vhost/Makefile
> +++ b/lib/librte_vhost/Makefile
> @@ -19,8 +19,7 @@ LDLIBS += -lpthread
> ifeq ($(CONFIG_RTE_LIBRTE_VHOST_NUMA),y)
> LDLIBS += -lnuma
> endif
> -LDLIBS += -lrte_eal -lrte_mempool -lrte_mbuf -lrte_ethdev -lrte_net \
> - -lrte_cryptodev -lrte_hash
> +LDLIBS += -lrte_eal -lrte_mempool -lrte_mbuf -lrte_ethdev -lrte_net
>
> # all source are stored in SRCS-y
> SRCS-$(CONFIG_RTE_LIBRTE_VHOST) := fd_man.c iotlb.c socket.c vhost.c \
> @@ -31,6 +30,7 @@ SYMLINK-$(CONFIG_RTE_LIBRTE_VHOST)-include += rte_vhost.h rte_vdpa.h
>
> # only compile vhost crypto when cryptodev is enabled
> ifeq ($(CONFIG_RTE_LIBRTE_CRYPTODEV),y)
> +LDLIBS += -lrte_cryptodev -lrte_hash
> SRCS-$(CONFIG_RTE_LIBRTE_VHOST) += vhost_crypto.c
> SYMLINK-$(CONFIG_RTE_LIBRTE_VHOST)-include += rte_vhost_crypto.h
> endif
>
prev parent reply other threads:[~2018-10-16 17:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 16:54 Timothy Redaelli
2018-10-16 17:07 ` Maxime Coquelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9433dc9a-51e9-704f-b426-a8c04de82b17@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=roy.fan.zhang@intel.com \
--cc=tiwei.bie@intel.com \
--cc=tredaelli@redhat.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).