From: "Xing, Beilei" <beilei.xing@intel.com>
To: "Zhao1, Wei" <wei.zhao1@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "Zhao1, Wei" <wei.zhao1@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 02/18] net/ixgbe: store flow director filter
Date: Mon, 2 Jan 2017 09:59:01 +0000 [thread overview]
Message-ID: <94479800C636CB44BD422CB454846E013158CE0E@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1483084390-53159-3-git-send-email-wei.zhao1@intel.com>
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Zhao
> Sent: Friday, December 30, 2016 3:53 PM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [dpdk-dev] [PATCH v2 02/18] net/ixgbe: store flow director filter
>
> Add support for storing flow director filter in SW.
>
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> ---
>
> v2:
> --add a fdir initialization function in device start process
> ---
>
> +static inline struct ixgbe_fdir_filter *
> +ixgbe_fdir_filter_lookup(struct ixgbe_hw_fdir_info *fdir_info,
> + union ixgbe_atr_input *key)
> +{
> + int ret = 0;
Needless initialization here since ret will be set below.
> + ret = rte_hash_lookup(fdir_info->hash_handle, (const void *)key);
> + if (ret < 0)
> + return NULL;
> +
> + return fdir_info->hash_map[ret];
> +}
> +
> +static inline int
> +ixgbe_insert_fdir_filter(struct ixgbe_hw_fdir_info *fdir_info,
> + struct ixgbe_fdir_filter *fdir_filter) {
> + int ret = 0;
Same above.
> +
> + ret = rte_hash_add_key(fdir_info->hash_handle,
> + &fdir_filter->ixgbe_fdir);
> +
> + if (ret < 0) {
> + PMD_DRV_LOG(ERR,
> + "Failed to insert fdir filter to hash table %d!",
> + ret);
> + return ret;
> + }
> +
> + fdir_info->hash_map[ret] = fdir_filter;
> +
> + TAILQ_INSERT_TAIL(&fdir_info->fdir_list, fdir_filter, entries);
> +
> + return 0;
> +}
> +
> +static inline int
> +ixgbe_remove_fdir_filter(struct ixgbe_hw_fdir_info *fdir_info,
> + union ixgbe_atr_input *key)
> +{
> + int ret = 0;
Same above.
> + struct ixgbe_fdir_filter *fdir_filter;
> +
> + ret = rte_hash_del_key(fdir_info->hash_handle, key);
> +
> + if (ret < 0) {
> + PMD_DRV_LOG(ERR, "No such fdir filter to delete %d!", ret);
> + return ret;
> + }
> +
> + fdir_filter = fdir_info->hash_map[ret];
> + fdir_info->hash_map[ret] = NULL;
> +
> + TAILQ_REMOVE(&fdir_info->fdir_list, fdir_filter, entries);
> + rte_free(fdir_filter);
> +
> + return 0;
> +}
> +
> /*
> * ixgbe_add_del_fdir_filter - add or remove a flow diretor filter.
> * @dev: pointer to the structure rte_eth_dev @@ -1098,6 +1158,8 @@
> ixgbe_add_del_fdir_filter(struct rte_eth_dev *dev,
> struct ixgbe_hw_fdir_info *info =
> IXGBE_DEV_PRIVATE_TO_FDIR_INFO(dev->data->dev_private);
> enum rte_fdir_mode fdir_mode = dev->data->dev_conf.fdir_conf.mode;
> + struct ixgbe_fdir_filter *node;
> + bool add_node = FALSE;
>
> if (fdir_mode == RTE_FDIR_MODE_NONE)
> return -ENOTSUP;
> @@ -1148,6 +1210,10 @@ ixgbe_add_del_fdir_filter(struct rte_eth_dev *dev,
> dev->data->dev_conf.fdir_conf.pballoc);
>
> if (del) {
> + err = ixgbe_remove_fdir_filter(info, &input);
> + if (err < 0)
> + return err;
> +
> err = fdir_erase_filter_82599(hw, fdirhash);
> if (err < 0)
> PMD_DRV_LOG(ERR, "Fail to delete FDIR filter!"); @@ -1172,6
> +1238,37 @@ ixgbe_add_del_fdir_filter(struct rte_eth_dev *dev,
> else
> return -EINVAL;
>
> + node = ixgbe_fdir_filter_lookup(info, &input);
> + if (node) {
> + if (update) {
> + node->fdirflags = fdircmd_flags;
> + node->fdirhash = fdirhash;
> + node->queue = queue;
> + } else {
> + PMD_DRV_LOG(ERR, "Conflict with existing fdir filter!");
> + return -EINVAL;
> + }
> + } else {
> + add_node = TRUE;
> + node = rte_zmalloc("ixgbe_fdir",
> + sizeof(struct ixgbe_fdir_filter),
> + 0);
> + if (!node)
> + return -ENOMEM;
> + (void)rte_memcpy(&node->ixgbe_fdir,
> + &input,
> + sizeof(union ixgbe_atr_input));
> + node->fdirflags = fdircmd_flags;
> + node->fdirhash = fdirhash;
> + node->queue = queue;
> +
> + err = ixgbe_insert_fdir_filter(info, node);
> + if (err < 0) {
> + rte_free(node);
> + return err;
> + }
> + }
> +
> if (is_perfect) {
> err = fdir_write_perfect_filter_82599(hw, &input, queue,
> fdircmd_flags, fdirhash,
> @@ -1180,10 +1277,14 @@ ixgbe_add_del_fdir_filter(struct rte_eth_dev
> *dev,
> err = fdir_add_signature_filter_82599(hw, &input, queue,
> fdircmd_flags, fdirhash);
> }
> - if (err < 0)
> + if (err < 0) {
> PMD_DRV_LOG(ERR, "Fail to add FDIR filter!");
> - else
> +
> + if (add_node)
> + (void)ixgbe_remove_fdir_filter(info, &input);
> + } else {
> PMD_DRV_LOG(DEBUG, "Success to add FDIR filter");
> + }
>
> return err;
> }
> --
> 2.5.5
next prev parent reply other threads:[~2017-01-02 9:59 UTC|newest]
Thread overview: 149+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-30 7:52 [dpdk-dev] [PATCH v2 00/18] net/ixgbe: Consistent filter API Wei Zhao
2016-12-30 7:52 ` [dpdk-dev] [PATCH v2 01/18] net/ixgbe: store SYN filter Wei Zhao
2017-01-03 14:33 ` Dai, Wei
2017-01-04 1:46 ` Zhao1, Wei
2017-01-06 16:28 ` Ferruh Yigit
2017-01-10 5:33 ` Zhao1, Wei
2017-01-12 8:12 ` [dpdk-dev] [PATCH v3 00/18] net/ixgbe: Consistent filter API Wei Zhao
2017-01-12 8:13 ` [dpdk-dev] [PATCH v3 01/18] net/ixgbe: store TCP SYN filter Wei Zhao
2017-01-12 8:13 ` [dpdk-dev] [PATCH v3 02/18] net/ixgbe: store flow director filter Wei Zhao
2017-01-12 8:13 ` [dpdk-dev] [PATCH v3 03/18] net/ixgbe: store L2 tunnel filter Wei Zhao
2017-01-12 8:13 ` [dpdk-dev] [PATCH v3 04/18] net/ixgbe: restore n-tuple filter Add support for restoring n-tuple filter in SW Wei Zhao
2017-01-12 8:13 ` [dpdk-dev] [PATCH v3 4/9] " Wei Zhao
2017-01-12 8:13 ` [dpdk-dev] [PATCH v3 05/18] net/ixgbe: restore ether type filter Wei Zhao
2017-01-12 8:13 ` [dpdk-dev] [PATCH v3 06/18] net/ixgbe: restore TCP SYN filter Wei Zhao
2017-01-12 8:13 ` [dpdk-dev] [PATCH v3 07/18] net/ixgbe: restore flow director filter Wei Zhao
2017-01-12 8:13 ` [dpdk-dev] [PATCH v3 08/18] net/ixgbe: restore L2 tunnel filter Wei Zhao
2017-01-12 8:13 ` [dpdk-dev] [PATCH v3 09/18] net/ixgbe: store and restore L2 tunnel configuration Wei Zhao
2017-01-12 8:13 ` [dpdk-dev] [PATCH v3 10/18] net/ixgbe: flush all the filters Wei Zhao
2017-01-12 8:13 ` [dpdk-dev] [PATCH v3 11/18] net/ixgbe: parse n-tuple filter Wei Zhao
2017-01-12 8:13 ` [dpdk-dev] [PATCH v3 12/18] net/ixgbe: parse ethertype filter Wei Zhao
2017-01-12 8:13 ` [dpdk-dev] [PATCH v3 13/18] net/ixgbe: parse TCP SYN filter check if the rule is a TCP SYN rule, and get the SYN info Wei Zhao
2017-01-12 8:13 ` [dpdk-dev] [PATCH v3 14/18] net/ixgbe: parse L2 tunnel filter check if the rule is a L2 tunnel rule, and get the L2 tunnel info Wei Zhao
2017-01-12 8:13 ` [dpdk-dev] [PATCH v3 15/18] net/ixgbe: parse flow director filter Wei Zhao
2017-01-12 8:13 ` [dpdk-dev] [PATCH v3 16/18] net/ixgbe: create consistent filter Wei Zhao
2017-01-12 8:13 ` [dpdk-dev] [PATCH v3 17/18] net/ixgbe: destroy " Wei Zhao
2017-01-12 8:13 ` [dpdk-dev] [PATCH v3 18/18] net/ixgbe: flush all the filter list Wei Zhao
2017-01-12 8:40 ` [dpdk-dev] [PATCH v4 00/18] net/ixgbe: Consistent filter API Wei Zhao
2017-01-12 8:40 ` [dpdk-dev] [PATCH v4 01/18] net/ixgbe: store TCP SYN filter Wei Zhao
2017-01-12 8:40 ` [dpdk-dev] [PATCH v4 02/18] net/ixgbe: store flow director filter Wei Zhao
2017-01-12 8:40 ` [dpdk-dev] [PATCH v4 03/18] net/ixgbe: store L2 tunnel filter Wei Zhao
2017-01-12 8:40 ` [dpdk-dev] [PATCH v4 04/18] net/ixgbe: restore n-tuple filter Add support for restoring n-tuple filter in SW Wei Zhao
2017-01-12 8:40 ` [dpdk-dev] [PATCH v4 05/18] net/ixgbe: restore ether type filter Wei Zhao
2017-01-12 8:40 ` [dpdk-dev] [PATCH v4 06/18] net/ixgbe: restore TCP SYN filter Wei Zhao
2017-01-12 8:40 ` [dpdk-dev] [PATCH v4 07/18] net/ixgbe: restore flow director filter Wei Zhao
2017-01-12 8:40 ` [dpdk-dev] [PATCH v4 08/18] net/ixgbe: restore L2 tunnel filter Wei Zhao
2017-01-12 8:40 ` [dpdk-dev] [PATCH v4 09/18] net/ixgbe: store and restore L2 tunnel configuration Wei Zhao
2017-01-12 8:40 ` [dpdk-dev] [PATCH v4 10/18] net/ixgbe: flush all the filters Wei Zhao
2017-01-12 8:40 ` [dpdk-dev] [PATCH v4 11/18] net/ixgbe: parse n-tuple filter Wei Zhao
2017-01-12 8:40 ` [dpdk-dev] [PATCH v4 12/18] net/ixgbe: parse ethertype filter Wei Zhao
2017-01-12 8:40 ` [dpdk-dev] [PATCH v4 13/18] net/ixgbe: parse TCP SYN filter check if the rule is a TCP SYN rule, and get the SYN info Wei Zhao
2017-01-12 8:40 ` [dpdk-dev] [PATCH v4 14/18] net/ixgbe: parse L2 tunnel filter check if the rule is a L2 tunnel rule, and get the L2 tunnel info Wei Zhao
2017-01-12 8:40 ` [dpdk-dev] [PATCH v4 15/18] net/ixgbe: parse flow director filter Wei Zhao
2017-01-12 8:40 ` [dpdk-dev] [PATCH v4 16/18] net/ixgbe: create consistent filter Wei Zhao
2017-01-12 8:40 ` [dpdk-dev] [PATCH v4 17/18] net/ixgbe: destroy " Wei Zhao
2017-01-12 8:40 ` [dpdk-dev] [PATCH v4 18/18] net/ixgbe: flush all the filter list Wei Zhao
2017-01-12 9:17 ` [dpdk-dev] [PATCH v5 00/18] net/ixgbe: Consistent filter API Wei Zhao
2017-01-12 9:17 ` [dpdk-dev] [PATCH v5 01/18] net/ixgbe: store TCP SYN filter Wei Zhao
2017-01-12 9:17 ` [dpdk-dev] [PATCH v5 02/18] net/ixgbe: store flow director filter Wei Zhao
2017-01-12 9:17 ` [dpdk-dev] [PATCH v5 03/18] net/ixgbe: store L2 tunnel filter Wei Zhao
2017-01-12 9:17 ` [dpdk-dev] [PATCH v5 04/18] net/ixgbe: restore n-tuple filter Wei Zhao
2017-01-12 9:17 ` [dpdk-dev] [PATCH v5 05/18] net/ixgbe: restore ether type filter Wei Zhao
2017-01-12 9:17 ` [dpdk-dev] [PATCH v5 06/18] net/ixgbe: restore TCP SYN filter Wei Zhao
2017-01-12 9:17 ` [dpdk-dev] [PATCH v5 07/18] net/ixgbe: restore flow director filter Wei Zhao
2017-01-12 9:17 ` [dpdk-dev] [PATCH v5 08/18] net/ixgbe: restore L2 tunnel filter Wei Zhao
2017-01-12 9:17 ` [dpdk-dev] [PATCH v5 09/18] net/ixgbe: store and restore L2 tunnel configuration Wei Zhao
2017-01-12 9:17 ` [dpdk-dev] [PATCH v5 10/18] net/ixgbe: flush all the filters Wei Zhao
2017-01-12 9:17 ` [dpdk-dev] [PATCH v5 11/18] net/ixgbe: parse n-tuple filter Wei Zhao
2017-01-12 15:40 ` Ferruh Yigit
2017-01-12 9:17 ` [dpdk-dev] [PATCH v5 12/18] net/ixgbe: parse ethertype filter Wei Zhao
2017-01-12 15:39 ` Ferruh Yigit
2017-01-12 9:17 ` [dpdk-dev] [PATCH v5 13/18] net/ixgbe: parse TCP SYN filter Wei Zhao
2017-01-12 9:17 ` [dpdk-dev] [PATCH v5 14/18] net/ixgbe: parse L2 tunnel filter Wei Zhao
2017-01-12 9:17 ` [dpdk-dev] [PATCH v5 15/18] net/ixgbe: parse flow director filter Wei Zhao
2017-01-12 9:17 ` [dpdk-dev] [PATCH v5 16/18] net/ixgbe: create consistent filter Wei Zhao
2017-01-12 9:17 ` [dpdk-dev] [PATCH v5 17/18] net/ixgbe: destroy " Wei Zhao
2017-01-12 9:17 ` [dpdk-dev] [PATCH v5 18/18] net/ixgbe: flush all the filter list Wei Zhao
2017-01-12 11:38 ` [dpdk-dev] [PATCH v5 00/18] net/ixgbe: Consistent filter API Xing, Beilei
2017-01-13 6:27 ` Dai, Wei
2017-01-12 15:43 ` Ferruh Yigit
2017-01-13 8:12 ` [dpdk-dev] [PATCH v6 " Wei Zhao
2017-01-13 8:12 ` [dpdk-dev] [PATCH v6 01/18] net/ixgbe: store TCP SYN filter Wei Zhao
2017-01-13 8:12 ` [dpdk-dev] [PATCH v6 02/18] net/ixgbe: store flow director filter Wei Zhao
2017-01-13 8:12 ` [dpdk-dev] [PATCH v6 03/18] net/ixgbe: store L2 tunnel filter Wei Zhao
2017-01-13 8:12 ` [dpdk-dev] [PATCH v6 04/18] net/ixgbe: restore n-tuple filter Wei Zhao
2017-01-13 8:12 ` [dpdk-dev] [PATCH v6 05/18] net/ixgbe: restore ether type filter Wei Zhao
2017-01-13 8:13 ` [dpdk-dev] [PATCH v6 06/18] net/ixgbe: restore TCP SYN filter Wei Zhao
2017-01-13 8:13 ` [dpdk-dev] [PATCH v6 07/18] net/ixgbe: restore flow director filter Wei Zhao
2017-01-13 8:13 ` [dpdk-dev] [PATCH v6 08/18] net/ixgbe: restore L2 tunnel filter Wei Zhao
2017-01-13 8:13 ` [dpdk-dev] [PATCH v6 09/18] net/ixgbe: store and restore L2 tunnel configuration Wei Zhao
2017-01-13 8:13 ` [dpdk-dev] [PATCH v6 10/18] net/ixgbe: flush all the filters Wei Zhao
2017-01-13 8:13 ` [dpdk-dev] [PATCH v6 11/18] net/ixgbe: parse n-tuple filter Wei Zhao
2017-01-13 8:13 ` [dpdk-dev] [PATCH v6 12/18] net/ixgbe: parse ethertype filter Wei Zhao
2017-01-13 8:13 ` [dpdk-dev] [PATCH v6 13/18] net/ixgbe: parse TCP SYN filter Wei Zhao
2017-01-13 8:13 ` [dpdk-dev] [PATCH v6 14/18] net/ixgbe: parse L2 tunnel filter Wei Zhao
2017-01-13 11:18 ` Ferruh Yigit
2017-01-16 13:03 ` Adrien Mazarguil
2017-01-16 16:39 ` Ferruh Yigit
2017-01-16 18:26 ` Adrien Mazarguil
2017-01-17 9:27 ` Zhao1, Wei
2017-01-17 10:03 ` Ferruh Yigit
2017-01-18 1:59 ` Zhao1, Wei
2017-01-18 17:49 ` Ferruh Yigit
2017-01-25 12:17 ` Ferruh Yigit
2017-01-13 8:13 ` [dpdk-dev] [PATCH v6 15/18] net/ixgbe: parse flow director filter Wei Zhao
2017-01-13 8:13 ` [dpdk-dev] [PATCH v6 16/18] net/ixgbe: create consistent filter Wei Zhao
2017-01-13 8:13 ` [dpdk-dev] [PATCH v6 17/18] net/ixgbe: destroy " Wei Zhao
2017-01-13 8:13 ` [dpdk-dev] [PATCH v6 18/18] net/ixgbe: flush all the filter list Wei Zhao
2017-01-13 15:54 ` [dpdk-dev] [PATCH v6 00/18] net/ixgbe: Consistent filter API Ferruh Yigit
2017-01-15 2:44 ` Lu, Wenzhuo
2017-01-18 11:04 ` Thomas Monjalon
2016-12-30 7:52 ` [dpdk-dev] [PATCH v2 02/18] net/ixgbe: store flow director filter Wei Zhao
2017-01-02 9:59 ` Xing, Beilei [this message]
2017-01-03 3:14 ` Zhao1, Wei
2017-01-03 14:28 ` Dai, Wei
2017-01-04 2:03 ` Zhao1, Wei
2017-01-06 16:31 ` Ferruh Yigit
2017-01-10 5:30 ` Zhao1, Wei
2016-12-30 7:52 ` [dpdk-dev] [PATCH v2 03/18] net/ixgbe: store L2 tunnel filter Wei Zhao
2017-01-02 10:06 ` Xing, Beilei
2016-12-30 7:52 ` [dpdk-dev] [PATCH v2 04/18] net/ixgbe: restore n-tuple filter Wei Zhao
2016-12-30 7:52 ` [dpdk-dev] [PATCH v2 05/18] net/ixgbe: restore ether type filter Wei Zhao
2016-12-30 7:52 ` [dpdk-dev] [PATCH v2 06/18] net/ixgbe: restore TCP SYN filter Wei Zhao
2016-12-30 7:52 ` [dpdk-dev] [PATCH v2 07/18] net/ixgbe: restore flow director filter Wei Zhao
2016-12-30 7:53 ` [dpdk-dev] [PATCH v2 08/18] net/ixgbe: restore L2 tunnel filter Wei Zhao
2016-12-30 7:53 ` [dpdk-dev] [PATCH v2 09/18] net/ixgbe: store and restore L2 tunnel configuration Wei Zhao
2017-01-02 10:18 ` Xing, Beilei
2016-12-30 7:53 ` [dpdk-dev] [PATCH v2 10/18] net/ixgbe: flush all the filters Wei Zhao
2017-01-06 16:40 ` Ferruh Yigit
2017-01-11 7:51 ` Zhao1, Wei
2016-12-30 7:53 ` [dpdk-dev] [PATCH v2 11/18] net/ixgbe: parse n-tuple filter Wei Zhao
2017-01-02 10:41 ` Xing, Beilei
2017-01-02 10:45 ` Xing, Beilei
2017-01-06 16:55 ` Ferruh Yigit
2017-01-11 8:27 ` Zhao1, Wei
2016-12-30 7:53 ` [dpdk-dev] [PATCH v2 12/18] net/ixgbe: parse ethertype filter Wei Zhao
2017-01-06 17:11 ` Ferruh Yigit
2017-01-11 8:54 ` Zhao1, Wei
2016-12-30 7:53 ` [dpdk-dev] [PATCH v2 13/18] net/ixgbe: parse TCP SYN filter Wei Zhao
2017-01-06 17:19 ` Ferruh Yigit
2017-01-10 5:46 ` Zhao1, Wei
2017-01-11 9:11 ` Zhao1, Wei
2016-12-30 7:53 ` [dpdk-dev] [PATCH v2 14/18] net/ixgbe: parse L2 tunnel filter Wei Zhao
2017-01-03 14:07 ` Adrien Mazarguil
2017-01-05 3:12 ` Zhao1, Wei
2017-01-05 8:52 ` Adrien Mazarguil
2016-12-30 7:53 ` [dpdk-dev] [PATCH v2 15/18] net/ixgbe: parse flow director filter Wei Zhao
2017-01-02 15:24 ` Xing, Beilei
2017-01-03 3:05 ` Zhao1, Wei
2017-01-03 3:19 ` Zhao1, Wei
2017-01-03 14:08 ` Adrien Mazarguil
2016-12-30 7:53 ` [dpdk-dev] [PATCH v2 16/18] net/ixgbe: create consistent filter Wei Zhao
2017-01-03 2:04 ` Xing, Beilei
2017-01-03 3:11 ` Zhao1, Wei
[not found] ` <94479800C636CB44BD422CB454846E013158D036@SHSMSX101.ccr.corp.intel.com>
2017-01-03 3:09 ` Zhao1, Wei
2017-01-03 5:24 ` Xing, Beilei
2017-01-06 17:26 ` Ferruh Yigit
2017-01-10 5:50 ` Zhao1, Wei
2016-12-30 7:53 ` [dpdk-dev] [PATCH v2 17/18] net/ixgbe: destroy " Wei Zhao
2016-12-30 7:53 ` [dpdk-dev] [PATCH v2 18/18] net/ixgbe: flush all the filter list Wei Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94479800C636CB44BD422CB454846E013158CE0E@SHSMSX101.ccr.corp.intel.com \
--to=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=wei.zhao1@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).