From: "Xing, Beilei" <beilei.xing@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>
Cc: "Zhang, Helin" <helin.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 4/4] net/i40e: refine consistent tunnel filter
Date: Thu, 9 Mar 2017 06:11:38 +0000 [thread overview]
Message-ID: <94479800C636CB44BD422CB454846E01315A7D51@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <e3720374-17c0-c3e7-cd6d-4be55ccb480f@intel.com>
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Wednesday, March 8, 2017 11:51 PM
> To: Xing, Beilei <beilei.xing@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
> Cc: Zhang, Helin <helin.zhang@intel.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 4/4] net/i40e: refine consistent tunnel filter
>
> On 3/3/2017 9:31 AM, Beilei Xing wrote:
> > Add i40e_tunnel_type enumeration type to refine consistent tunnel
> > filter, it will be esay to add new tunnel type for
>
> s/esay/easy
>
> > i40e.
> >
> > Signed-off-by: Beilei Xing <beilei.xing@intel.com>
>
> <...>
>
> > /**
> > + * Tunnel type.
> > + */
> > +enum i40e_tunnel_type {
> > + I40E_TUNNEL_TYPE_NONE = 0,
> > + I40E_TUNNEL_TYPE_VXLAN,
> > + I40E_TUNNEL_TYPE_GENEVE,
> > + I40E_TUNNEL_TYPE_TEREDO,
> > + I40E_TUNNEL_TYPE_NVGRE,
> > + I40E_TUNNEL_TYPE_IP_IN_GRE,
> > + I40E_L2_TUNNEL_TYPE_E_TAG,
> > + I40E_TUNNEL_TYPE_MAX,
> > +};
>
> Same question here, there is already "rte_eth_tunnel_type", why driver is
> duplicating the structure?
>
Same with " struct i40e_tunnel_filter_conf ", to avoid ABI change, we create it in PMD to add new tunnel type easily, like MPLS.
> <...>
next prev parent reply other threads:[~2017-03-09 6:11 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 9:31 [dpdk-dev] [PATCH 0/4] support replace filter function Beilei Xing
2017-03-03 9:31 ` [dpdk-dev] [PATCH 1/4] net/i40e: support replace filter type Beilei Xing
2017-03-08 15:50 ` Ferruh Yigit
2017-03-09 5:59 ` Xing, Beilei
2017-03-09 10:01 ` Ferruh Yigit
2017-03-09 10:43 ` Xing, Beilei
2017-03-03 9:31 ` [dpdk-dev] [PATCH 2/4] net/i40e: rework tunnel filter functions Beilei Xing
2017-03-08 15:50 ` Ferruh Yigit
2017-03-09 6:00 ` Xing, Beilei
2017-03-03 9:31 ` [dpdk-dev] [PATCH 3/4] net/i40e: support tunnel filter to VF Beilei Xing
2017-03-08 15:50 ` Ferruh Yigit
2017-03-09 6:08 ` Xing, Beilei
2017-03-27 16:34 ` Ferruh Yigit
2017-03-03 9:31 ` [dpdk-dev] [PATCH 4/4] net/i40e: refine consistent tunnel filter Beilei Xing
2017-03-08 15:50 ` Ferruh Yigit
2017-03-09 6:11 ` Xing, Beilei [this message]
2017-03-08 15:50 ` [dpdk-dev] [PATCH 0/4] support replace filter function Ferruh Yigit
2017-03-09 5:13 ` Xing, Beilei
2017-03-23 10:46 ` [dpdk-dev] [PATCH v2 0/4] Rework tunnel filter functions Beilei Xing
2017-03-23 10:46 ` [dpdk-dev] [PATCH v2 1/4] net/i40e: rework " Beilei Xing
2017-03-27 9:47 ` Wu, Jingjing
2017-03-27 10:33 ` Xing, Beilei
2017-03-23 10:46 ` [dpdk-dev] [PATCH v2 2/4] net/i40e: change tunnel filter function name Beilei Xing
2017-03-23 10:46 ` [dpdk-dev] [PATCH v2 3/4] net/i40e: support tunnel filter to VF Beilei Xing
2017-03-27 9:54 ` Wu, Jingjing
2017-03-27 10:37 ` Xing, Beilei
2017-03-23 10:46 ` [dpdk-dev] [PATCH v2 4/4] net/i40e: refine consistent tunnel filter Beilei Xing
2017-03-28 3:23 ` [dpdk-dev] [PATCH v3 0/4] Rework tunnel filter functions Beilei Xing
2017-03-28 3:23 ` [dpdk-dev] [PATCH v3 1/4] net/i40e: rework " Beilei Xing
2017-03-28 3:23 ` [dpdk-dev] [PATCH v3 2/4] net/i40e: change tunnel filter function name Beilei Xing
2017-03-28 3:23 ` [dpdk-dev] [PATCH v3 3/4] net/i40e: support tunnel filter to VF Beilei Xing
2017-03-28 3:23 ` [dpdk-dev] [PATCH v3 4/4] net/i40e: refine consistent tunnel filter Beilei Xing
2017-03-28 9:28 ` [dpdk-dev] [PATCH v4 0/4] Rework tunnel filter functions Beilei Xing
2017-03-28 9:28 ` [dpdk-dev] [PATCH v4 1/4] net/i40e: rework " Beilei Xing
2017-03-28 9:28 ` [dpdk-dev] [PATCH v4 2/4] net/i40e: change tunnel filter function name Beilei Xing
2017-03-28 9:28 ` [dpdk-dev] [PATCH v4 3/4] net/i40e: support tunnel filter to VF Beilei Xing
2017-03-28 9:28 ` [dpdk-dev] [PATCH v4 4/4] net/i40e: refine consistent tunnel filter Beilei Xing
2017-03-29 13:23 ` [dpdk-dev] [PATCH v4 0/4] Rework tunnel filter functions Wu, Jingjing
2017-03-30 13:03 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94479800C636CB44BD422CB454846E01315A7D51@SHSMSX101.ccr.corp.intel.com \
--to=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=helin.zhang@intel.com \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).