From: "Xing, Beilei" <beilei.xing@intel.com>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>, "Zhang, Qi" <qi.zhang@intel.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: check port is stopped for QinQ setup
Date: Fri, 21 Apr 2017 01:37:32 +0000 [thread overview]
Message-ID: <94479800C636CB44BD422CB454846E01315E6B1D@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1492701258-7968-1-git-send-email-bernard.iremonger@intel.com>
Hi Bernard,
> -----Original Message-----
> From: Iremonger, Bernard
> Sent: Thursday, April 20, 2017 11:14 PM
> To: dev@dpdk.org; Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi
> <qi.zhang@intel.com>
> Cc: Iremonger, Bernard <bernard.iremonger@intel.com>
> Subject: [PATCH] app/testpmd: check port is stopped for QinQ setup
>
> Check port is stopped before configuring it for QinQ, with the "vlan set qinq
> on <port_id>" command.
>
> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
Acked-by: Beilei Xing <beilei.xing@intel.com>
Maybe it's better to introduce why stopping port is needed now in commit log.
next prev parent reply other threads:[~2017-04-21 1:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 15:14 Bernard Iremonger
2017-04-21 1:37 ` Xing, Beilei [this message]
2017-04-24 10:24 ` [dpdk-dev] [PATCH v2] " Bernard Iremonger
2017-04-25 8:55 ` Wu, Jingjing
2017-04-25 15:50 ` Iremonger, Bernard
2017-04-27 5:28 ` Wu, Jingjing
2017-04-27 8:11 ` Iremonger, Bernard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94479800C636CB44BD422CB454846E01315E6B1D@SHSMSX101.ccr.corp.intel.com \
--to=beilei.xing@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=qi.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).