From: "Xing, Beilei" <beilei.xing@intel.com>
To: "David Harton (dharton)" <dharton@cisco.com>,
David Harton <dharton@cpp-rtpbld-31.cpprtplab>,
"Wu, Jingjing" <jingjing.wu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] i40e: fix i40evf_add_mac_addr to permit multicast addresses
Date: Wed, 13 Sep 2017 02:43:22 +0000 [thread overview]
Message-ID: <94479800C636CB44BD422CB454846E013201C042@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <c252160aa1d643c4a2d938b47e816233@XCH-RCD-016.cisco.com>
> -----Original Message-----
> From: David Harton (dharton) [mailto:dharton@cisco.com]
> Sent: Wednesday, September 13, 2017 10:38 AM
> To: Xing, Beilei <beilei.xing@intel.com>; David Harton <dharton@cpp-rtpbld-
> 31.cpprtplab>; Wu, Jingjing <jingjing.wu@intel.com>
> Cc: dev@dpdk.org
> Subject: RE: [PATCH v2] i40e: fix i40evf_add_mac_addr to permit multicast
> addresses
>
> Hi Beilei,
>
> > -----Original Message-----
> > From: Xing, Beilei [mailto:beilei.xing@intel.com]
> >
> > Hi Harton,
> >
> > > -----Original Message-----
> > > From: David Harton [mailto:dharton@cpp-rtpbld-31.cpprtplab]
> > >
> > > From: David Harton <dharton@cisco.com>
> > >
> > > The i40e maintains a single MAC filter table for both unicast and
> > > multicast addresses. The i40e_validate_mac_addr function was
> > > preventing multicast addresses from being added to the table via
> > > i40evf_add_mac_addr. Fixed the issue by adjusting the check in
> > i40evf_add_mac_addr.
> > >
> > > Fixes: 4861cde46116 ("i40e: new poll mode driver")
> > > Fixes: 97ac72aa71a9 ("i40e: support setting VF MAC address")
> > >
> > > Signed-off-by: David Harton <dharton@cisco.com>
> > > ---
> > >
> > > v2
> > > * Removed multicast check in i40evf_add_mac_addr.
> > >
> > > v1
> > > * Removed multicast check in i40e_validate_mac_addr.
> > >
> > > drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
> > > b/drivers/net/i40e/i40e_ethdev_vf.c
> > > index f6d8293..5916d11 100644
> > > --- a/drivers/net/i40e/i40e_ethdev_vf.c
> > > +++ b/drivers/net/i40e/i40e_ethdev_vf.c
> > > @@ -888,7 +888,7 @@ i40evf_add_mac_addr(struct rte_eth_dev *dev,
> > > int err;
> > > struct vf_cmd_info args;
> > >
> > > - if (i40e_validate_mac_addr(addr->addr_bytes) != I40E_SUCCESS) {
> > > + if (is_zero_ether_addr(addr) != I40E_SUCCESS) {
> >
> > Thanks for the patch, there's some mistake with my last comment.
>
> Actually, I think the logic above works but I do agree it is confusing but I
> wanted to use your suggestion to speed up the process. :)
>
> > * @return
> > * True (1) if the given ethernet address is filled with zeros;
> > * false (0) otherwise.
> > */
> > According to the comment of is_zero_ether_addr function, return value
> > should be 0 or 1.
> > So you should use if (!is_zero_ether_addr(addr)) here.
>
> I don't think so. I think the logic that should be used is if
> (is_zero_ether_addr(addr)) { because we want to report an error if the addr
> is all 0's.
>
Yes, correct:)
> Please let me know if you agree and I'll post this patch instead.
>
> Thanks,
> Dave
>
> >
> > > PMD_DRV_LOG(ERR, "Invalid mac:%x:%x:%x:%x:%x:%x",
> > > addr->addr_bytes[0], addr->addr_bytes[1],
> > > addr->addr_bytes[2], addr->addr_bytes[3],
> > > --
> > > 2.10.3.dirty
next prev parent reply other threads:[~2017-09-13 2:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 22:21 [dpdk-dev] [PATCH] i40e: fix i40e_validate_mac_addr " David Harton
2017-08-31 15:53 ` Ferruh Yigit
2017-08-31 16:04 ` David Harton (dharton)
2017-09-08 12:51 ` David Harton (dharton)
2017-09-08 12:56 ` Ferruh Yigit
2017-09-11 5:41 ` Xing, Beilei
2017-09-11 17:22 ` David Harton (dharton)
2017-09-12 3:00 ` Xing, Beilei
2017-09-12 13:02 ` [dpdk-dev] [PATCH v2] i40e: fix i40evf_add_mac_addr " David Harton
2017-09-13 2:20 ` Xing, Beilei
2017-09-13 2:38 ` David Harton (dharton)
2017-09-13 2:43 ` Xing, Beilei [this message]
2017-09-13 3:21 ` [dpdk-dev] [PATCH v3] " David Harton
2017-09-13 3:42 ` Xing, Beilei
2017-09-14 18:55 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94479800C636CB44BD422CB454846E013201C042@SHSMSX101.ccr.corp.intel.com \
--to=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=dharton@cisco.com \
--cc=dharton@cpp-rtpbld-31.cpprtplab \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).