From: "Xing, Beilei" <beilei.xing@intel.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v2] net/i40e: fix memory leak if VF init fails
Date: Wed, 13 Sep 2017 03:22:37 +0000 [thread overview]
Message-ID: <94479800C636CB44BD422CB454846E013201C0E8@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1505244231-51364-1-git-send-email-jingjing.wu@intel.com>
> -----Original Message-----
> From: Wu, Jingjing
> Sent: Wednesday, September 13, 2017 3:24 AM
> To: Xing, Beilei <beilei.xing@intel.com>
> Cc: dev@dpdk.org; Wu, Jingjing <jingjing.wu@intel.com>; stable@dpdk.org
> Subject: [PATCH v2] net/i40e: fix memory leak if VF init fails
>
> Cc: stable@dpdk.org
> Fixes: 4861cde46116 ("i40e: new poll mode driver")
>
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
> ---
> v2 change:
> - free aq_resp at err_aq
>
> drivers/net/i40e/i40e_ethdev_vf.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
> b/drivers/net/i40e/i40e_ethdev_vf.c
> index f6d8293..1206af1 100644
> --- a/drivers/net/i40e/i40e_ethdev_vf.c
> +++ b/drivers/net/i40e/i40e_ethdev_vf.c
> @@ -1317,7 +1317,9 @@ i40evf_init_vf(struct rte_eth_dev *dev)
>
> err_alloc:
> rte_free(vf->vf_res);
> + vf->vsi_res = NULL;
> err_aq:
> + rte_free(vf->aq_resp);
Seems it's inappropriate to free aq_resp here, if reset NIC failed, vf->aq_resp is not allocated yet.
/* Reset VF and wait until it's complete */
if (i40evf_reset_vf(hw)) {
PMD_INIT_LOG(ERR, "reset NIC failed");
goto err_aq;
}
How about adding a new error branch?
> i40e_shutdown_adminq(hw); /* ignore error */
> err:
> return -1;
> --
> 2.7.4
next prev parent reply other threads:[~2017-09-13 3:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 19:20 [dpdk-stable] [PATCH] " Jingjing Wu
2017-09-12 19:23 ` [dpdk-stable] [PATCH v2] " Jingjing Wu
2017-09-12 23:54 ` [dpdk-stable] [PATCH v3] " Jingjing Wu
2017-09-14 1:44 ` Xing, Beilei
2017-09-14 18:46 ` Ferruh Yigit
2017-09-13 3:22 ` Xing, Beilei [this message]
2017-09-13 5:39 ` [dpdk-stable] [PATCH v2] " Wu, Jingjing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94479800C636CB44BD422CB454846E013201C0E8@SHSMSX101.ccr.corp.intel.com \
--to=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).