From: "Xing, Beilei" <beilei.xing@intel.com>
To: "Li, Xiaoyun" <xiaoyun.li@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] net/i40e: fix VF cannot forward packets issue
Date: Thu, 9 Nov 2017 08:33:38 +0000 [thread overview]
Message-ID: <94479800C636CB44BD422CB454846E0132068313@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1510209014-184925-1-git-send-email-xiaoyun.li@intel.com>
> -----Original Message-----
> From: Li, Xiaoyun
> Sent: Thursday, November 9, 2017 2:30 PM
> To: Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>
> Cc: dev@dpdk.org; Li, Xiaoyun <xiaoyun.li@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/i40e: fix VF cannot forward packets issue
>
> When Rx interrupt is not enabled, there is no need to check if interrupt allow
> others. It will cause VF cannot forwarding packets issue. This patch fixes this
> issue.
>
> Fixes: 96a9fd03c25f ("net/i40e: fix Rx queue interrupt mapping in VF")
> Cc: stable@dpdk.org
>
> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
> ---
> drivers/net/i40e/i40e_ethdev_vf.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
> b/drivers/net/i40e/i40e_ethdev_vf.c
> index 02d9e57..91b5bb0 100644
> --- a/drivers/net/i40e/i40e_ethdev_vf.c
> +++ b/drivers/net/i40e/i40e_ethdev_vf.c
> @@ -650,7 +650,8 @@ i40evf_config_irq_map(struct rte_eth_dev *dev)
> uint32_t vector_id;
> int i, err;
>
> - if (rte_intr_allow_others(intr_handle))
> + if (dev->data->dev_conf.intr_conf.rxq != 0 &&
> + rte_intr_allow_others(intr_handle))
> vector_id = I40E_RX_VEC_START;
> else
> vector_id = I40E_MISC_VEC_ID;
> --
> 2.7.4
Acked-by: Beilei Xing <beilei.xing@intel.com>
next prev parent reply other threads:[~2017-11-09 8:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 6:30 Xiaoyun Li
2017-11-09 8:33 ` Xing, Beilei [this message]
2017-11-10 2:15 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94479800C636CB44BD422CB454846E0132068313@SHSMSX101.ccr.corp.intel.com \
--to=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=stable@dpdk.org \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).