From: "Xing, Beilei" <beilei.xing@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Chilikin, Andrey" <andrey.chilikin@intel.com>
Subject: Re: [dpdk-dev] [PATCH v8 1/2] net/i40e: support input set configuration
Date: Wed, 10 Jan 2018 12:40:55 +0000 [thread overview]
Message-ID: <94479800C636CB44BD422CB454846E013208A266@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <fadc477c-0908-653a-1042-5ecf3282e967@intel.com>
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Wednesday, January 10, 2018 8:13 PM
> To: Xing, Beilei <beilei.xing@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhang, Qi
> Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; Chilikin, Andrey <andrey.chilikin@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v8 1/2] net/i40e: support input set
> configuration
>
> On 1/8/2018 3:09 AM, Beilei Xing wrote:
> > +static inline int
> > +rte_pmd_i40e_inset_field_clear(uint64_t *inset, uint8_t field_idx) {
> > + uint8_t bit_idx;
> > +
> > + if (field_idx > 63)
> > + return -1;
> > +
> > + bit_idx = 63 - field_idx;
> > + *inset = *inset & ~(1ULL << bit_idx);
> > +
> > + return 0;
> > +}
> > +
> > #endif /* _PMD_I40E_H_ */
> > diff --git a/drivers/net/i40e/rte_pmd_i40e_version.map
> > b/drivers/net/i40e/rte_pmd_i40e_version.map
> > index ebbd24e..0fafadd 100644
> > --- a/drivers/net/i40e/rte_pmd_i40e_version.map
> > +++ b/drivers/net/i40e/rte_pmd_i40e_version.map
> > @@ -58,3 +58,13 @@ DPDK_17.11 {
> > rte_pmd_i40e_rss_queue_region_conf;
> >
> > } DPDK_17.08;
> > +
> > +DPDK_18.02 {
> > + global:
> > +
> > + rte_pmd_i40e_inset_get;
> > + rte_pmd_i40e_inset_set;
> > + rte_pmd_i40e_inset_field_get;
> > + rte_pmd_i40e_inset_field_set;
> > + rte_pmd_i40e_inset_field_clear;
>
> I think we don't need static inline functions in linker script, do we?
Static inline functions are just used as helper functions, maybe we don't need them in linker script, I will send a new patch to delete it, thanks.
>
> > +} DPDK_17.11;
next prev parent reply other threads:[~2018-01-10 12:41 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-24 14:59 [dpdk-dev] [PATCH 0/2] " Beilei Xing
2017-11-24 14:59 ` [dpdk-dev] [PATCH 1/2] " Beilei Xing
2017-11-24 14:59 ` [dpdk-dev] [PATCH 2/2] app/testpmd: add configuration for input set Beilei Xing
2017-11-27 7:16 ` [dpdk-dev] [PATCH v2 0/2] net/i40e: support input set configuration Beilei Xing
2017-11-27 7:16 ` [dpdk-dev] [PATCH v2 1/2] " Beilei Xing
2017-11-27 7:16 ` [dpdk-dev] [PATCH v2 2/2] app/testpmd: add configuration for input set Beilei Xing
2017-11-29 9:43 ` [dpdk-dev] [PATCH v3 0/2] net/i40e: support input set configuration Beilei Xing
2017-11-29 9:43 ` [dpdk-dev] [PATCH v3 1/2] " Beilei Xing
2017-11-29 9:43 ` [dpdk-dev] [PATCH v3 2/2] app/testpmd: add configuration for input set Beilei Xing
2017-12-07 6:00 ` [dpdk-dev] [PATCH v4 0/2] net/i40e: support input set configuration Beilei Xing
2017-12-07 6:00 ` [dpdk-dev] [PATCH v4 1/2] " Beilei Xing
2017-12-07 6:00 ` [dpdk-dev] [PATCH v4 2/2] app/testpmd: add configuration for input set Beilei Xing
2017-12-07 8:43 ` [dpdk-dev] [PATCH v5 0/2] net/i40e: support input set configuration Beilei Xing
2017-12-07 8:43 ` [dpdk-dev] [PATCH v5 1/2] " Beilei Xing
2017-12-07 8:43 ` [dpdk-dev] [PATCH v5 2/2] app/testpmd: add configuration for input set Beilei Xing
2017-12-08 7:51 ` [dpdk-dev] [PATCH v6 0/2] net/i40e: support input set configuration Beilei Xing
2017-12-08 7:51 ` [dpdk-dev] [PATCH v6 1/2] " Beilei Xing
2018-01-02 12:48 ` Zhang, Qi Z
2017-12-08 7:51 ` [dpdk-dev] [PATCH v6 2/2] app/testpmd: add configuration for input set Beilei Xing
2018-01-04 6:51 ` Lu, Wenzhuo
2018-01-05 3:03 ` [dpdk-dev] [PATCH v7 0/2] support input set configuration Beilei Xing
2018-01-05 3:03 ` [dpdk-dev] [PATCH v7 1/2] net/i40e: " Beilei Xing
2018-01-05 3:03 ` [dpdk-dev] [PATCH v7 2/2] app/testpmd: add configuration for input set Beilei Xing
2018-01-08 3:09 ` [dpdk-dev] [PATCH v8 0/2] support input set configuration Beilei Xing
2018-01-08 3:09 ` [dpdk-dev] [PATCH v8 1/2] net/i40e: " Beilei Xing
2018-01-10 12:12 ` Ferruh Yigit
2018-01-10 12:40 ` Xing, Beilei [this message]
2018-01-08 3:09 ` [dpdk-dev] [PATCH v8 2/2] app/testpmd: add configuration for input set Beilei Xing
2018-01-08 3:18 ` Lu, Wenzhuo
2018-01-09 7:44 ` [dpdk-dev] [PATCH v8 0/2] support input set configuration Zhang, Helin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94479800C636CB44BD422CB454846E013208A266@SHSMSX101.ccr.corp.intel.com \
--to=beilei.xing@intel.com \
--cc=andrey.chilikin@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jingjing.wu@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).