From: Thomas Monjalon <thomas@monjalon.net>
To: Jia He <hejianet@gmail.com>
Cc: dev@dpdk.org, Jerin Jacob <jerin.jacob@caviumnetworks.com>,
Jianbo Liu <jianbo.liu@arm.com>,
Jan Viktorin <viktorin@rehivetech.com>,
Olivier Matz <olivier.matz@6wind.com>,
konstantin.ananyev@intel.com, hemant.agrawal@nxp.com,
Jia He <jia.he@hxt-semitech.com>
Subject: Re: [dpdk-dev] [PATCH V7 3/3] ring: introduce new header file to support C11 memory model
Date: Fri, 12 Jan 2018 18:18:14 +0100 [thread overview]
Message-ID: <94743066.En7L3yhnmx@xps> (raw)
In-Reply-To: <1512352212-7191-4-git-send-email-hejianet@gmail.com>
Hi,
Please find few comments.
Sorry for the late review.
We need also to get the acknowledgement from Olivier.
04/12/2017 02:50, Jia He:
> --- a/config/common_armv8a_linuxapp
> +++ b/config/common_armv8a_linuxapp
> @@ -49,3 +49,5 @@ CONFIG_RTE_LIBRTE_SFC_EFX_PMD=n
> CONFIG_RTE_LIBRTE_AVP_PMD=n
>
> CONFIG_RTE_SCHED_VECTOR=n
> +
> +CONFIG_RTE_RING_USE_C11_MEM_MODEL=y
This config option should be added in the common file (as disabled).
> --- /dev/null
> +++ b/lib/librte_ring/rte_ring_c11_mem.h
> @@ -0,0 +1,186 @@
> +/*-
> + * BSD LICENSE
> + *
> + * Copyright(c) 2017 hxt-semitech. All rights reserved.
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions
> + * are met:
> + *
> + * * Redistributions of source code must retain the above copyright
> + * notice, this list of conditions and the following disclaimer.
> + * * Redistributions in binary form must reproduce the above copyright
> + * notice, this list of conditions and the following disclaimer in
> + * the documentation and/or other materials provided with the
> + * distribution.
> + * * Neither the name of hxt-semitech nor the names of its
> + * contributors may be used to endorse or promote products derived
> + * from this software without specific prior written permission.
> + *
> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
> + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
> + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
> + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
> + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
> + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
> + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> + */
If you have to spin a v8, please use SPDX tag for the license.
next prev parent reply other threads:[~2018-01-12 17:18 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1510118764-29697-1-git-send-email-hejianet@gmail.com>
2017-11-08 9:54 ` [dpdk-dev] [PATCH v4 0/4] fix race condition in enqueue/dequeue because of cpu reorder Jia He
2017-11-08 9:54 ` [dpdk-dev] [PATCH v4 1/4] eal/arm64: remove the braces {} for dmb() and dsb() Jia He
2017-11-08 9:54 ` [dpdk-dev] [PATCH v4 2/4] ring: guarantee load/load order in enqueue and dequeue Jia He
2017-11-08 9:54 ` [dpdk-dev] [PATCH v4 3/4] ring: introduce new header file to include common functions Jia He
2017-11-08 9:54 ` [dpdk-dev] [PATCH v4 4/4] ring: introduce new header file to support C11 memory model Jia He
2017-11-08 12:15 ` [dpdk-dev] [PATCH v4 0/4] fix race condition in enqueue/dequeue because of cpu reorder Bruce Richardson
2017-11-08 15:11 ` Jia He
2017-11-08 16:29 ` Jerin Jacob
2017-11-08 18:36 ` Ananyev, Konstantin
[not found] ` <2459a535-920e-9ac5-2f46-1d1dd00e275b@gmail.com>
2017-11-24 9:24 ` Bruce Richardson
2017-11-10 1:51 ` [dpdk-dev] [PATCH v5 0/1] " Jia He
2017-11-10 1:51 ` [dpdk-dev] [PATCH v5 1/1] ring: guarantee load/load order in enqueue and dequeue Jia He
2017-11-10 2:46 ` Jerin Jacob
2017-11-10 3:12 ` Jianbo Liu
2017-11-10 9:59 ` Ananyev, Konstantin
2017-11-10 3:30 ` [dpdk-dev] [PATCH v6] " Jia He
2017-11-10 3:30 ` [dpdk-dev] [PATCH v6] ring: " Jia He
2017-11-12 17:51 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2017-11-10 5:23 ` [dpdk-dev] [PATCH v5 0/3] support c11 memory model barrier in librte_ring Jia He
2017-11-10 5:23 ` [dpdk-dev] [PATCH v5 1/3] eal/arm64: remove the braces {} for dmb() and dsb() Jia He
2017-11-10 5:23 ` [dpdk-dev] [PATCH v5 2/3] ring: introduce new header file to include common functions Jia He
2017-11-10 5:23 ` [dpdk-dev] [PATCH v6 3/3] ring: introduce new header file to support C11 memory model Jia He
2017-11-27 2:00 ` [dpdk-dev] [PATCH V6 0/3] support c11 memory model barrier in librte_ring Jia He
2017-11-27 2:00 ` [dpdk-dev] [PATCH V6 1/3] eal/arm64: remove the braces {} for dmb() and dsb() Jia He
2017-12-03 11:11 ` Jerin Jacob
2017-11-27 2:00 ` [dpdk-dev] [PATCH V6 2/3] ring: introduce new header file to include common functions Jia He
2017-12-03 12:13 ` Jerin Jacob
2017-11-27 2:00 ` [dpdk-dev] [PATCH V6 3/3] ring: introduce new header file to support C11 memory model Jia He
2017-12-03 12:14 ` Jerin Jacob
2017-12-04 1:50 ` [dpdk-dev] [PATCH V7 0/3] support c11 memory model barrier in librte_ring Jia He
2017-12-04 1:50 ` [dpdk-dev] [PATCH V7 1/3] eal/arm64: remove the braces {} for dmb() and dsb() Jia He
2017-12-04 1:50 ` [dpdk-dev] [PATCH V7 2/3] ring: introduce new header file to include common functions Jia He
2018-01-12 17:09 ` Thomas Monjalon
2018-01-16 2:06 ` Jia He
2018-01-16 15:19 ` Olivier Matz
2017-12-04 1:50 ` [dpdk-dev] [PATCH V7 3/3] ring: introduce new header file to support C11 memory model Jia He
2017-12-04 8:05 ` Jianbo Liu
2018-01-12 17:18 ` Thomas Monjalon [this message]
2018-01-16 15:18 ` Olivier Matz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94743066.En7L3yhnmx@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=hejianet@gmail.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=jia.he@hxt-semitech.com \
--cc=jianbo.liu@arm.com \
--cc=konstantin.ananyev@intel.com \
--cc=olivier.matz@6wind.com \
--cc=viktorin@rehivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).