From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Min Hu (Connor)" <humin29@huawei.com>, dev@dpdk.org
Cc: xiaoyun.li@intel.com,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Qi Zhang <qi.z.zhang@intel.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix bitmap of link speeds when force speed
Date: Tue, 13 Apr 2021 18:08:45 +0100 [thread overview]
Message-ID: <94a40608-6d33-3d24-f6ab-86424a50eab1@intel.com> (raw)
In-Reply-To: <1617877348-16394-1-git-send-email-humin29@huawei.com>
On 4/8/2021 11:22 AM, Min Hu (Connor) wrote:
> From: Huisong Li <lihuisong@huawei.com>
>
> Currently, when the user sets force link speed through 'link_speeds',
> bit(0) of 'link_speeds' is not set to 1(ETH_LINK_SPEED_FIXED),
> which conflicts with the definition.
>
> Fixes: 88fbedcd5e5a ("app/testpmd: move speed and duplex parsing in a function")
> Cc: stable@dpdk.org
>
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> ---
> app/test-pmd/cmdline.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index f44116b..8c36de2 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -1523,6 +1523,9 @@ parse_and_check_speed_duplex(char *speedstr, char *duplexstr, uint32_t *speed)
> printf("Unknown speed parameter\n");
> return -1;
> }
> +
> + if (*speed != ETH_LINK_SPEED_AUTONEG)
> + *speed |= ETH_LINK_SPEED_FIXED;
> }
>
> return 0;
>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
This has a history, same patch has been done in the past by Andrew [1], later
reverted [2] (by me) since some PMDs failed and we were close to release.
In recent discussion [3] already agreed to get the patch again before -rc1, and
this time there will be time to fix failing PMDs.
Thanks for making the patch.
[1] Commit bdca79053b6a ("app/testpmd: set fixed flag for exact link speed")
[2] Commit f53cc91f412a ("app/testpmd: revert fixed flag for exact link speed")
[3] http://inbox.dpdk.org/dev/43d67012-7f6f-2de8-e5ee-50cbe025d3eb@intel.com/#t
next prev parent reply other threads:[~2021-04-13 17:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 10:22 Min Hu (Connor)
2021-04-13 17:08 ` Ferruh Yigit [this message]
2021-04-13 17:10 ` Ajit Khaparde
2021-04-14 3:02 ` [dpdk-dev] [PATCH v2] " Min Hu (Connor)
2021-04-14 11:55 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94a40608-6d33-3d24-f6ab-86424a50eab1@intel.com \
--to=ferruh.yigit@intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=humin29@huawei.com \
--cc=qi.z.zhang@intel.com \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).