From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Jie Hai <haijie1@huawei.com>,
Thomas Monjalon <thomas@monjalon.net>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: dev@dpdk.org, liudongdong3@huawei.com
Subject: Re: [PATCH v2 11/13] ethdev: support telemetry query RSS info
Date: Wed, 7 Jun 2023 15:08:06 +0100 [thread overview]
Message-ID: <94c71918-31bf-9564-8c55-4404d2813abc@amd.com> (raw)
In-Reply-To: <20230607074209.4798-12-haijie1@huawei.com>
On 6/7/2023 8:42 AM, Jie Hai wrote:
> This patch supports querying RSS info by telemetry command.
> The command is like:
> --> /ethdev/rss_info,0
> {
> "/ethdev/rss_info": {
> "rss_hf": "0x238c",
> "rss_key_len": 40,
> "rss_key": "6d5a56da255b0ec24167253d43a38fb0d0ca2b\
> cbae7b30b477cb2da38030f20c6a42b73bbeac01fa"
> }
> }
>
> Signed-off-by: Jie Hai <haijie1@huawei.com>
> ---
> lib/ethdev/rte_ethdev_telemetry.c | 79 +++++++++++++++++++++++++++++++
> 1 file changed, 79 insertions(+)
>
> diff --git a/lib/ethdev/rte_ethdev_telemetry.c b/lib/ethdev/rte_ethdev_telemetry.c
> index d0d55993102b..d42901fe57b1 100644
> --- a/lib/ethdev/rte_ethdev_telemetry.c
> +++ b/lib/ethdev/rte_ethdev_telemetry.c
> @@ -706,6 +706,83 @@ eth_dev_handle_port_dcb(const char *cmd __rte_unused,
> return eth_dev_add_dcb_info(port_id, d);
> }
>
> +static int
> +eth_dev_add_rss_info(struct rte_eth_rss_conf *rss_conf, struct rte_tel_data *d)
> +{
> + const uint32_t key_len = rss_conf->rss_key_len * 2 + 1;
> + char *rss_key;
> + char *key;
> + uint32_t i;
> + int ret;
> +
> + key = malloc(key_len);
> + if (key == NULL)
> + return -ENOMEM;
> +
Key is to hold only char representation of single byte, so it doesn't
need this much space and no need to dynamically allocate/free small
space, hence updating in next-net as following:
```
diff --git a/lib/ethdev/rte_ethdev_telemetry.c
b/lib/ethdev/rte_ethdev_telemetry.c
index c64045cb1dad..f246a03e2966 100644
--- a/lib/ethdev/rte_ethdev_telemetry.c
+++ b/lib/ethdev/rte_ethdev_telemetry.c
@@ -723,19 +723,13 @@ eth_dev_add_rss_info(struct rte_eth_rss_conf
*rss_conf, struct rte_tel_data *d)
{
const uint32_t key_len = rss_conf->rss_key_len * 2 + 1;
char *rss_key;
- char *key;
+ char key[3]; /* FF\0 */
uint32_t i;
int ret;
- key = malloc(key_len);
- if (key == NULL)
- return -ENOMEM;
-
rss_key = malloc(key_len);
- if (rss_key == NULL) {
- ret = -ENOMEM;
- goto free_key;
- }
+ if (rss_key == NULL)
+ return -ENOMEM;
rte_tel_data_start_dict(d);
rte_tel_data_add_dict_uint_hex(d, "rss_hf", rss_conf->rss_hf, 0);
@@ -743,7 +737,7 @@ eth_dev_add_rss_info(struct rte_eth_rss_conf
*rss_conf, struct rte_tel_data *d)
memset(rss_key, 0, key_len);
for (i = 0; i < rss_conf->rss_key_len; i++) {
- ret = snprintf(key, key_len, "%02x",
rss_conf->rss_key[i]);
+ ret = snprintf(key, 3, "%02x", rss_conf->rss_key[i]);
if (ret < 0)
goto free_rss_key;
strlcat(rss_key, key, key_len);
@@ -752,8 +746,7 @@ eth_dev_add_rss_info(struct rte_eth_rss_conf
*rss_conf, struct rte_tel_data *d)
free_rss_key:
free(rss_key);
-free_key:
- free(key);
+
return ret;
}
```
> + rss_key = malloc(key_len);
> + if (rss_key == NULL) {
> + ret = -ENOMEM;
> + goto free_key;
> + }
> +
> + rte_tel_data_start_dict(d);
> + rte_tel_data_add_dict_uint_hex(d, "rss_hf", rss_conf->rss_hf, 0);
> + rte_tel_data_add_dict_uint(d, "rss_key_len", rss_conf->rss_key_len);
> +
> + memset(rss_key, 0, key_len);
> + for (i = 0; i < rss_conf->rss_key_len; i++) {
> + ret = snprintf(key, key_len, "%02x", rss_conf->rss_key[i]);
> + if (ret < 0)
> + goto free_rss_key;
> + strlcat(rss_key, key, key_len);
> + }
> + ret = rte_tel_data_add_dict_string(d, "rss_key", rss_key);
> +
> +free_rss_key:
> + free(rss_key);
> +free_key:
> + free(key);
> + return ret;
> +}
> +
> +static int
> +eth_dev_handle_port_rss_info(const char *cmd __rte_unused,
> + const char *params,
> + struct rte_tel_data *d)
> +{
> + struct rte_eth_dev_info dev_info;
> + struct rte_eth_rss_conf rss_conf;
> + uint16_t port_id;
> + char *end_param;
> + int ret;
> +
> + ret = eth_dev_parse_port_params(params, &port_id, &end_param, false);
> + if (ret < 0)
> + return ret;
> +
> + ret = rte_eth_dev_info_get(port_id, &dev_info);
> + if (ret != 0) {
> + RTE_ETHDEV_LOG(ERR,
> + "Failed to get device info, ret = %d\n", ret);
> + return ret;
> + }
> +
> + rss_conf.rss_key_len = dev_info.hash_key_size;
> + rss_conf.rss_key = malloc(dev_info.hash_key_size);
> + if (rss_conf.rss_key == NULL)
> + return -ENOMEM;
> +
This patch cause telemetry unit test failure, because some pmd's provide
'0' as 'dev_info.hash_key_size', hence updating as following which sets
key size as 40 if 'dev_info.hash_key_size' is 0:
```
@@ -764,6 +757,7 @@ eth_dev_handle_port_rss_info(const char *cmd
__rte_unused,
{
struct rte_eth_dev_info dev_info;
struct rte_eth_rss_conf rss_conf;
+ uint8_t key_len;
uint16_t port_id;
char *end_param;
int ret;
@@ -779,8 +773,9 @@ eth_dev_handle_port_rss_info(const char *cmd
__rte_unused,
return ret;
}
- rss_conf.rss_key_len = dev_info.hash_key_size;
- rss_conf.rss_key = malloc(dev_info.hash_key_size);
+ key_len = dev_info.hash_key_size ? dev_info.hash_key_size : 40;
+ rss_conf.rss_key_len = key_len;
+ rss_conf.rss_key = malloc(key_len);
if (rss_conf.rss_key == NULL)
return -ENOMEM;
```
> + ret = rte_eth_dev_rss_hash_conf_get(port_id, &rss_conf);
> + if (ret != 0) {
> + free(rss_conf.rss_key);
> + return ret;
> + }
> +
> + ret = eth_dev_add_rss_info(&rss_conf, d);
> + free(rss_conf.rss_key);
> + return ret;
> +}
> +
> RTE_INIT(ethdev_init_telemetry)
> {
> rte_telemetry_register_cmd("/ethdev/list", eth_dev_handle_port_list,
> @@ -735,4 +812,6 @@ RTE_INIT(ethdev_init_telemetry)
> "Returns Tx queue info for a port. Parameters: int port_id, int queue_id (Optional if only one queue)");
> rte_telemetry_register_cmd("/ethdev/dcb", eth_dev_handle_port_dcb,
> "Returns DCB info for a port. Parameters: int port_id");
> + rte_telemetry_register_cmd("/ethdev/rss_info", eth_dev_handle_port_rss_info,
> + "Returns RSS info for a port. Parameters: int port_id");
> }
next prev parent reply other threads:[~2023-06-07 14:08 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 9:05 [PATCH 00/10] support telemetry query ethdev info Jie Hai
2023-05-30 9:05 ` [PATCH 01/10] ethdev: support telemetry query MAC addresses Jie Hai
2023-06-01 14:39 ` Ferruh Yigit
2023-05-30 9:05 ` [PATCH 02/10] ethdev: support RxTx offload display Jie Hai
2023-05-30 9:05 ` [PATCH 03/10] ethdev: support telemetry query flow ctrl info Jie Hai
2023-05-30 9:05 ` [PATCH 04/10] ethdev: support telemetry query Rx queue info Jie Hai
2023-05-30 9:05 ` [PATCH 05/10] ethdev: support telemetry query Tx " Jie Hai
2023-05-30 9:05 ` [PATCH 06/10] ethdev: add firmware version in telemetry info command Jie Hai
2023-05-30 9:05 ` [PATCH 07/10] ethdev: support telemetry query DCB info Jie Hai
2023-05-30 9:05 ` [PATCH 08/10] ethdev: support telemetry query RSS info Jie Hai
2023-05-30 9:05 ` [PATCH 09/10] ethdev: support telemetry query FEC info Jie Hai
2023-05-30 9:05 ` [PATCH 10/10] ethdev: support telemetry query VLAN info Jie Hai
2023-06-01 12:05 ` [PATCH 00/10] support telemetry query ethdev info Ferruh Yigit
2023-06-01 12:23 ` Jie Hai
2023-06-01 14:36 ` Ferruh Yigit
2023-06-05 6:19 ` Jie Hai
2023-06-07 7:41 ` [PATCH v2 00/13] " Jie Hai
2023-06-07 7:41 ` [PATCH v2 01/13] ethdev: fix incorrect argument of calloc Jie Hai
2023-06-07 11:35 ` Ferruh Yigit
2023-06-07 7:41 ` [PATCH v2 02/13] ethdev: extract telemetry codes to a file Jie Hai
2023-06-07 11:37 ` Ferruh Yigit
2023-06-07 7:41 ` [PATCH v2 03/13] ethdev: extract codes parsing port ID as a function Jie Hai
2023-06-07 11:37 ` Ferruh Yigit
2023-06-07 7:41 ` [PATCH v2 04/13] ethdev: support telemetry query MAC addresses Jie Hai
2023-06-07 7:42 ` [PATCH v2 05/13] ethdev: support RxTx offload display Jie Hai
2023-06-07 7:42 ` [PATCH v2 06/13] ethdev: support telemetry query flow ctrl info Jie Hai
2023-06-07 7:42 ` [PATCH v2 07/13] ethdev: support telemetry query Rx queue info Jie Hai
2023-06-07 7:42 ` [PATCH v2 08/13] ethdev: support telemetry query Tx " Jie Hai
2023-06-07 7:42 ` [PATCH v2 09/13] ethdev: add firmware version in telemetry info command Jie Hai
2023-06-07 7:42 ` [PATCH v2 10/13] ethdev: support telemetry query DCB info Jie Hai
2023-06-07 7:42 ` [PATCH v2 11/13] ethdev: support telemetry query RSS info Jie Hai
2023-06-07 14:08 ` Ferruh Yigit [this message]
2023-06-07 7:42 ` [PATCH v2 12/13] ethdev: support telemetry query FEC info Jie Hai
2023-06-07 7:42 ` [PATCH v2 13/13] ethdev: support telemetry query VLAN info Jie Hai
2023-06-07 11:40 ` [PATCH v2 00/13] support telemetry query ethdev info Ferruh Yigit
2023-06-08 2:01 ` Jie Hai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94c71918-31bf-9564-8c55-4404d2813abc@amd.com \
--to=ferruh.yigit@amd.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=haijie1@huawei.com \
--cc=liudongdong3@huawei.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).