From: Remy Horton <remy.horton@intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
David Marchand <david.marchand@6wind.com>,
dev@dpdk.org
Cc: wenzhuo.lu@intel.com, jingjing.wu@intel.com,
bernard.iremonger@intel.com, stable@dpdk.org,
Harry Van Haaren <harry.van.haaren@intel.com>
Subject: Re: [dpdk-stable] [PATCH] app/testpmd: add sanity checks when retrieving xstats
Date: Thu, 14 Jun 2018 07:39:47 +0100 [thread overview]
Message-ID: <94ff9382-dbcd-1afd-b149-349653e1222e@intel.com> (raw)
In-Reply-To: <fc9eab97-5051-d37d-a548-d46fe6f24cda@intel.com>
On 13/06/2018 16:39, Ferruh Yigit wrote:
> On 6/7/2018 9:15 AM, David Marchand wrote:
>> Testpmd should not expect the xstats names and values arrays to be
>> aligned: neither the arrays sizes, nor the order in which the values are.
>
> As far as I can see this assumption is everywhere in API implementation:
> xstats names and values are aligned with same order.
> The basic stat part of the xstats, implemented in ethdev layer, seems relying on
> same assumption. Also looks like "xstat size" and "xstat_names size" used
> interchangeably.
>
> And I don't see any case that mentions xstats.id is xstats_name index.
> cc'ed Harry, to get more information about initial intention.
>
> the id value in xstats struct looks like duplication, but other than that, is
> there any downside of using array index to mach name, value pair?
> And do we really need another layer of indirection (and complexity) to mach
> simple name,value key pair in xstats?
When I was working on xstats one of my intentions was to allow PMDs to
only return a subset of values for all the keys they declare, with
xstats[idx].id==idx just being a coincidence that was not to be relied
on. Since then there appears to have been several instances of rework,
so no idea if this coincidence becoming an assumption was intentional or
an oversight.
..Remy
next prev parent reply other threads:[~2018-06-14 6:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 8:15 David Marchand
2018-06-12 7:09 ` David Marchand
2018-06-12 8:38 ` Remy Horton
2018-06-13 15:39 ` Ferruh Yigit
2018-06-14 6:39 ` Remy Horton [this message]
2018-06-14 10:55 ` Ferruh Yigit
2018-06-14 19:33 ` Remy Horton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94ff9382-dbcd-1afd-b149-349653e1222e@intel.com \
--to=remy.horton@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=harry.van.haaren@intel.com \
--cc=jingjing.wu@intel.com \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).