DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Konstantin Ananyev <konstantin.ananyev@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 3/3] ACL: remove subtree_id calculations at build stage
Date: Tue, 02 Jun 2015 22:56:40 +0200	[thread overview]
Message-ID: <9555737.ZoAvHCuAuV@xps13> (raw)
In-Reply-To: <1432316931-18406-4-git-send-email-konstantin.ananyev@intel.com>

2015-05-22 18:48, Konstantin Ananyev:
> As now subtree_id is not used acl_merge_trie() any more,
> there is no point to calculate and maintain that information.
> 
> Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

There is an error with GCC 5.1:

lib/librte_acl/acl_bld.c:1324:22: error: array subscript is above array bounds [-Werror=array-bounds]
     end->mrt->results[m] = rule->f->data.userdata;
                      ^
lib/librte_acl/acl_bld.c:1327:22: error: array subscript is above array bounds [-Werror=array-bounds]
     end->mrt->results[m] = 0;
                      ^

This kind of patch fixes it:
-               for (m = 0; m < context->cfg.num_categories; m++) {
+               for (m = 0; m < RTE_MIN(context->cfg.num_categories, RTE_DIM(end->mrt->results)); m++) {

      reply	other threads:[~2015-06-02 20:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-22 17:48 [dpdk-dev] [PATCH 0/3] ACL: Fix bug in acl_merge_trie() and add a new test-case for it to the UT Konstantin Ananyev
2015-05-22 17:48 ` [dpdk-dev] [PATCH 1/3] ACL: fix a problem in acl_merge_trie Konstantin Ananyev
2015-05-22 17:48 ` [dpdk-dev] [PATCH 2/3] ACL: add new test case for ranges build Konstantin Ananyev
2015-05-22 17:48 ` [dpdk-dev] [PATCH 3/3] ACL: remove subtree_id calculations at build stage Konstantin Ananyev
2015-06-02 20:56   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9555737.ZoAvHCuAuV@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).