DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Xiaoyun wang <cloud.wangxiaoyun@huawei.com>
Cc: dev@dpdk.org, xuanziyang2@huawei.com, shahar.belkar@huawei.com,
	luoxianjun@huawei.com, tanya.brokhman@huawei.com,
	zhouguoyang@huawei.com, wulike1@huawei.com
Subject: Re: [dpdk-dev] [PATCH v2 12/17] net/hinic: set link down and up
Date: Thu, 26 Sep 2019 19:47:38 +0100	[thread overview]
Message-ID: <9559f32e-2a6e-b786-4224-d65adc9df1a7@intel.com> (raw)
In-Reply-To: <a2a857f313b1fe89acf5ad16e22c085f20086df0.1569421287.git.cloud.wangxiaoyun@huawei.com>

On 9/25/2019 3:30 PM, Xiaoyun wang wrote:
> This patch supports setting link down and up,
> Also adds support for geting firmware version.
> 
> Signed-off-by: Xiaoyun wang <cloud.wangxiaoyun@huawei.com>

<...>

> @@ -2751,9 +2832,12 @@ static void hinic_dev_close(struct rte_eth_dev *dev)
>  static const struct eth_dev_ops hinic_pmd_ops = {
>  	.dev_configure                 = hinic_dev_configure,
>  	.dev_infos_get                 = hinic_dev_infos_get,
> +	.fw_version_get                = hinic_fw_version_get,
>  	.rx_queue_setup                = hinic_rx_queue_setup,
>  	.tx_queue_setup                = hinic_tx_queue_setup,
>  	.dev_start                     = hinic_dev_start,
> +	.dev_set_link_up               = hinic_dev_set_link_up,
> +	.dev_set_link_down             = hinic_dev_set_link_down,
>  	.link_update                   = hinic_link_update,
>  	.rx_queue_release              = hinic_rx_queue_release,
>  	.tx_queue_release              = hinic_tx_queue_release,
> @@ -2785,6 +2869,7 @@ static void hinic_dev_close(struct rte_eth_dev *dev)
>  static const struct eth_dev_ops hinic_pmd_vf_ops = {
>  	.dev_configure                 = hinic_dev_configure,
>  	.dev_infos_get                 = hinic_dev_infos_get,
> +	.fw_version_get                = hinic_fw_version_get,
>  	.rx_queue_setup                = hinic_rx_queue_setup,
>  	.tx_queue_setup                = hinic_tx_queue_setup,
>  	.dev_start                     = hinic_dev_start,
> 

Patch is also updating fw version get support, can you please mention from it in
the commit log? Or separate the patch..

  reply	other threads:[~2019-09-26 18:47 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-25 14:26 [dpdk-dev] [PATCH v2 00/17] Add advanced features for Huawei hinic pmd Xiaoyun wang
2019-09-25 14:30 ` Xiaoyun wang
2019-09-25 14:30 ` [dpdk-dev] [PATCH v2 01/17] net/hinic/base: add mbox command channel for SRIOV Xiaoyun wang
2019-09-25 14:30 ` [dpdk-dev] [PATCH v2 02/17] net/hinic/base: add HW interfaces " Xiaoyun wang
2019-09-25 14:30 ` [dpdk-dev] [PATCH v2 03/17] net/hinic: add VF PMD operation interfaces Xiaoyun wang
2019-09-25 14:30 ` [dpdk-dev] [PATCH v2 04/17] net/hinic: add VLAN filter and offload Xiaoyun wang
2019-09-25 14:30 ` [dpdk-dev] [PATCH v2 05/17] net/hinic: add allmulticast mode and MTU set Xiaoyun wang
2019-09-26 18:47   ` Ferruh Yigit
2019-09-30  8:43     ` Wangxiaoyun (Cloud, Network Chip Application Development Dept)
2019-09-25 14:30 ` [dpdk-dev] [PATCH v2 06/17] net/hinic: add unicast and multicast MAC set Xiaoyun wang
2019-09-25 14:30 ` [dpdk-dev] [PATCH v2 07/17] net/hinic: add fdir config interface Xiaoyun wang
2019-09-26 18:48   ` Ferruh Yigit
2019-09-30 14:08     ` Wangxiaoyun (Cloud, Network Chip Application Development Dept)
2019-09-25 14:30 ` [dpdk-dev] [PATCH v2 08/17] net/hinic: add fdir validate flow operations Xiaoyun wang
2019-09-25 14:30 ` [dpdk-dev] [PATCH v2 09/17] net/hinic: create and destroy ntuple filter Xiaoyun wang
2019-09-25 14:30 ` [dpdk-dev] [PATCH v2 10/17] net/hinic: create and destroy fdir filter Xiaoyun wang
2019-09-25 14:30 ` [dpdk-dev] [PATCH v2 11/17] net/hinic: flush " Xiaoyun wang
2019-09-25 14:30 ` [dpdk-dev] [PATCH v2 12/17] net/hinic: set link down and up Xiaoyun wang
2019-09-26 18:47   ` Ferruh Yigit [this message]
2019-09-28  8:59     ` [dpdk-dev] 答复: " Wangxiaoyun (Cloud, Network Chip Application Development Dept)
2019-09-30  8:39     ` [dpdk-dev] " Wangxiaoyun (Cloud, Network Chip Application Development Dept)
2019-09-25 14:30 ` [dpdk-dev] [PATCH v2 13/17] net/hinic: support inner L3 checksum offload Xiaoyun wang
2019-09-25 14:30 ` [dpdk-dev] [PATCH v2 14/17] net/hinic: support LRO offload Xiaoyun wang
2019-09-25 14:30 ` [dpdk-dev] [PATCH v2 15/17] net/hinic: add hinic PMD doc files Xiaoyun wang
2019-09-26 18:51   ` Ferruh Yigit
2019-09-30 14:15     ` Wangxiaoyun (Cloud, Network Chip Application Development Dept)
2019-09-25 14:30 ` [dpdk-dev] [PATCH v2 16/17] net/hinic/base: optimize aeq interfaces Xiaoyun wang
2019-09-25 14:30 ` [dpdk-dev] [PATCH v2 17/17] net/hinic: optimize tx&rx performance Xiaoyun wang
2019-09-27  2:08   ` Gavin Hu (Arm Technology China)
2019-09-30 14:41     ` Wangxiaoyun (Cloud, Network Chip Application Development Dept)
2019-09-26 18:51 ` [dpdk-dev] [PATCH v2 00/17] Add advanced features for Huawei hinic pmd Ferruh Yigit
2019-09-30 14:19   ` Wangxiaoyun (Cloud, Network Chip Application Development Dept)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9559f32e-2a6e-b786-4224-d65adc9df1a7@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=cloud.wangxiaoyun@huawei.com \
    --cc=dev@dpdk.org \
    --cc=luoxianjun@huawei.com \
    --cc=shahar.belkar@huawei.com \
    --cc=tanya.brokhman@huawei.com \
    --cc=wulike1@huawei.com \
    --cc=xuanziyang2@huawei.com \
    --cc=zhouguoyang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).