From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Moti Haimovsky <motih@mellanox.com>, pascal.mazon@6wind.com
Cc: dev@dpdk.org, Shahaf Shuler <shahafs@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH V5 2/2] net/tap: use new Rx offloads API
Date: Fri, 2 Mar 2018 21:44:28 +0000 [thread overview]
Message-ID: <95d434f5-438a-19a7-1227-18c1230201c0@intel.com> (raw)
In-Reply-To: <1516197874-133169-2-git-send-email-motih@mellanox.com>
On 1/17/2018 2:04 PM, Moti Haimovsky wrote:
> Ethdev Rx offloads API has changed since:
> commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API")
> This commit adds support for the new Rx offloads API.
>
> Signed-off-by: Moti Haimovsky <motih@mellanox.com>
<...>
> +static bool
> +tap_rxq_are_offloads_valid(struct rte_eth_dev *dev, uint64_t offloads)
> +{
> + uint64_t port_offloads = dev->data->dev_conf.rxmode.offloads;
> + uint64_t queue_supp_offloads = tap_rx_offload_get_queue_capa();
> + uint64_t port_supp_offloads = tap_rx_offload_get_port_capa();
> +
> + if ((offloads & (queue_supp_offloads | port_supp_offloads)) !=
> + offloads)
> + return false;
> + if ((port_offloads ^ offloads) & port_supp_offloads)
> + return false;
Hi Moti,
I am getting following error when tried to use tap with bonding:
"Rx queue offloads 0x0 don't match port offloads 0x1000 or supported offloads
0x300e"
What is the intention here? I guess it tries to be sure requested queue offloads
is subsets of port_offloads and offload_capability.
If so not requesting any queue offload should be valid, isn't it?
<...>
next prev parent reply other threads:[~2018-03-02 21:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-04 19:18 [dpdk-dev] [PATCH V3 0/2] net/tap: convert to new ethdev " Moti Haimovsky
2018-01-04 19:18 ` [dpdk-dev] [PATCH V3 1/2] net/tap: convert to new Tx " Moti Haimovsky
2018-01-05 8:18 ` Pascal Mazon
2018-01-04 19:18 ` [dpdk-dev] [PATCH V3 2/2] net/tap: convert to new Rx " Moti Haimovsky
2018-01-05 8:26 ` Pascal Mazon
2018-01-10 16:20 ` [dpdk-dev] [PATCH V4 1/2] net/tap: convert to new Tx " Moti Haimovsky
2018-01-10 16:20 ` [dpdk-dev] [PATCH V4 2/2] net/tap: convert to new Rx " Moti Haimovsky
2018-01-10 16:42 ` Pascal Mazon
2018-01-17 14:04 ` [dpdk-dev] [PATCH V5 1/2] net/tap: use new Tx " Moti Haimovsky
2018-01-17 14:04 ` [dpdk-dev] [PATCH V5 2/2] net/tap: use new Rx " Moti Haimovsky
2018-03-02 21:44 ` Ferruh Yigit [this message]
2018-03-12 14:20 ` Shahaf Shuler
2018-03-12 16:59 ` Ferruh Yigit
2018-03-12 17:58 ` Shahaf Shuler
2018-03-12 19:05 ` Ferruh Yigit
2018-03-13 7:08 ` Shahaf Shuler
2018-03-13 11:56 ` Ferruh Yigit
2018-03-14 5:49 ` Shahaf Shuler
2018-03-14 22:40 ` Ferruh Yigit
2018-03-15 6:16 ` Shahaf Shuler
2018-03-15 14:34 ` Ferruh Yigit
2018-01-18 14:02 ` [dpdk-dev] [PATCH V5 1/2] net/tap: use new Tx " Pascal Mazon
2018-01-18 15:19 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95d434f5-438a-19a7-1227-18c1230201c0@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=motih@mellanox.com \
--cc=pascal.mazon@6wind.com \
--cc=shahafs@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).