From: Andrew Rybchenko <arybchenko@solarflare.com>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>,
"Nicolau, Radu" <radu.nicolau@intel.com>,
Akhil Goyal <akhil.goyal@nxp.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Dilshod Urazov <Dilshod.Urazov@oktetlabs.ru>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] examples/ipsec-secgw: fix to set positive rte_errno
Date: Sat, 6 Jul 2019 11:41:21 +0300 [thread overview]
Message-ID: <972bcbf5-2dc1-39ba-2a27-9684dc065b27@solarflare.com> (raw)
In-Reply-To: <8CEF83825BEC744B83065625E567D7C260DCA66F@IRSMSX108.ger.corp.intel.com>
On 05.07.2019 16:46, Iremonger, Bernard wrote:
> Hi Andrew, Dilshod
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Andrew Rybchenko
>> Sent: Friday, July 5, 2019 1:18 PM
>> To: Nicolau, Radu <radu.nicolau@intel.com>; Akhil Goyal
>> <akhil.goyal@nxp.com>
>> Cc: dev@dpdk.org; Dilshod Urazov <Dilshod.Urazov@oktetlabs.ru>;
>> stable@dpdk.org
>> Subject: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix to set positive
>> rte_errno
>>
>> From: Dilshod Urazov <Dilshod.Urazov@oktetlabs.ru>
>>
>> Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Dilshod Urazov <Dilshod.Urazov@oktetlabs.ru>
>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
>> ---
>> examples/ipsec-secgw/sa.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c index
>> 8d47d1def..8044066a8 100644
>> --- a/examples/ipsec-secgw/sa.c
>> +++ b/examples/ipsec-secgw/sa.c
>> @@ -739,7 +739,7 @@ sa_create(const char *name, int32_t socket_id)
>> RTE_MEMZONE_1GB |
>> RTE_MEMZONE_SIZE_HINT_ONLY);
>> if (mz == NULL) {
>> printf("Failed to allocate SA DB memory\n");
>> - rte_errno = -ENOMEM;
>> + rte_errno = ENOMEM;
>> return NULL;
>> }
>>
>> --
>> 2.17.1
> ./devtools/check-git-log.sh -1
> Wrong headline format:
> examples/ipsec-secgw: fix to set positive rte_errno
>
> Otherwise
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
It does not like underscore in headline. I think in this case it is
better to
keep it as is instead of trying to describe rte_errno is a different way.
Thanks.
next prev parent reply other threads:[~2019-07-06 8:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-05 12:18 [dpdk-stable] " Andrew Rybchenko
2019-07-05 13:46 ` [dpdk-stable] [dpdk-dev] " Iremonger, Bernard
2019-07-06 8:41 ` Andrew Rybchenko [this message]
2019-07-08 12:06 ` [dpdk-stable] " Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=972bcbf5-2dc1-39ba-2a27-9684dc065b27@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=Dilshod.Urazov@oktetlabs.ru \
--cc=akhil.goyal@nxp.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=radu.nicolau@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).