From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Denis Pryazhennikov <denis.pryazhennikov@arknetworks.am>, dev@dpdk.org
Cc: Ivan Malov <ivan.malov@arknetworks.am>,
Viacheslav Galaktionov <viacheslav.galaktionov@arknetworks.am>,
Thomas Monjalon <thomas@monjalon.net>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
"Min Hu (Connor)" <humin29@huawei.com>,
"Wei Hu (Xavier)" <xavier.huwei@huawei.com>,
Chengwen Feng <fengchengwen@huawei.com>,
Chengchang Tang <tangchengchang@huawei.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>
Subject: Re: [RFC PATCH v2 0/3] improve FEC API usage
Date: Mon, 19 Jun 2023 13:36:54 +0100 [thread overview]
Message-ID: <97599564-08da-c64c-b4dd-143f364fb176@amd.com> (raw)
In-Reply-To: <080a8617-0f93-e1f0-afc6-de6503d572c6@amd.com>
On 5/12/2023 12:57 PM, Ferruh Yigit wrote:
> On 5/8/2023 12:47 PM, Denis Pryazhennikov wrote:
>> The documentation for the FEC API is currently incomplete and contains
>> inaccuracies in its descriptions of function parameters.
>> Specifically, the semantics of the fec_capa parameter in rte_eth_fec_set()
>> is not well-defined. It does not provide information on what should
>> be done if only AUTO bit is set or one of the specified FEC modes is
>> not supported. Additionally, the fec_capa parameter in rte_eth_fec_get()
>> implies that more than one FEC mode can be obtained, but it is
>> wrong. Furthermore, the behaviour is undefined in
>> rte_eth_fec_set() when the fec_capa parameter is zero.
>>
>> To address these issues, a patch series has been created that updates
>> the FEC API documentation, renames one of the parameters to improve
>> its clarity and adds a check for zero fec_capability.
>>
>> v2:
>> * Update documentation for rte_eth_fec_set() to fix review comments.
>> * Don't rename the fec_capa parameter of rte_eth_fec_get() but
>> add a proper description instead.
>>
>> Denis Pryazhennikov (3):
>> ethdev: update documentation for API to set FEC
>> ethdev: check that at least one FEC mode is specified
>> ethdev: update documentation for API to get FEC
>>
>
> For series,
> Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
>
>
Series applied to dpdk-next-net/main, thanks.
> +cc Author and reviewer of original patch, if there is no objection I
> can proceed with the set.
>
>
> @Denis, can you please provide Fixes tags too? If you prefer you can
> send a new version with ack and fixes tags.
>
Fixes: b7ccfb09da95 ("ethdev: introduce FEC API")
Cc: stable@dpdk.org
prev parent reply other threads:[~2023-06-19 12:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 10:27 [RFC PATCH " Denis Pryazhennikov
2023-04-28 10:27 ` [RFC PATCH 1/3] ethdev: update documentation for API to set FEC Denis Pryazhennikov
2023-05-02 14:57 ` Ferruh Yigit
2023-04-28 10:27 ` [RFC PATCH 2/3] ethdev: check that at least one FEC mode is specified Denis Pryazhennikov
2023-05-02 14:57 ` Ferruh Yigit
2023-04-28 10:27 ` [RFC PATCH 3/3] ethdev: rename parameter in API to get FEC Denis Pryazhennikov
2023-05-02 15:02 ` Ferruh Yigit
2023-05-04 7:13 ` Denis Pryazhennikov
2023-05-04 7:47 ` Ferruh Yigit
2023-05-08 11:47 ` [RFC PATCH v2 0/3] improve FEC API usage Denis Pryazhennikov
2023-05-08 11:47 ` [RFC PATCH v2 1/3] ethdev: update documentation for API to set FEC Denis Pryazhennikov
2023-05-08 11:47 ` [RFC PATCH v2 2/3] ethdev: check that at least one FEC mode is specified Denis Pryazhennikov
2023-05-08 11:47 ` [RFC PATCH v2 3/3] ethdev: update documentation for API to get FEC Denis Pryazhennikov
2023-05-12 11:57 ` [RFC PATCH v2 0/3] improve FEC API usage Ferruh Yigit
2023-06-07 18:41 ` Ferruh Yigit
2023-06-19 12:36 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97599564-08da-c64c-b4dd-143f364fb176@amd.com \
--to=ferruh.yigit@amd.com \
--cc=ajit.khaparde@broadcom.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=denis.pryazhennikov@arknetworks.am \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=humin29@huawei.com \
--cc=ivan.malov@arknetworks.am \
--cc=tangchengchang@huawei.com \
--cc=thomas@monjalon.net \
--cc=viacheslav.galaktionov@arknetworks.am \
--cc=xavier.huwei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).