From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Pascal Mazon <pascal.mazon@6wind.com>,
Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/tap: add missing newlines in logs
Date: Tue, 18 Jul 2017 08:51:57 +0100 [thread overview]
Message-ID: <97a7ff76-3370-12d3-164d-72375f3e0906@intel.com> (raw)
In-Reply-To: <a1a658ae-fe3e-540a-aa20-a6bfb333fff0@6wind.com>
On 7/10/2017 8:07 AM, Pascal Mazon wrote:
>
> On 07/06/2017 05:28 PM, Thomas Monjalon wrote:
>> Some logs are missing the newline character \n.
>>
>> The logs using only line can be checked with this command:
>> git grep 'RTE_LOG(.*".*[^n]"' drivers/net/tap/
This shows that some other drivers have same problem.
Any volunteer to fix them are quite welcome.
>>
>> Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD")
>> Fixes: 268483dc2086 ("net/tap: add preliminary support for flow API")
>> Fixes: 2bc06869cd94 ("net/tap: add remote netdevice traffic capture")
>> Fixes: bf7b7f437b49 ("net/tap: create netdevice during probing")
>>
>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Acked-by: Pascal Mazon <pascal.mazon@6wind.com>
Applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2017-07-18 7:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-06 15:28 Thomas Monjalon
2017-07-10 7:07 ` Pascal Mazon
2017-07-18 7:51 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97a7ff76-3370-12d3-164d-72375f3e0906@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=pascal.mazon@6wind.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).