From: Ferruh Yigit <ferruh.yigit@intel.com>
To: John Daley <johndale@cisco.com>
Cc: dev@dpdk.org, Hyong Youb Kim <hyonkim@cisco.com>
Subject: Re: [dpdk-dev] [PATCH v3 02/10] net/enic: allow the user to change RSS settings
Date: Fri, 9 Mar 2018 14:35:02 +0000 [thread overview]
Message-ID: <97aef536-8d73-7269-3897-a6aee26f3a63@intel.com> (raw)
In-Reply-To: <20180308024702.25974-3-johndale@cisco.com>
On 3/8/2018 2:46 AM, John Daley wrote:
> From: Hyong Youb Kim <hyonkim@cisco.com>
>
> Currently, when more than 1 receive queues are configured, the driver
> always enables RSS with the driver's own default hash type, key, and
> RETA. The user is unable to change any of the RSS settings. Address
> this by implementing the ethdev RSS API as follows.
>
> Correctly report the RETA size, key size, and supported hash types
> through rte_eth_dev_info.
>
> During dev_configure(), initialize RSS according to the device's
> mq_mode and rss_conf. Start with the default RETA, and use the default
> key unless a custom key is provided.
>
> Add the RETA and rss_conf query/set handlers to let the user change
> RSS settings after the initial configuration. The hardware is able to
> change hash type, key, and RETA individually. So, the handlers change
> only the affected settings.
>
> Refactor/rename several functions in order to make their intentions
> clear. For example, remove all traces of RSS from
> enicpmd_vlan_offload_set() as it is confusing.
>
> Signed-off-by: Hyong Youb Kim <hyonkim@cisco.com>
> Reviewed-by: John Daley <johndale@cisco.com>
<...>
> @@ -889,44 +889,42 @@ static int enic_dev_open(struct enic *enic)
> return err;
> }
>
> -static int enic_set_rsskey(struct enic *enic)
> +static int enic_set_rsskey(struct enic *enic, uint8_t *user_key)
> {
> dma_addr_t rss_key_buf_pa;
> union vnic_rss_key *rss_key_buf_va = NULL;
> - static union vnic_rss_key rss_key = {
> - .key = {
> - [0] = {.b = {85, 67, 83, 97, 119, 101, 115, 111, 109, 101}},
> - [1] = {.b = {80, 65, 76, 79, 117, 110, 105, 113, 117, 101}},
> - [2] = {.b = {76, 73, 78, 85, 88, 114, 111, 99, 107, 115}},
> - [3] = {.b = {69, 78, 73, 67, 105, 115, 99, 111, 111, 108}},
> - }
> - };
> - int err;
> + int err, i;
> u8 name[NAME_MAX];
>
> + RTE_ASSERT(use_key != NULL);
there is a typo, "use_key" should be "user_key" which is causing a build error.
If RTE_ASSERT used in the code, should test enabling CONFIG_RTE_ENABLE_ASSERT
option too.
next prev parent reply other threads:[~2018-03-09 14:35 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-24 19:17 [dpdk-dev] [PATCH] net/enic: remove 'extern' in .h file function declarations John Daley
2018-02-24 19:17 ` [dpdk-dev] [PATCH] net/enic: allow the user to change RSS settings John Daley
2018-02-24 19:17 ` [dpdk-dev] [PATCH] net/enic: heed the requested max Rx packet size John Daley
2018-02-24 19:17 ` [dpdk-dev] [PATCH] net/enic: remove the VLAN filter handler John Daley
2018-02-24 19:17 ` [dpdk-dev] [PATCH] net/enic: add Rx/Tx queue configuration getters John Daley
2018-02-24 19:17 ` [dpdk-dev] [PATCH] net/enic: allocate stats DMA buffer upfront during probe John Daley
2018-02-24 19:17 ` [dpdk-dev] [PATCH] net/enic: support Rx queue interrupts John Daley
2018-02-24 19:17 ` [dpdk-dev] [PATCH] doc: describe Rx bytes counter behavior for enic John Daley
2018-02-24 19:17 ` [dpdk-dev] [PATCH] net/enic: use memcpy to avoid strict aliasing warnings John Daley
2018-02-24 19:17 ` [dpdk-dev] [PATCH] net/enic: support for meson John Daley
2018-03-06 1:46 ` [dpdk-dev] [PATCH v2 00/10] enic patchset John Daley
2018-03-06 1:46 ` [dpdk-dev] [PATCH v2 01/10] net/enic: remove 'extern' in .h file function declarations John Daley
2018-03-08 2:46 ` [dpdk-dev] [PATCH v3 00/10] enic PMD patchset John Daley
2018-03-08 2:46 ` [dpdk-dev] [PATCH v3 01/10] net/enic: remove 'extern' in .h file function declarations John Daley
2018-03-08 2:46 ` [dpdk-dev] [PATCH v3 02/10] net/enic: allow the user to change RSS settings John Daley
2018-03-09 14:35 ` Ferruh Yigit [this message]
2018-03-08 2:46 ` [dpdk-dev] [PATCH v3 03/10] net/enic: heed the requested max Rx packet size John Daley
2018-03-09 15:03 ` Ferruh Yigit
2018-03-09 15:51 ` Ananyev, Konstantin
2018-03-09 15:57 ` Ferruh Yigit
2018-03-10 0:37 ` Hyong Youb Kim
2018-03-08 2:46 ` [dpdk-dev] [PATCH v3 04/10] net/enic: remove the VLAN filter handler John Daley
2018-03-08 2:46 ` [dpdk-dev] [PATCH v3 05/10] net/enic: add Rx/Tx queue configuration getters John Daley
2018-03-08 2:46 ` [dpdk-dev] [PATCH v3 06/10] net/enic: allocate stats DMA buffer upfront during probe John Daley
2018-03-08 2:46 ` [dpdk-dev] [PATCH v3 07/10] net/enic: support Rx queue interrupts John Daley
2018-03-08 2:47 ` [dpdk-dev] [PATCH v3 08/10] doc: describe Rx bytes counter behavior for enic John Daley
2018-03-08 22:14 ` Stephen Hemminger
2018-03-09 0:52 ` Hyong Youb Kim
2018-03-09 1:48 ` Stephen Hemminger
2018-03-08 2:47 ` [dpdk-dev] [PATCH v3 09/10] net/enic: use memcpy to avoid strict aliasing warnings John Daley
2018-03-08 2:47 ` [dpdk-dev] [PATCH v3 10/10] net/enic: support for meson John Daley
2018-03-08 9:49 ` Bruce Richardson
2018-03-09 16:00 ` [dpdk-dev] [PATCH v3 00/10] enic PMD patchset Ferruh Yigit
2018-03-10 0:49 ` Hyong Youb Kim
2018-03-06 1:46 ` [dpdk-dev] [PATCH v2 02/10] net/enic: allow the user to change RSS settings John Daley
2018-03-06 1:46 ` [dpdk-dev] [PATCH v2 03/10] net/enic: heed the requested max Rx packet size John Daley
2018-03-06 1:46 ` [dpdk-dev] [PATCH v2 04/10] net/enic: remove the VLAN filter handler John Daley
2018-03-06 1:46 ` [dpdk-dev] [PATCH v2 05/10] net/enic: add Rx/Tx queue configuration getters John Daley
2018-03-06 1:46 ` [dpdk-dev] [PATCH v2 06/10] net/enic: allocate stats DMA buffer upfront during probe John Daley
2018-03-06 1:46 ` [dpdk-dev] [PATCH v2 07/10] net/enic: support Rx queue interrupts John Daley
2018-03-06 1:46 ` [dpdk-dev] [PATCH v2 08/10] doc: describe Rx bytes counter behavior for enic John Daley
2018-03-06 1:46 ` [dpdk-dev] [PATCH v2 09/10] net/enic: use memcpy to avoid strict aliasing warnings John Daley
2018-03-06 1:46 ` [dpdk-dev] [PATCH v2 10/10] net/enic: support for meson John Daley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97aef536-8d73-7269-3897-a6aee26f3a63@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=hyonkim@cisco.com \
--cc=johndale@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).