From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Xiaojun Liu <xiaojun.liu@silicom.co.il>,
xiao.w.wang@intel.com, qi.z.zhang@intel.com,
ngai-mint.kwan@intel.com, jacob.e.keller@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4 0/5] support fm10k switch management
Date: Fri, 17 Apr 2020 15:18:46 +0100 [thread overview]
Message-ID: <9867e3b7-01a7-21e8-3060-8997d38ee61c@intel.com> (raw)
In-Reply-To: <1586413588-5759-1-git-send-email-xiaojun.liu@silicom.co.il>
On 4/9/2020 7:26 AM, Xiaojun Liu wrote:
> V4:
> * Add I2C to control the inside LED and PHY.
> * Add SBUS to communicate with spico.
> * Add registers defination.
> * Add switch management log API.
> * Add switch management structures.
> * Add epl serdes include loading spico,
> controlling pcsl, dma, dfe, ical.
> * Add spico code.
> * Add state machine for epl lane and port.
> * Add external port management.
> * Add ffu to support offload flow into HW.
> It supports forward, mirror, push VLAN, pop VLAN.
> * Add config file to configure debug log, port speed,
> epl port mapping dpdk port, flowset.
> * Add statistics includes epl port, ffu rule, dpdk port.
> * Add flow interface to support offload flow into HW.
> * Add switch management, includes initialization,
> port mapping, epl port link, LED controller, interrupt handler.
> * Split dev_init to 2 parts in ethdev. First only register
> the port in switch management; second init hook will be
> called after all the pf are registered.
> * Add switch interrupt support.
> * Add fm10k_mirror_rule_set/fm10k_mirror_rule_reset.
> * Add fm10k_dev_filter_ctrl to support flow operation.
> * Add dpdk port and pf mapping.
> * Modify Makefile to add new files building
>
> Xiaojun Liu (5):
> net/fm10k: add basic functions for switch management
> net/fm10k: add epl serdes and port control functions
> net/fm10k: add ffu and statistics and config file functions
> net/fm10k: add flow interface and switch management
> net/fm10k: add switch management support
>
With 'CONFIG_RTE_FM10K_SWITCH_MANAGEMENT=y' I am getting following build errors,
can you please check them?
1) T=ppc_64-power8-linuxapp-gcc
.../drivers/net/fm10k/switch/fm10k_stats.c:758:26: error: ‘ts.tv_sec’ is used
uninitialized in this function [-Werror=uninitialized]
counters->timestamp = ts.tv_sec * 1000000 + ts.tv_usec;
~~^~~~~~~
.../drivers/net/fm10k/switch/fm10k_stats.c:758:48: error: ‘ts.tv_usec’ is used
uninitialized in this function [-Werror=uninitialized]
counters->timestamp = ts.tv_sec * 1000000 + ts.tv_usec;
~~^~~~~~~~
2) T=arm64-armv8a-linuxapp-gcc
.../drivers/net/fm10k/switch/../base/fm10k_osdep.h:49:20: error: conflicting
types for ‘u64’...
#define __le64 u64...
^~~...
.../drivers/net/fm10k/switch/../base/fm10k_osdep.h:44:20: note: previous
declaration of ‘u64’ was here...
typedef uint64_t u64;...
^~~...
3) T=x86_64-native-linuxapp-clang
.../drivers/net/fm10k/switch/fm10k_ffu.c:821:6: error: variable 'tcam_slice' is
used uninitialized whenever 'if' condition is false
[-Werror,-Wsometimes-uninitialized]
if (sglort_vid_tcam) {
^~~~~~~~~~~~~~~
.../drivers/net/fm10k/switch/fm10k_ffu.c:838:32: note: uninitialized use occurs here
fm10k_ffu_always_mismatch(sw, tcam_slice + 1, rule_id);
^~~~~~~~~~
.../drivers/net/fm10k/switch/fm10k_ffu.c:821:2: note: remove the 'if' if its
condition is always true
if (sglort_vid_tcam) {
^~~~~~~~~~~~~~~~~~~~~
.../drivers/net/fm10k/switch/fm10k_ffu.c:775:35: note: initialize the variable
'tcam_slice' to silence this warning
uint16_t sram_idx = 0, tcam_slice, sram_slice, i;
^
= 0
.../drivers/net/fm10k/switch/fm10k_ffu.c:906:6: error: variable 'tcam_slice' is
used uninitialized whenever 'if' condition is false
[-Werror,-Wsometimes-uninitialized]
if (sglort_vid_tcam) {
^~~~~~~~~~~~~~~
.../drivers/net/fm10k/switch/fm10k_ffu.c:923:32: note: uninitialized use occurs here
fm10k_ffu_always_mismatch(sw, tcam_slice + 1, rule_id);
^~~~~~~~~~
.../drivers/net/fm10k/switch/fm10k_ffu.c:906:2: note: remove the 'if' if its
condition is always true
if (sglort_vid_tcam) {
^~~~~~~~~~~~~~~~~~~~~
.../drivers/net/fm10k/switch/fm10k_ffu.c:869:35: note: initialize the variable
'tcam_slice' to silence this warning
uint16_t sram_idx = 0, tcam_slice, sram_slice, i;
^
= 0
.../drivers/net/fm10k/switch/fm10k_serdes.c:1922:9: error: taking the absolute
value of unsigned type 'unsigned int' has no effect [-Werror,-Wabsolute-value]
diff = abs(val2 - val1);
^
.../drivers/net/fm10k/switch/fm10k_serdes.c:1922:9: note: remove the call to
'abs' since unsigned values cannot be negative
diff = abs(val2 - val1);
^~~
4) T=x86_64-native-linuxapp-gcc
.../drivers/net/fm10k/switch/fm10k_serdes.c: In function
‘fm10k_epl_serdes_get_ical_result’:
.../drivers/net/fm10k/switch/fm10k_serdes.c:1922:9: error: taking the absolute
value of unsigned type ‘uint32_t’ {aka ‘unsigned int’} has no effect
[-Werror=absolute-value]
1922 | diff = abs(val2 - val1);
| ^~~
cc1: all warnings being treated as errors
make[7]: *** [.../mk/internal/rte.compile-pre.mk:114: fm10k_serdes.o] Error 1
make[7]: *** Waiting for unfinished jobs....
.../drivers/net/fm10k/switch/fm10k_stats.c: In function ‘fm10k_get_port_counters’:
.../drivers/net/fm10k/switch/fm10k_stats.c:758:26: error: ‘ts.tv_sec’ is used
uninitialized in this function [-Werror=uninitialized]
758 | counters->timestamp = ts.tv_sec * 1000000 + ts.tv_usec;
| ~~^~~~~~~
.../drivers/net/fm10k/switch/fm10k_stats.c:758:48: error: ‘ts.tv_usec’ is used
uninitialized in this function [-Werror=uninitialized]
758 | counters->timestamp = ts.tv_sec * 1000000 + ts.tv_usec;
| ~~^~~~~~~~
cc1: all warnings being treated as errors
next prev parent reply other threads:[~2020-04-17 14:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1584687199-19198-1-git-send-email-xiaojun.liu@silicom.co.il>
2020-04-09 6:26 ` Xiaojun Liu
2020-04-09 6:26 ` [dpdk-dev] [PATCH v4 1/5] net/fm10k: add basic functions for " Xiaojun Liu
2020-04-17 13:56 ` Ferruh Yigit
2020-04-09 6:26 ` [dpdk-dev] [PATCH v4 2/5] net/fm10k: add epl serdes and port control functions Xiaojun Liu
2020-04-17 13:57 ` Ferruh Yigit
2020-04-09 6:26 ` [dpdk-dev] [PATCH v4 3/5] net/fm10k: add ffu and statistics and config file functions Xiaojun Liu
2020-04-09 6:26 ` [dpdk-dev] [PATCH v4 4/5] net/fm10k: add flow interface and switch management Xiaojun Liu
2020-04-09 6:26 ` [dpdk-dev] [PATCH v4 5/5] net/fm10k: add switch management support Xiaojun Liu
2020-04-20 5:09 ` Ye Xiaolong
2020-04-16 8:33 ` [dpdk-dev] [PATCH v4 0/5] support fm10k switch management Wang, Xiao W
2020-04-17 4:02 ` Ye Xiaolong
2020-04-17 14:18 ` Ferruh Yigit [this message]
2020-04-20 4:55 ` Ye Xiaolong
2020-04-20 6:37 ` Xiaojun Liu
2020-04-20 8:14 ` Ye Xiaolong
2020-04-20 8:24 ` Xiaojun Liu
2020-04-20 13:05 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9867e3b7-01a7-21e8-3060-8997d38ee61c@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=jacob.e.keller@intel.com \
--cc=ngai-mint.kwan@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=xiao.w.wang@intel.com \
--cc=xiaojun.liu@silicom.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).