From: "Kobylinski, MichalX" <michalx.kobylinski@intel.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>,
Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] lpm: merge tbl24 and tbl8 structures
Date: Fri, 4 Mar 2016 15:11:01 +0000 [thread overview]
Message-ID: <987EE72691933347B9F0B5C19E71B5BB1F042C6E@IRSMSX101.ger.corp.intel.com> (raw)
In-Reply-To: <20160304150337.GA2125@localhost.localdomain>
> -----Original Message-----
> From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com]
> Sent: Friday, March 4, 2016 4:04 PM
> To: Thomas Monjalon <thomas.monjalon@6wind.com>
> Cc: Richardson, Bruce <bruce.richardson@intel.com>; dev@dpdk.org;
> Kobylinski, MichalX <michalx.kobylinski@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] lpm: merge tbl24 and tbl8 structures
> Importance: High
>
> On Fri, Mar 04, 2016 at 03:57:43PM +0100, Thomas Monjalon wrote:
> > 2015-11-24 14:25, Bruce Richardson:
> > > The tbl8 and tbl24 structures were essentially identical except for
> > > slightly different names for one or two fields. Merge these two
> > > structures into a single structure definition.
> > >
> > > Two fields have been renamed as part of this change: the "ext_entry"
> > > field in the tbl24 has been renamed to "valid_group" to match the
> > > tbl8 value to make the merge easier, and the "tbl8_gindex" field has
> > > been renamed to "group_idx". The "valid_group" field now serves two
> > > purposes: in a tbl8 it indicates if the group, i.e. the tbl8, is
> > > valid, and in a tbl24, it indicates if the "group_idx" is valid,
> > > i.e. whether the value is a next_hop or a tbl8 index. [The name
> > > "group_idx" was used to make this latter link between the fields
> > > clearer]
> > >
> > > Suggested-by: Vladimir Medvedkin <medvedkinv@gmail.com>
> > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> >
> > This patch was forgotten.
> > Michal, Jerin, maybe you'll have to rebase on top of it.
ok, I'll rebase on top of it.
>
> I wait for Michal to send the next version. I will the v5 rebased on Michal patch.
>
> Jerin
>
> >
> > Applied, thanks
prev parent reply other threads:[~2016-03-04 15:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 14:25 [dpdk-dev] [PATCH] Rel 2.3: lpm cleanup, merge data structures Bruce Richardson
2015-11-24 14:25 ` [dpdk-dev] [PATCH] lpm: merge tbl24 and tbl8 structures Bruce Richardson
2016-03-04 14:57 ` Thomas Monjalon
2016-03-04 15:03 ` Jerin Jacob
2016-03-04 15:11 ` Kobylinski, MichalX [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=987EE72691933347B9F0B5C19E71B5BB1F042C6E@IRSMSX101.ger.corp.intel.com \
--to=michalx.kobylinski@intel.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).