From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Andrew Rybchenko" <arybchenko@solarflare.com>, <olivier.matz@6wind.com>
Cc: <stephen@networkplumber.org>, <harry.van.haaren@intel.com>,
<konstantin.ananyev@intel.com>, <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 2/2] mbuf: add bulk free function
Date: Thu, 26 Sep 2019 17:35:52 +0200 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35B42AD2@smartserver.smartshare.dk> (raw)
In-Reply-To: <96d37240-9f33-3252-7e0a-fc8ab4fc136e@solarflare.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Andrew Rybchenko
> Sent: Thursday, September 26, 2019 11:27 AM
> To: Morten Brørup; olivier.matz@6wind.com
> Cc: stephen@networkplumber.org; harry.van.haaren@intel.com;
> konstantin.ananyev@intel.com; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 2/2] mbuf: add bulk free function
>
> On 9/25/19 3:03 PM, Morten Brørup wrote:
> > Add function for freeing a bulk of mbufs.
> >
> > Signed-off-by: Morten Brørup <mb@smartsharesystems.com>
> > ---
> > lib/librte_mbuf/rte_mbuf.c | 35 +++++++++++++++++++++++++++++++++++
> > lib/librte_mbuf/rte_mbuf.h | 16 +++++-----------
> > 2 files changed, 40 insertions(+), 11 deletions(-)
> >
> > diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c
> > index 37718d49c..b63a0eced 100644
> > --- a/lib/librte_mbuf/rte_mbuf.c
> > +++ b/lib/librte_mbuf/rte_mbuf.c
> > @@ -245,6 +245,41 @@ int rte_mbuf_check(const struct rte_mbuf *m, int
> is_header,
> > return 0;
> > }
> >
> > +/**
> > + * Maximum bulk of mbufs rte_pktmbuf_free_bulk() returns to mempool.
> > + */
> > +#define RTE_PKTMBUF_FREE_BULK_SZ 64
> > +
> > +/* Free a bulk of mbufs back into their original mempools. */
> > +void rte_pktmbuf_free_bulk(struct rte_mbuf **mbufs, unsigned int count)
> > +{
> > + struct rte_mbuf *m, *free[RTE_PKTMBUF_FREE_BULK_SZ];
> > + unsigned int idx, nb_free = 0;
> > +
> > + for (idx = 0; idx < count; idx++) {
> > + m = mbufs[idx];
> > + if (unlikely(m == NULL))
> > + continue;
> > +
> > + __rte_mbuf_sanity_check(m, 1);
> > + m = rte_pktmbuf_prefree_seg(m);
>
> Who cares about next segments if any? It looks like nobody.
>
> > + if (unlikely(m == NULL))
> > + continue;
> > +
> > + if (nb_free >= RTE_PKTMBUF_FREE_BULK_SZ ||
> > + (nb_free > 0 && m->pool != free[0]->pool)) {
> > + rte_mempool_put_bulk(free[0]->pool,
> > + (void **)free, nb_free);
> > + nb_free = 0;
> > + }
> > +
> > + free[nb_free++] = m;
> > + }
> > +
> > + if (nb_free > 0)
> > + rte_mempool_put_bulk(free[0]->pool, (void **)free, nb_free);
> > +}
> > +
> > /* dump a mbuf on console */
> > void
> > rte_pktmbuf_dump(FILE *f, const struct rte_mbuf *m, unsigned dump_len)
> > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
> > index f2e174da1..6910b3fe6 100644
> > --- a/lib/librte_mbuf/rte_mbuf.h
> > +++ b/lib/librte_mbuf/rte_mbuf.h
> > @@ -1908,21 +1908,15 @@ static inline void rte_pktmbuf_free(struct
> rte_mbuf *m)
> > }
> >
> > /**
> > - * Free a bulk of mbufs back into their original mempool.
> > + * Free a bulk of mbufs back into their original mempools.
> > *
> > * @param mbufs
> > - * Array of pointers to mbufs
> > + * Array of pointers to mbufs.
> > + * The array may contain NULL pointers.
> > * @param count
> > - * Array size
> > + * Array size.
> > */
> > -static inline void
> > -rte_pktmbuf_free_bulk(struct rte_mbuf **mbufs, unsigned count)
> > -{
> > - unsigned idx = 0;
> > -
> > - for (idx = 0; idx < count; idx++)
> > - rte_pktmbuf_free(mbufs[idx]);
> > -}
> > +void rte_pktmbuf_free_bulk(struct rte_mbuf **mbufs, unsigned int count);
> >
> > /**
> > * Creates a "clone" of the given packet mbuf.
>
> Is it just a mistake that two patches are not squashed?
>
Yes. Plenty of rookie git mistakes by my hand.
We don't use git in-house, and I have no git experience. So I'm trying my best, relying on the DPDK Contributor guide and git documentation. :-)
Med venlig hilsen / kind regards
- Morten Brørup
next prev parent reply other threads:[~2019-09-26 15:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 12:03 [dpdk-dev] [PATCH v2 0/2] " Morten Brørup
2019-09-25 12:03 ` [dpdk-dev] [PATCH v2 1/2] " Morten Brørup
2019-09-25 12:03 ` [dpdk-dev] [PATCH v2 2/2] " Morten Brørup
[not found] ` <20190925120542.A51B41BE84@dpdk.org>
2019-09-25 12:17 ` [dpdk-dev] |WARNING| pw59738 " Morten Brørup
2019-09-25 23:37 ` Stephen Hemminger
2019-09-27 6:42 ` Morten Brørup
2019-09-25 19:02 ` [dpdk-dev] " Mattias Rönnblom
2019-09-26 8:30 ` Bruce Richardson
2019-09-26 20:11 ` Mattias Rönnblom
2019-09-27 9:09 ` Bruce Richardson
2019-09-26 9:26 ` Andrew Rybchenko
2019-09-26 15:35 ` Morten Brørup [this message]
2019-09-26 10:23 ` Ananyev, Konstantin
2019-09-27 10:22 ` Morten Brørup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35B42AD2@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=olivier.matz@6wind.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).