From: "Morten Brørup" <mb@smartsharesystems.com>
To: "David Marchand" <david.marchand@redhat.com>, <dev@dpdk.org>
Cc: <thomas@monjalon.net>,
"Bruce Richardson" <bruce.richardson@intel.com>,
"Dmitry Kozlyuk" <dmitry.kozliuk@gmail.com>,
"Narcisa Ana Maria Vasile" <navasile@linux.microsoft.com>,
"Dmitry Malloy" <dmitrym@microsoft.com>,
"Pallavi Kadam" <pallavi.kadam@intel.com>
Subject: RE: [PATCH] eal: factorize lcore main loop
Date: Wed, 23 Mar 2022 13:01:52 +0100 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D86F62@smartserver.smartshare.dk> (raw)
In-Reply-To: <20220323093001.20618-1-david.marchand@redhat.com>
> From: David Marchand [mailto:david.marchand@redhat.com]
> Sent: Wednesday, 23 March 2022 10.30
>
> All OS implementations provide the same main loop.
> Introduce helpers (shared for Linux and FreeBSD) to handle
> synchronisation
> between main and threads and factorize the rest as common code.
> Thread id are now logged as string in a common format across OS.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> I had this patch in store for a long time.
> I don't particularly care about it, it's not fixing anything.
> But it seems a good cleanup/consolidation, so I rebased it and I am
> sending it to get feedback.
>
LGTM. I'm always in favor of cleaning up! :-)
Thank you, David.
Acked-By: Morten Brørup <mb@smartsharesystems.com>
next prev parent reply other threads:[~2022-03-23 12:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-23 9:30 David Marchand
2022-03-23 12:01 ` Morten Brørup [this message]
2022-03-24 8:31 ` Tyler Retzlaff
2022-03-24 14:44 ` David Marchand
2022-03-25 12:11 ` Tyler Retzlaff
2022-03-25 14:58 ` Thomas Monjalon
2022-03-25 15:09 ` David Marchand
2022-03-25 16:38 ` Tyler Retzlaff
2022-03-25 12:23 ` Tyler Retzlaff
2022-04-01 8:44 ` [PATCH v2 1/2] eal: cleanup lcore ID hand-over David Marchand
2022-04-01 8:44 ` [PATCH v2 2/2] eal: factorize lcore main loop David Marchand
2022-04-05 7:05 ` David Marchand
2022-04-05 16:34 ` [PATCH v3 1/2] eal: cleanup lcore ID hand-over David Marchand
2022-04-05 16:34 ` [PATCH v3 2/2] eal: factorize lcore main loop David Marchand
2022-04-14 11:48 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35D86F62@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).