From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Kamalakshitha Aligeri" <kamalakshitha.aligeri@arm.com>,
<honnappa.nagarahalli@arm.com>, <bruce.richardson@intel.com>,
<beilei.xing@intel.com>, <Ruifeng.Wang@arm.com>,
<Feifei.Wang2@arm.com>, <konstantin.ananyev@huawei.com>,
<thomas@monjalon.net>, <olivier.matz@6wind.com>,
<andrew.rybchenko@oktetlabs.ru>
Cc: <dev@dpdk.org>, <nd@arm.com>,
"Ruifeng Wang" <ruifeng.wang@arm.com>,
"Feifei Wang" <feifei.wang2@arm.com>
Subject: RE: [PATCH v11 2/2] net/i40e: replace put function
Date: Tue, 18 Jul 2023 13:36:43 +0200 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D87A6C@smartserver.smartshare.dk> (raw)
In-Reply-To: <20230705180233.880203-2-kamalakshitha.aligeri@arm.com>
> From: Kamalakshitha Aligeri [mailto:kamalakshitha.aligeri@arm.com]
> Sent: Wednesday, 5 July 2023 20.03
>
> Integrated zero-copy put API in mempool cache in i40e PMD.
> On Ampere Altra server, l3fwd single core's performance improves by 5%
> with the new API
>
> Signed-off-by: Kamalakshitha Aligeri <kamalakshitha.aligeri@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> Reviewed-by: Feifei Wang <feifei.wang2@arm.com>
> ---
> drivers/net/i40e/i40e_rxtx_vec_common.h | 27 ++++++++++++++++++++-----
> 1 file changed, 22 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h
> b/drivers/net/i40e/i40e_rxtx_vec_common.h
> index fe1a6ec75e..35cdb31b2e 100644
> --- a/drivers/net/i40e/i40e_rxtx_vec_common.h
> +++ b/drivers/net/i40e/i40e_rxtx_vec_common.h
> @@ -95,18 +95,35 @@ i40e_tx_free_bufs(struct i40e_tx_queue *txq)
>
> n = txq->tx_rs_thresh;
>
> - /* first buffer to free from S/W ring is at index
> - * tx_next_dd - (tx_rs_thresh-1)
> - */
> + /* first buffer to free from S/W ring is at index
> + * tx_next_dd - (tx_rs_thresh-1)
> + */
> txep = &txq->sw_ring[txq->tx_next_dd - (n - 1)];
>
> if (txq->offloads & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE) {
> + struct rte_mempool *mp = txep[0].mbuf->pool;
> + struct rte_mempool_cache *cache =
> rte_mempool_default_cache(mp, rte_lcore_id());
> + void **cache_objs;
> +
> + if (unlikely(!cache))
> + goto fallback;
> +
> + cache_objs = rte_mempool_cache_zc_put_bulk(cache, mp, n);
> + if (unlikely(!cache_objs))
> + goto fallback;
> +
> for (i = 0; i < n; i++) {
> - free[i] = txep[i].mbuf;
> + cache_objs[i] = txep[i].mbuf;
> /* no need to reset txep[i].mbuf in vector path */
> }
> - rte_mempool_put_bulk(free[0]->pool, (void **)free, n);
> goto done;
> +
> +fallback:
> + for (i = 0; i < n; i++)
> + free[i] = txep[i].mbuf;
> + rte_mempool_generic_put(mp, (void **)free, n, cache);
Patchwork, when building with gcc-debug for FreeBSD13-64 and RHEL92-64, complains that "free" may be used uninitialized in rte_mempool_check_cookies() called via RTE_MEMPOOL_CHECK_COOKIES() from rte_mempool_generic_put() here. But "free" is initialized by the preceding loop, so I don't understand why GCC thinks it may be uninitialized.
Does adding curly braces to the loop help GCC understand that the free array is initialized, or what is the proper workaround?
> + goto done;
> +
> }
>
> m = rte_pktmbuf_prefree_seg(txep[0].mbuf);
> --
> 2.25.1
Acked-by: Morten Brørup <mb@smartsharesystems.com>
next prev parent reply other threads:[~2023-07-18 11:36 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 18:10 [PATCH v10 0/2] zero-copy get and put functions Kamalakshitha Aligeri
2023-02-24 18:10 ` [PATCH v10 1/2] mempool cache: add " Kamalakshitha Aligeri
2023-02-27 7:12 ` Ruifeng Wang
2023-04-06 10:13 ` Morten Brørup
2023-04-25 13:14 ` Morten Brørup
2023-06-07 10:32 ` Thomas Monjalon
2023-06-07 12:04 ` Morten Brørup
2023-06-07 12:32 ` Thomas Monjalon
2023-06-07 13:42 ` Morten Brørup
2023-06-07 14:05 ` Morten Brørup
2023-07-05 17:18 ` [PATCH v11 " Kamalakshitha Aligeri
2023-07-05 17:18 ` [PATCH v11 2/2] net/i40e: replace put function Kamalakshitha Aligeri
2023-07-06 9:20 ` Konstantin Ananyev
2023-07-06 13:32 ` Morten Brørup
2023-07-06 9:20 ` [PATCH v11 1/2] mempool cache: add zero-copy get and put functions Konstantin Ananyev
2023-07-05 18:02 ` Kamalakshitha Aligeri
2023-07-05 18:02 ` [PATCH v11 2/2] net/i40e: replace put function Kamalakshitha Aligeri
2023-07-18 11:36 ` Morten Brørup [this message]
2023-07-21 16:28 ` [PATCH v12 1/2] mempool cache: add zero-copy get and put functions Dharmik Thakkar
2023-07-21 16:28 ` [PATCH v12 2/2] net/i40e: replace put function Dharmik Thakkar
2023-07-31 12:16 ` [PATCH v12 1/2] mempool cache: add zero-copy get and put functions Thomas Monjalon
2023-10-13 5:41 ` Morten Brørup
2023-07-18 10:14 ` [PATCH v11 " Morten Brørup
2023-02-24 18:10 ` [PATCH v10 2/2] net/i40e: replace put function Kamalakshitha Aligeri
2023-03-02 21:44 ` Kamalakshitha Aligeri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35D87A6C@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=Feifei.Wang2@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=honnappa.nagarahalli@arm.com \
--cc=kamalakshitha.aligeri@arm.com \
--cc=konstantin.ananyev@huawei.com \
--cc=nd@arm.com \
--cc=olivier.matz@6wind.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).