From: "Morten Brørup" <mb@smartsharesystems.com>
To: "Stephen Hemminger" <stephen@networkplumber.org>, <dev@dpdk.org>
Cc: <mattias.ronnblom@ericsson.com>,
"Bruce Richardson" <bruce.richardson@intel.com>,
"Anatoly Burakov" <anatoly.burakov@intel.com>,
"David Marchand" <david.marchand@redhat.com>, <stable@dpdk.org>
Subject: RE: [PATCH v2 1/2] random: initialize the random state for non-EAL threads
Date: Mon, 2 Oct 2023 11:00:16 +0200 [thread overview]
Message-ID: <98CBD80474FA8B44BF855DF32C47DC35D87C28@smartserver.smartshare.dk> (raw)
In-Reply-To: <20230907152456.20570-2-stephen@networkplumber.org>
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Thursday, 7 September 2023 17.25
>
> The per-lcore PRNG was not initializing the rand_state of all
> the lcores. Any usage of rte_random by a non-EAL lcore would
> use rand_states[RTE_MAX_LCORE] which was never initialized.
>
> Fix by using RTE_DIM() which will get all lcores.
>
> Fixes: 3f002f069612 ("eal: replace libc-based random generation with LFSR")
> Cc: mattias.ronnblom@ericsson.com
> Acked-by: Morten Brørup <mb@smartsharesystems.com>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> lib/eal/common/rte_random.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/eal/common/rte_random.c b/lib/eal/common/rte_random.c
> index 53636331a27b..812e5b4757b5 100644
> --- a/lib/eal/common/rte_random.c
> +++ b/lib/eal/common/rte_random.c
> @@ -84,7 +84,7 @@ rte_srand(uint64_t seed)
> unsigned int lcore_id;
>
> /* add lcore_id to seed to avoid having the same sequence */
> - for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++)
> + for (lcore_id = 0; lcore_id < RTE_DIM(rand_states); lcore_id++)
> __rte_srand_lfsr258(seed + lcore_id, &rand_states[lcore_id]);
> }
>
> --
> 2.39.2
Now also...
Reviewed-by: Morten Brørup <mb@smartsharesystems.com>
parent reply other threads:[~2023-10-02 9:00 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20230907152456.20570-2-stephen@networkplumber.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98CBD80474FA8B44BF855DF32C47DC35D87C28@smartserver.smartshare.dk \
--to=mb@smartsharesystems.com \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=mattias.ronnblom@ericsson.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).